doc: Mention that BerkeleyDB is for legacy wallet in build-unix #23446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates build-unix for the descriptor wallet, and prepares for eventual legacy wallet deprecation. - Move 'descriptor wallet' dependencies above legacy wallet deps both for Debian and Fedora. - Explicitly mention 'legacy wallet' where referring to the BerkeleyDB wallet. Shorten BerkeleyDB instruction to a single paragraph.
fadb112 to
7eb5b25
Compare
|
Concept ACK and thank you very much. |
|
Concept ACK |
lsilva01
approved these changes
Nov 6, 2021
|
Concept ACK |
hebasto
approved these changes
Nov 7, 2021
| SQLite is required for the descriptor wallet: | ||
|
|
||
| sudo apt install libsqlite3-dev | ||
|
|
||
| Berkeley DB is required for the legacy wallet. Ubuntu and Debian have their own `libdb-dev` and `libdb++-dev` packages, |
There was a problem hiding this comment.
nit: s/"Ubuntu and Debian"/"Debian-based systems"/
There was a problem hiding this comment.
s/"Ubuntu and Debian"/"Debian, Ubuntu and other Debian-based systems"/
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Nov 8, 2021
This was referenced Mar 16, 2022
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Mar 17, 2022
…n build-osx.md 57f3f5c doc: s/Compiler/Dependency in dependencies.md (fanquake) bf84677 doc: cleanup wallet docs in build-osx.md (fanquake) Pull request description: Re-order legacy and descriptor wallet section. Installing sqlite isn't required (the version pre-installed on macOS is just as good as what will be installed via `brew`). Remove prelude that pointlessly repeats the same info. Basically the macOS version of bitcoin#23446. Includes a small fixup from bitcoin#23565. ACKs for top commit: RandyMcMillan: ACK 57f3f5c hebasto: ACK 57f3f5c, I have reviewed the changes and they look OK, I agree they can be merged. Tree-SHA512: a1ca5f73aa4f4f56de747fd9669bce572c1d7d23925afb47b5d963314df1738762ea26428c040e9c706d288eb7e775227d2387a322cda065885b89c6a619314f
fanquake
added a commit
to fanquake/bitcoin
that referenced
this pull request
Mar 23, 2022
Removes redundant notes for setting CC & CXX now that Clang is well and truly the base compiler. Also cleans up the wallet docs, i.e bitcoin#23446. Make the notes more similar to FreeBSD.
fanquake
added a commit
to fanquake/bitcoin
that referenced
this pull request
Mar 23, 2022
Removes redundant notes for setting CC & CXX now that Clang is well and truly the base compiler. Cleans up the wallet docs, i.e bitcoin#23446. Make the notes more similar to FreeBSD.
fanquake
added a commit
to fanquake/bitcoin
that referenced
this pull request
Mar 24, 2022
Re-order legacy and descriptor wallet section. Add an additional configure example. NetBSD version of bitcoin#23446.
fanquake
added a commit
that referenced
this pull request
Mar 24, 2022
…-netbsd.md 7ac7198 doc: mention that BDB is for the legacy wallet in build-netbsd.md (fanquake) Pull request description: Re-order legacy and descriptor wallet section. Add an additional configure example. NetBSD version of #23446. ACKs for top commit: shaavan: ACK 7ac7198 Tree-SHA512: 5c8218424a6b12e9eee00b44dd93f9fe95fd9afa468563167feb255663720a84b55e75850985cfae3ca288a6a76e17c00ccce60b8180f92875eeaee2c9afa843
fanquake
added a commit
to bitcoin-core/gui
that referenced
this pull request
Mar 25, 2022
…wallet in build-freebsd.md b5ba3b5 doc: mention that BDB is for the legacy wallet in build-freebsd.md (fanquake) Pull request description: Re-order legacy and descriptor wallet section. Remove prelude that pointlessly repeats the same info. Cleanup configure examples. FreeBSD version of bitcoin/bitcoin#23446. ACKs for top commit: shaavan: ACK b5ba3b5 Tree-SHA512: ed85acee5c1b933b57d038d144768da1c4b1f1cfd441d9191353b82d50af16adb10aabb3b4661dc9aee54405ab3af2b800e39f9973261a041b2cf0db8675b5c4
fanquake
added a commit
to fanquake/bitcoin
that referenced
this pull request
Mar 28, 2022
Removes redundant notes for setting CC & CXX now that Clang is well and truly the base compiler. Cleans up the wallet docs, i.e bitcoin#23446. Make the notes more similar to FreeBSD.
fanquake
added a commit
that referenced
this pull request
Apr 6, 2022
a2b56dc doc: update OpenBSD build docs for 7.0 (fanquake) Pull request description: Removes redundant notes for setting `CC` &`CXX` now that Clang is well and truly the base compiler. See: https://www.openbsd.org/70.html > Disabled base-gcc on amd64. Cleans up the wallet docs, i.e #23446. Make the notes more similar to the FreeBSD notes. ACKs for top commit: shaavan: ACK a2b56dc theStack: ACK a2b56dc Tree-SHA512: a0494de3b168e5c35f541edf62dcb42529b23387febbe4c004eb82ef9aff6f97def43b6cd5c91e13612c5247767d79553efcd21b9792ccb6a9608302c5d082f1
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates build-unix for the descriptor wallet, and prepares for eventual legacy wallet deprecation.