doc: mention that BDB is for the legacy wallet in build-freebsd.md #24600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
its0x08
approved these changes
Mar 20, 2022
5047048 to
c577c79
Compare
|
Rebased past #24646. |
Re-order legacy and descriptor wallet section. Remove prelude that pointlessly reqpeats the same info. Cleanup configure examples.
c577c79 to
b5ba3b5
Compare
|
Mentioning BDB is for legacy wallets would be beneficial |
|
@shaavan would you like to review this? |
shaavan
approved these changes
Mar 25, 2022
There was a problem hiding this comment.
ACK b5ba3b5
I like the idea of moving sections talking about descriptor wallets (about adding support and compiling) before legacy wallets because:
- We want to encourage users to build a descriptor wallet over the legacy wallet. And talking about descriptor wallet first is one way to do so.
- It maintains consistency with other updated documentation, prioritized for the descriptor wallet over the legacy wallet.
I verified that:
- Links for FreeBSD and descriptor wallet direct to the correct webpage and documentation, respectively.
- The code corresponding to installing db5 and compiling descriptor wallet and GUI (a move-only change) is correct.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-order legacy and descriptor wallet section.
Remove prelude that pointlessly repeats the same info.
Cleanup configure examples.
FreeBSD version of #23446.