Move CBlockTreeDB to node/blockstorage #22242
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Concept ACK |
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced Jun 14, 2021
Closed
|
Concept ACK |
facf8b0 to
fa7d90d
Compare
fa7d90d to
c747c05
Compare
|
Concept ACK - want to rebase/fixup this? |
c747c05 to
2dbd4b3
Compare
added 4 commits
November 23, 2021 12:42
This avoids compile errors in future commits.
Can be reviewed with --color-moved=dimmed-zebra
Can be reviewed with --ignore-all-space --word-diff-regex=.
There is no need to expose the internals in the header when only the blockstorage implementation (and txindex for historical reasons) care about them.
2dbd4b3 to
fad4d81
Compare
This was referenced Nov 23, 2021
|
🐙 This pull request conflicts with the target branch and needs rebase. Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft". |
There hasn't been much activity lately and the patch still needs rebase. What is the status here?
|
fanquake
added a commit
that referenced
this pull request
Sep 5, 2023
fae4055 scripted-diff: Rename CBlockTreeDB -> BlockTreeDB (MarcoFalke) faf6303 Fixup style of moved code (MarcoFalke) fa65111 move-only: Move CBlockTreeDB to node/blockstorage (MarcoFalke) fa86855 index: Drop legacy -txindex check (MarcoFalke) fa69148 scripted-diff: Use blocks_path where possible (MarcoFalke) Pull request description: The only reason for the check was to print a warning about an increase in storage use. Now that 22.x is EOL and everyone should have migrated (or decided to not care about storage use), remove the check. Also, a move-only commit is included. (Rebased from #22242) ACKs for top commit: TheCharlatan: ACK fae4055, though I lack historical context to really judge the second commit fa86855. stickies-v: ACK fae4055 Tree-SHA512: 9da8f48767ae52d8e8e21c09a40c949cc0838794f1856cc5f58a91acd3f00a3bca818c8082242b3fdc9ca5badb09059570bb3870850d3807b75a8e23b5222da1
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The block index (
CBlockTreeDB) is required to write and read blocks, so move it to blockstorage