Skip to content

Conversation

sipa
Copy link
Member

@sipa sipa commented Apr 2, 2021

This updates our src/secp256k1 subtree to the latest upstream master. The changes include:

  • The introduction of safegcd-based modular inverses, reducing ECDSA signing time by 25%-30% and ECDSA verification time by 15%-17%.
  • Removal of libgmp as an (optional) dependency (which wasn't used in the Bitcoin Core build)
  • CI changes (Travis -> Cirrus)
  • Build system improvements

@sipa
Copy link
Member Author

sipa commented Apr 2, 2021

@sipsorcery Is there a way of disabling C4146 (at least inside src/secp256k1, and at least it being treated as an error)? All these instances of negating a positive number are well-defined and intentional...

@sipsorcery
Copy link
Contributor

@sipa yes the warning should be disabled by adding <DisableSpecificWarnings>4146</DisableSpecificWarnings> to build_msvc\libsecp256k1\libsecp256k1.vcxproj.

Probably clearer putting it this way: replace the ClCompile XML node with the below:

<ClCompile>   
<PreprocessorDefinitions>ENABLE_MODULE_ECDH;ENABLE_MODULE_RECOVERY;ENABLE_MODULE_EXTRAKEYS;ENABLE_MODULE_SCHNORRSIG;%(PreprocessorDefinitions)</PreprocessorDefinitions>
  <AdditionalIncludeDirectories>..\..\src\secp256k1;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
  <DisableSpecificWarnings>4146</DisableSpecificWarnings>
</ClCompile>

@sipa
Copy link
Member Author

sipa commented Apr 2, 2021

@sipsorcery Thanks!

@sipa sipa force-pushed the 202104_secp256k1 branch from b527b3d to 1322c67 Compare April 2, 2021 19:20
@sipa sipa force-pushed the 202104_secp256k1 branch from 1322c67 to 8a83b5a Compare April 2, 2021 20:19
@DrahtBot
Copy link
Contributor

DrahtBot commented Apr 3, 2021

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@DrahtBot
Copy link
Contributor

DrahtBot commented Apr 4, 2021

Gitian builds

File commit 9565daf
(master)
commit 4c060c8
(master and this pull)
*-aarch64-linux-gnu-debug.tar.gz c0046768eeb849d7... c49e0ffa987280f5...
*-aarch64-linux-gnu.tar.gz 1580ba8ff2495a87... c28e8c4629e52694...
*-arm-linux-gnueabihf-debug.tar.gz 91183e9932c2e107... 6067411af5bfb57f...
*-arm-linux-gnueabihf.tar.gz 6b7e8e5049846b30... 64bd6c077194d59a...
*-osx-unsigned.dmg b0d2e99986e8ac94... c54896065868dfa1...
*-osx64.tar.gz 88c06b4f009d7892... eb576531a1819d44...
*-powerpc64-linux-gnu-debug.tar.gz 55f612a413399c33... 4d6a2da7b0250b15...
*-powerpc64-linux-gnu.tar.gz f9e81e514b8a33d1... 11160996fd682d38...
*-powerpc64le-linux-gnu-debug.tar.gz 14862e5f2925c0b8... 83988ca58c3b54cf...
*-powerpc64le-linux-gnu.tar.gz 9df6f7c7a73f7ea8... afa04f89e42b7a22...
*-riscv64-linux-gnu-debug.tar.gz 4c7ebb4b0b29dae2... 38d9f719bc49a20d...
*-riscv64-linux-gnu.tar.gz 3ecd5c46eb4e7efe... bb732eccd2f3df60...
*-win64-debug.zip 8a1a6858530ff8a8... 8896b1ad643edc58...
*-win64-setup-unsigned.exe 1a7a08827e187490... 2b41daa5cc0d9b67...
*-win64.zip 551e458426e9c99f... 7c1f830ce1fc6605...
*-x86_64-linux-gnu-debug.tar.gz 6d5d800afe9370d0... 706f6cb38498e72f...
*-x86_64-linux-gnu.tar.gz b3e3816046e6073c... 4661f5e10f7cb111...
*.tar.gz 1c2514829bd0e839... 06ad5107d364330a...
bitcoin-core-linux-22-res.yml c55772b82aae9480... 90fb8e3982dbb83d...
bitcoin-core-osx-22-res.yml 493ec22f2f5371da... 54b103d2bcf4b120...
bitcoin-core-win-22-res.yml 9d11fd74afb57ec0... 7592117df7dc7260...
linux-build.log 974cce601787cdfe... 4cbb577dbbe594c7...
osx-build.log eb340cf8538d6aca... 609fdd5e264b3f21...
win-build.log 1bf905c67e8aa459... 750063037088b595...
bitcoin-core-linux-22-res.yml.diff a91d3a57dee8afe0...
bitcoin-core-osx-22-res.yml.diff 5cc71879fa088cca...
bitcoin-core-win-22-res.yml.diff ff1aa350d5cab3ca...
linux-build.log.diff f7deb97a6cbe8115...
osx-build.log.diff 410297d8e553bfb2...
win-build.log.diff 0eaa2ae0560c3294...

@DrahtBot
Copy link
Contributor

DrahtBot commented Apr 6, 2021

Guix builds

File commit 590e49c
(master)
commit 58cdde6
(master and this pull)
*-aarch64-linux-gnu-debug.tar.gz f0a68eb9e2279c63... 3bc511fc72b3cf6f...
*-aarch64-linux-gnu.tar.gz 13199419b3b64e98... 0bfb9e168d59c1c5...
*-arm-linux-gnueabihf-debug.tar.gz ffe1971af4043eb6... ebd4c61b3e74753b...
*-arm-linux-gnueabihf.tar.gz d82d03881fb3c3ca... f6e70939d3156356...
*-osx-unsigned.dmg 0cad1e816f1150d5... 21836ea3bcfcd28c...
*-osx-unsigned.tar.gz acaf0c3f66486b00... bd8dfb7dd03064d9...
*-osx64.tar.gz dc4d6a00bd9a1527... e9b5872a0c68a696...
*-powerpc64-linux-gnu-debug.tar.gz a196518428c4430e... 69f0b746650e18ab...
*-powerpc64-linux-gnu.tar.gz 7fb19f766e4fe244... 9ddbcd91e25131ea...
*-powerpc64le-linux-gnu-debug.tar.gz 4e2b6b4c0c7f80ba... ff3e743e6724a43d...
*-powerpc64le-linux-gnu.tar.gz 950a04d5cc040b61... 95554fc5022bff2a...
*-riscv64-linux-gnu-debug.tar.gz 476ceb4fbf92e658... 91fb9a3bc6479c5e...
*-riscv64-linux-gnu.tar.gz cd74b7396c2f6d18... aba29c78fecb8b67...
*-win-unsigned.tar.gz 4b5618315e50cd6f... 90fdf989d7f17c69...
*-win64-debug.zip b6c0751aafd352ea... bf0a802e7d770589...
*-win64-setup-unsigned.exe 8a36329599e8236c... 67f8d8b0072b52aa...
*-win64.zip 0dbbf7adedb432b7... 5da5d19b59b89bf1...
*-x86_64-linux-gnu-debug.tar.gz c900123a9ba582fc... 6d75f1c24ea4f9e1...
*-x86_64-linux-gnu.tar.gz 93803385e1e2d2d8... c36c0688d5530ea8...
*.tar.gz 6d6abb344d7d6d41... 21d39dcc72c60152...
guix_build.log 5a52bb8b0e0fe6b1... df2aeb115f64e94c...
guix_build.log.diff 147f8410d22f3589...

@fanquake
Copy link
Member

fanquake commented Apr 7, 2021

Concept ACK. I've completed one (pruned) sync using this branch. @jamesob want to do some benchmarking?

sipa added 3 commits April 23, 2021 11:35
efad350 Merge bitcoin#906: Use modified divsteps with initial delta=1/2 for constant-time
cc2c09e Merge bitcoin#918: Clean up configuration in gen_context
0706796 add ECMULT_GEN_PREC_BITS to basic_config.h
a3aa262 gen_context: Don't include basic-config.h
be0609f Add unit tests for edge cases with delta=1/2 variant of divsteps
cd393ce Optimization: only do 59 hddivsteps per iteration instead of 62
277b224 Use modified divsteps with initial delta=1/2 for constant-time
376ca36 Fix typo in explanation
1e5d50f Merge bitcoin#889: fix uninitialized read in tests
c083cc6 Merge bitcoin#903: Make argument of fe_normalizes_to_zero{_var} const
6e89853 Merge bitcoin#907: changed import to use brackets <> for openssl
4504472 changed import to use brackets <> for openssl as they are not local to the project
26de4df Merge bitcoin#831: Safegcd inverses, drop Jacobi symbols, remove libgmp
23c3fb6 Make argument of fe_normalizes_to_zero{_var} const
24ad04f Make scalar_inverse{,_var} benchmark scale with SECP256K1_BENCH_ITERS
ebc1af7 Optimization: track f,g limb count and pass to new variable-time update_fg_var
b306935 Optimization: use formulas instead of lookup tables for cancelling g bits
9164a1b Optimization: special-case zero modulus limbs in modinv64
1f233b3 Remove num/gmp support
20448b8 Remove unused Jacobi symbol support
5437e7b Remove unused scalar_sqr
aa9cc52 Improve field/scalar inverse tests
1e0e885 Make field/scalar code use the new modinv modules for inverses
436281a Move secp256k1_fe_inverse{_var} to per-impl files
aa404d5 Move secp256k1_scalar_{inverse{_var},is_even} to per-impl files
08d5496 Improve bounds checks in modinv modules
151aac0 Add tests for modinv modules
d8a92fc Add extensive comments on the safegcd algorithm and implementation
8e415ac Add safegcd based modular inverse modules
de0a643 Add secp256k1_ctz{32,64}_var functions
4c3ba88 Merge bitcoin#901: ci: Switch all Linux builds to Debian and more improvements
9361f36 ci: Select number of parallel make jobs depending on CI environment
28eccdf ci: Split output of logs into multiple sections
c7f754f ci: Run PRs on merge result instead of on the source branch
b994a8b ci: Print information about binaries using "file"
f24e122 ci: Switch all Linux builds to Debian
ebdba03 Merge bitcoin#891: build: Add workaround for automake 1.13 and older
3a8b47b Merge bitcoin#894: ctime_test: move context randomization test to the end
7d3497c ctime_test: move context randomization test to the end
99a1cfe print warnings for conditional-uninitialized
3d2cf6c initialize variable in tests
f329bba build: Add workaround for automake 1.13 and older
24d1656 Merge bitcoin#882: Use bit ops instead of int mult for constant-time logic in gej_add_ge
e491d06 Use bit ops instead of int mult for constant-time logic in gej_add_ge
f8c0b57 Merge bitcoin#864: Add support for Cirrus CI
cc2a545 ci: Refactor Nix shell files
2480e55 ci: Remove support for Travis CI
2b359f1 ci: Enable simple cache for brewing valgrind on macOS
8c02e46 ci: Add support for Cirrus CI
659d0d4 Merge bitcoin#880: Add parens around ROUND_TO_ALIGN's parameter.
b6f6498 Add parens around ROUND_TO_ALIGN's parameter. This makes the macro robust against a hypothetical ROUND_TO_ALIGN(foo ? sizeA : size B) invocation.
a4abaab Merge bitcoin#877: Add missing secp256k1_ge_set_gej_var decl.
5671e5f Merge bitcoin#874: Remove underscores from header defs.
db72678 Merge bitcoin#878: Remove unused secp256k1_fe_inv_all_var
b732701 Merge bitcoin#875: Avoid casting (void**) values.
75d2ae1 Remove unused secp256k1_fe_inv_all_var
482e4a9 Add missing secp256k1_ge_set_gej_var decl.
2730618 Avoid casting (void**) values. Replaced with an expression that only casts (void*) values.
fb390c5 Remove underscores from header defs. This makes them consistent with other files and avoids reserved identifiers.
f2d9aea Merge bitcoin#862: Autoconf improvements
328aaef Merge bitcoin#845: Extract the secret key from a keypair
3c15130 Improve CC_FOR_BUILD detection
47802a4 Restructure and tidy configure.ac
252c19d Ask brew for valgrind include path
8c727b9 Merge bitcoin#860: fixed trivial typo
b7bc3a4 fixed typo
33cb3c2 Add secret key extraction from keypair to constant time tests
36d9dc1 Add seckey extraction from keypair to the extrakeys tests
fc96aa7 Add a function to extract the secretkey from a keypair
98dac87 Merge bitcoin#858: Fix insecure links
07aa4c7 Fix insecure links
b61f9da Merge bitcoin#857: docs: fix simple typo, dependecy -> dependency
18aadf9 docs: fix simple typo, dependecy -> dependency
2d9e717 Merge bitcoin#852: Add sage script for generating scalar_split_lambda constants
dc6e5c3 Merge bitcoin#854: Rename msg32 to msghash32 in ecdsa_sign/verify and add explanation
6e85d67 Rename tweak to tweak32 in public API
f587f04 Rename msg32 to msghash32 in ecdsa_sign/verify and add explanation
329a2e0 sage: Add script for generating scalar_split_lambda constants
8f0c6f1 Merge bitcoin#851: make test count iteration configurable by environment variable
f4fa8d2 forbid a test iteration of 0 or less
f554dfc sage: Reorganize files
3a10696 Merge bitcoin#849: Convert Sage code to Python 3 (as used by Sage >= 9)
13c88ef Convert Sage code to Python 3 (as used by Sage >= 9)
0ce4554 make test count iteration configurable by environment variable
9e5939d Merge bitcoin#835: Don't use reserved identifiers memczero and benchmark_verify_t
d0a83f7 Merge bitcoin#839: Prevent arithmetic on NULL pointer if the scratch space is too small
903b16a Merge bitcoin#840: Return NULL early in context_preallocated_create if flags invalid
1f4dd03 Typedef (u)int128_t only when they're not provided by the compiler
ebfa205 Return NULL early in context_preallocated_create if flags invalid
29a299e Run the undefined behaviour sanitizer on Travis
7506e06 Prevent arithmetic on NULL pointer if the scratch space is too small
e89278f Don't use reserved identifiers memczero and benchmark_verify_t

git-subtree-dir: src/secp256k1
git-subtree-split: efad350
@sipa sipa force-pushed the 202104_secp256k1 branch from 8a83b5a to 5c7ee1b Compare April 23, 2021 19:16
@sipa
Copy link
Member Author

sipa commented Apr 23, 2021

Updated to also include the now-merged bitcoin-core/secp256k1#906.

@jamesob
Copy link
Contributor

jamesob commented Apr 23, 2021

@jamesob want to do some benchmarking?

Apologies, missed this notification. Will get some going in the next day or so.

@DrahtBot
Copy link
Contributor

DrahtBot commented May 3, 2021

🕵️ @practicalswift has been requested to review this pull request as specified in the REVIEWERS file.

@Sjors
Copy link
Member

Sjors commented May 5, 2021

I'm running a full IBD with 5c7ee1b on mainnet with -assumevalid=0 on macOS 11.3.1 (Intel). It's definately not a benchmark, because I'm using an external USB drive for -blocksdir which seems to dramatically slow it down. But at least it's a consensus check.

System: macOS 11.3, x86_64-little_endian-lp64
Using the 'sse4(1way),sse41(4way),avx2(8way)' SHA256 implementation
Using 16 MiB out of 32/2 requested for signature cache, able to store 524288 elements
Using 16 MiB out of 32/2 requested for script execution cache, able to store 524288 elements
Script verification uses 15 additional threads

Update 2021-05-07: that took a while, but it reached the tip

@laanwj
Copy link
Member

laanwj commented May 12, 2021

Added this to my FreeBSD node for testing. Configure phase and compilation goes without hitch at least.

@jamesob
Copy link
Contributor

jamesob commented May 17, 2021

Apologies, missed this notification. Will get some going in the next day or so.

Still planned, but debugging some build weirdness on the bench machines (bad interaction between ancient Debian and c++17 requirements).

@jamesob
Copy link
Contributor

jamesob commented May 19, 2021

Happy to report that I'm seeing 1.07x speedup here.

ibd local range 500000 510000

commands index

bench name command
ibd.local.range.500000.510000 bitcoind -dbcache=300 -debug=coindb -debug=bench -listen=0 -connect=0 -addnode=127.0.0.1:8888 -prune=9999999 -printtoconsole=0 -assumevalid=0

#21573 vs. $mergebase (absolute)

bench name x #21573 $mergebase
ibd.local.range.500000.510000.total_secs 2 1805.3634 (± 3.2389) 1938.7935 (± 2.3256)
ibd.local.range.500000.510000.peak_rss_KiB 2 1701526.0000 (± 19670.0000) 1720014.0000 (± 10298.0000)

#21573 vs. $mergebase (relative)

bench name x #21573 $mergebase
ibd.local.range.500000.510000.total_secs 2 1 1.074
ibd.local.range.500000.510000.peak_rss_KiB 2 1 1.011

@sipa
Copy link
Member Author

sipa commented May 19, 2021

@jamesob Any possibility of measuring CPU time (as opposed to wall clock time)?

@jamesob
Copy link
Contributor

jamesob commented May 20, 2021

Here's the second benchmark run, reporting CPU seconds:

#21573 vs. $mergebase (absolute)

bench name x #21573 $mergebase
ibd.local.range.500000.510000.total_secs 2 1809.3671 (± 3.3923) 1958.0218 (± 10.2106)
ibd.local.range.500000.510000.peak_rss_KiB 2 1690334.0000 (± 6038.0000) 1703732.0000 (± 16204.0000)
ibd.local.range.500000.510000.cpu_kernel_secs 2 315.8800 (± 0.5400) 328.8000 (± 5.0200)
ibd.local.range.500000.510000.cpu_user_secs 2 10365.2350 (± 3.6150) 11663.7200 (± 12.4200)

#21573 vs. $mergebase (relative)

bench name x #21573 $mergebase
ibd.local.range.500000.510000.total_secs 2 1 1.082
ibd.local.range.500000.510000.peak_rss_KiB 2 1 1.008
ibd.local.range.500000.510000.cpu_kernel_secs 2 1 1.041
ibd.local.range.500000.510000.cpu_user_secs 2 1 1.125

@sipa
Copy link
Member Author

sipa commented Jun 7, 2021

Anything left to do here?

@laanwj
Copy link
Member

laanwj commented Jun 7, 2021

I don't think so.
Tested ACK 5c7ee1b

@laanwj laanwj merged commit 359f721 into bitcoin:master Jun 7, 2021
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Jun 9, 2021
UdjinM6 pushed a commit to UdjinM6/dash that referenced this pull request Aug 10, 2021
5c7ee1b libsecp256k1 no longer has --with-bignum= configure option (Pieter Wuille)
bdca9bc Squashed 'src/secp256k1/' changes from 3967d96..efad350 (Pieter Wuille)
cabb566 Disable certain false positive warnings for libsecp256k1 msvc build (Pieter Wuille)

Pull request description:

  This updates our src/secp256k1 subtree to the latest upstream master. The changes include:

  * The introduction of safegcd-based modular inverses, reducing ECDSA signing time by 25%-30% and ECDSA verification time by 15%-17%.
    * [Original paper](https://gcd.cr.yp.to/papers.html) by Daniel J. Bernstein and Bo-Yin Yang
    * [Implementation](bitcoin-core/secp256k1#767) by Peter Dettman; [final](bitcoin-core/secp256k1#831) version
    * [Explanation](https://github.com/bitcoin-core/secp256k1/blob/master/doc/safegcd_implementation.md) of the algorithm using Python snippets
    * [Analysis](https://github.com/sipa/safegcd-bounds) of the maximum number of iterations the algorithm needs
    * [Formal proof in Coq](https://medium.com/blockstream/a-formal-proof-of-safegcd-bounds-695e1735a348) by Russell O'Connor, for a high-level equivalent algorithm
  * Removal of libgmp as an (optional) dependency (which wasn't used in the Bitcoin Core build)
  * CI changes (Travis -> Cirrus)
  * Build system improvements

ACKs for top commit:
  laanwj:
    Tested ACK 5c7ee1b

Tree-SHA512: ad8ac3746264d279556a4aa7efdde3733e114fdba8856dd53218588521f04d83950366f5c1ea8fd56329b4c7fe08eedf8e206f8f26dbe3f0f81852e138655431
5tefan pushed a commit to 5tefan/dash that referenced this pull request Aug 12, 2021
5c7ee1b libsecp256k1 no longer has --with-bignum= configure option (Pieter Wuille)
bdca9bc Squashed 'src/secp256k1/' changes from 3967d96..efad350 (Pieter Wuille)
cabb566 Disable certain false positive warnings for libsecp256k1 msvc build (Pieter Wuille)

Pull request description:

  This updates our src/secp256k1 subtree to the latest upstream master. The changes include:

  * The introduction of safegcd-based modular inverses, reducing ECDSA signing time by 25%-30% and ECDSA verification time by 15%-17%.
    * [Original paper](https://gcd.cr.yp.to/papers.html) by Daniel J. Bernstein and Bo-Yin Yang
    * [Implementation](bitcoin-core/secp256k1#767) by Peter Dettman; [final](bitcoin-core/secp256k1#831) version
    * [Explanation](https://github.com/bitcoin-core/secp256k1/blob/master/doc/safegcd_implementation.md) of the algorithm using Python snippets
    * [Analysis](https://github.com/sipa/safegcd-bounds) of the maximum number of iterations the algorithm needs
    * [Formal proof in Coq](https://medium.com/blockstream/a-formal-proof-of-safegcd-bounds-695e1735a348) by Russell O'Connor, for a high-level equivalent algorithm
  * Removal of libgmp as an (optional) dependency (which wasn't used in the Bitcoin Core build)
  * CI changes (Travis -> Cirrus)
  * Build system improvements

ACKs for top commit:
  laanwj:
    Tested ACK 5c7ee1b

Tree-SHA512: ad8ac3746264d279556a4aa7efdde3733e114fdba8856dd53218588521f04d83950366f5c1ea8fd56329b4c7fe08eedf8e206f8f26dbe3f0f81852e138655431
gwillen pushed a commit to ElementsProject/elements that referenced this pull request Jun 1, 2022
Just did this manually with `-s ours` to keep our current version of secp-zkp.

We should update secp-zkp, but this upstream merge doesn't have any API changes
so it's ok to skip it for now.
hebasto added a commit to hebasto/bitcoin that referenced this pull request Jun 28, 2022
Unused since bitcoin#19944:
- `USE_FIELD_10X26`
- `USE_FIELD_5X52`
- `USE_SCALAR_4X64`
- `USE_SCALAR_8X32`

Unused since bitcoin#20147:
- `USE_ENDOMORPHISM`

Unused since bitcoin#21573:
- `USE_FIELD_INV_BUILTIN`
- `USE_FIELD_INV_NUM`
- `USE_NUM_GMP`
- `USE_NUM_NONE`
- `USE_SCALAR_INV_BUILTIN`
- `USE_SCALAR_INV_NUM`
maflcko pushed a commit to bitcoin-core/gui that referenced this pull request Jun 29, 2022
…_config.h`

1d1546e build: Clean up `build_msvc/libsecp256k1_config.h` (Hennadii Stepanov)

Pull request description:

  Unused since bitcoin/bitcoin#19944:
  - `USE_FIELD_10X26`
  - `USE_FIELD_5X52`
  - `USE_SCALAR_4X64`
  - `USE_SCALAR_8X32`

  Unused since bitcoin/bitcoin#20147:
  - `USE_ENDOMORPHISM`

  Unused since bitcoin/bitcoin#21573:
  - `USE_FIELD_INV_BUILTIN`
  - `USE_FIELD_INV_NUM`
  - `USE_NUM_GMP`
  - `USE_NUM_NONE`
  - `USE_SCALAR_INV_BUILTIN`
  - `USE_SCALAR_INV_NUM`

ACKs for top commit:
  sipa:
    utACK 1d1546e (if CI is happy)

Tree-SHA512: 7c4946c1bddd86cb71ea5c881aca94c1e4be3fc7ebd26962f025c65acdff65937e8c51ff6e87a89f9c0c0c59fef8285fc16f63b912ce2a4e76f8ca01fd4c4522
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Jun 29, 2022
1d1546e build: Clean up `build_msvc/libsecp256k1_config.h` (Hennadii Stepanov)

Pull request description:

  Unused since bitcoin#19944:
  - `USE_FIELD_10X26`
  - `USE_FIELD_5X52`
  - `USE_SCALAR_4X64`
  - `USE_SCALAR_8X32`

  Unused since bitcoin#20147:
  - `USE_ENDOMORPHISM`

  Unused since bitcoin#21573:
  - `USE_FIELD_INV_BUILTIN`
  - `USE_FIELD_INV_NUM`
  - `USE_NUM_GMP`
  - `USE_NUM_NONE`
  - `USE_SCALAR_INV_BUILTIN`
  - `USE_SCALAR_INV_NUM`

ACKs for top commit:
  sipa:
    utACK 1d1546e (if CI is happy)

Tree-SHA512: 7c4946c1bddd86cb71ea5c881aca94c1e4be3fc7ebd26962f025c65acdff65937e8c51ff6e87a89f9c0c0c59fef8285fc16f63b912ce2a4e76f8ca01fd4c4522
janus pushed a commit to BitgesellOfficial/bitgesell that referenced this pull request Aug 4, 2022
Unused since bitcoin/bitcoin#19944:
- `USE_FIELD_10X26`
- `USE_FIELD_5X52`
- `USE_SCALAR_4X64`
- `USE_SCALAR_8X32`

Unused since bitcoin/bitcoin#20147:
- `USE_ENDOMORPHISM`

Unused since bitcoin/bitcoin#21573:
- `USE_FIELD_INV_BUILTIN`
- `USE_FIELD_INV_NUM`
- `USE_NUM_GMP`
- `USE_NUM_NONE`
- `USE_SCALAR_INV_BUILTIN`
- `USE_SCALAR_INV_NUM`
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants