test: add ParseUInt16() unit test and fuzz coverage #21488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cr ACK 3d086f4: patch looks correct & more coverage is better than less coverage |
kiminuo
reviewed
Mar 21, 2021
Comment on lines
+1551
to
+1552
| BOOST_CHECK(!ParseUInt16("0x1", &n)); // no hex | ||
| BOOST_CHECK(!ParseUInt16("0x1", &n)); // no hex |
There was a problem hiding this comment.
These two lines look the same to me.
There was a problem hiding this comment.
Thanks! Fixed in #21491, co-crediting you
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Mar 21, 2021
3d086f4 test: add ParseUInt16() test coverage (Jon Atack) Pull request description: `ParseUInt16()` was just added in bitcoin#21328. ACKs for top commit: practicalswift: cr ACK 3d086f4: patch looks correct & more coverage is better than less coverage Tree-SHA512: bf7f96deb7c1531419565907f0ea8a8e32b368d4b823a3e80928b2c118edbf643ea06e357b4b5504a89f855caeed289daa9f823c740231ed6ad1b8ed00285ce8
fanquake
added a commit
to bitcoin-core/gui
that referenced
this pull request
Mar 22, 2021
7e34448 test: remove duplicate assertions in util_tests (Jon Atack) Pull request description: as noticed by Kiminuo in bitcoin/bitcoin#21488 (comment) ACKs for top commit: practicalswift: cr ACK 7e34448: patch looks correct vasild: ACK 7e34448 Tree-SHA512: ad3d5983ad3a665155d766843dfda7178ced47e82154838331e428ed0828a467c1cf4bf99270aaf191e94156d485fafd0a7d5bc68248c4c1304a00ca5a2a9d2e
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Mar 22, 2021
7e34448 test: remove duplicate assertions in util_tests (Jon Atack) Pull request description: as noticed by Kiminuo in bitcoin#21488 (comment) ACKs for top commit: practicalswift: cr ACK 7e34448: patch looks correct vasild: ACK 7e34448 Tree-SHA512: ad3d5983ad3a665155d766843dfda7178ced47e82154838331e428ed0828a467c1cf4bf99270aaf191e94156d485fafd0a7d5bc68248c4c1304a00ca5a2a9d2e
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Feb 21, 2022
Summary: This is a backport of [[bitcoin/bitcoin#21328 | core#21328]] [2/3] and [[bitcoin/bitcoin#21488 | core#21488]] (unit tests) bitcoin/bitcoin@2875a76 Depends on D11077 and D11081 Test Plan: `ninja all check-all bitcoin-fuzzers` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Subscribers: Fabien Differential Revision: https://reviews.bitcoinabc.org/D11078
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ParseUInt16()was just added in #21328.