Skip to content

Conversation

jonatack
Copy link
Member

as noticed by Kiminuo in #21488 (comment)

Co-authored-by: Kiminuo <kiminuo@protonmail.com>
@practicalswift
Copy link
Contributor

cr ACK 7e34448: patch looks correct
cr ACK 7e34448: patch looks correct

Copy link
Contributor

@vasild vasild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 7e34448

@fanquake fanquake merged commit 80cb51c into bitcoin:master Mar 22, 2021
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Mar 22, 2021
7e34448 test: remove duplicate assertions in util_tests (Jon Atack)

Pull request description:

  as noticed by Kiminuo in bitcoin#21488 (comment)

ACKs for top commit:
  practicalswift:
    cr ACK 7e34448: patch looks correct
  vasild:
    ACK 7e34448

Tree-SHA512: ad3d5983ad3a665155d766843dfda7178ced47e82154838331e428ed0828a467c1cf4bf99270aaf191e94156d485fafd0a7d5bc68248c4c1304a00ca5a2a9d2e
@jonatack jonatack deleted the remove-duplicate-assertions-in-util-tests branch March 22, 2021 07:03
Fabcien pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Feb 21, 2022
Summary:
Co-authored-by: Kiminuo <kiminuo@protonmail.com>

This is a backport of [[bitcoin/bitcoin#21491 | core#21491]]
Depends on D11078 and D11081

Test Plan: `ninja check`

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Subscribers: Fabien

Differential Revision: https://reviews.bitcoinabc.org/D11082
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants