test: Cleanup in test-{security,symbol}-check.py #21428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The removed get_machine function is no longer used since bitcoin#21255.
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
🕵️ @fanquake has been requested to review this pull request as specified in the REVIEWERS file. |
fanquake
approved these changes
Mar 18, 2021
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Mar 18, 2021
0fc0c00 test: Drop unused get_machine function (Hennadii Stepanov) 61a0f8f test: Cleanup test files in test-{security,symbol}-check.py (Hennadii Stepanov) Pull request description: 1) Test source and executable files are neither ignored by `.gitignore` nor removed by `make clean` and `make distclean`. 2) The `get_machine` function is no longer used since bitcoin#21255. ACKs for top commit: fanquake: ACK 0fc0c00 Tree-SHA512: ef3fcf22d4a04b6e4f37f748bd4be57e09696d2a77982e26292843cb2a1297789c8325f5c4bdad37d8094fce7765c4cc9ab19809e07471487943361b2b1a252c
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test source and executable files are neither ignored by
.gitignorenor removed bymake cleanandmake distclean.The
get_machinefunction is no longer used since contrib: run test-symbol-check for RISC-V #21255.