Skip to content

Conversation

fanquake
Copy link
Member

Now that we are using Focal for gitian building (glibc 2.31), we can use a newer introduced symbol, and include RISC-V in this test.

@fanquake fanquake requested a review from laanwj February 21, 2021 10:49
@laanwj laanwj added the Tests label Feb 21, 2021
@laanwj
Copy link
Member

laanwj commented Feb 21, 2021

Code review ACK 1211a90
Code review re-ACK ccb7b6a
If this passes on RISC-V and all other platforms, it can be merged.

Now that we are using Focal for Gitian building (glibc 2.31), we can
user a newer introduced  symbol, and include RISCV in this test.
@fanquake fanquake force-pushed the riscv_test_symbol_check branch from 1211a90 to ccb7b6a Compare February 22, 2021 00:35
@fanquake
Copy link
Member Author

I had to add a change to move the security check tests from a CI using Bionic, to one using Focal. This is also being done as a part of #21135.

@fanquake
Copy link
Member Author

Linux gitian builds at ccb7b6a:

Generating report
414b7b6bd1abf7fda227aeb8e65382c0bba5ec4e0ddda064677d7b86ecbc96cc  bitcoin-ccb7b6a97652-aarch64-linux-gnu-debug.tar.gz
e2a229f6b973fa6691e967330330b4e6a43560dfd69bbf23c2b8793bc8454033  bitcoin-ccb7b6a97652-aarch64-linux-gnu.tar.gz
21db0c98fbe262ae0233a4ac79f87f02c4ea271db24f381cdfccd4f3c101e56b  bitcoin-ccb7b6a97652-arm-linux-gnueabihf-debug.tar.gz
5e3949af1fd7c853d65dc22d7473b5abd12c1c10261c454f56bb9a1972b1ff7a  bitcoin-ccb7b6a97652-arm-linux-gnueabihf.tar.gz
eb8c318cd57ae1ad8cbd509101799cb32fa6ad49b10c66d461fd8265a7ed2b8b  bitcoin-ccb7b6a97652-powerpc64-linux-gnu-debug.tar.gz
2ec50b2c7188e3009f11c2c78ab77d33bac03735eebe8ac87e4af060e77f7c8a  bitcoin-ccb7b6a97652-powerpc64-linux-gnu.tar.gz
cc998e88efdbf94c489e2ef8ef6c7c118005a8f1b7cf28db2e17824361b6fcaf  bitcoin-ccb7b6a97652-powerpc64le-linux-gnu-debug.tar.gz
25ed164efdcfc4f81954ba39264f71cc62b9a44e628f05458d6e3c8ec246288b  bitcoin-ccb7b6a97652-powerpc64le-linux-gnu.tar.gz
e2bb2aee23ee1a5d4f9ae6f8ede8ace915a583a45a2b21fc9aa6a176b590cabb  bitcoin-ccb7b6a97652-riscv64-linux-gnu-debug.tar.gz
1efe0fb31af22850dccecb70597ce46c16cbe5e740b39c72c015a3a5f17283b8  bitcoin-ccb7b6a97652-riscv64-linux-gnu.tar.gz
da1473854096bb61696362bf2d8f1f8f1db96286624cbed724f9ee46a9a45f15  bitcoin-ccb7b6a97652-x86_64-linux-gnu-debug.tar.gz
485f0351307418242cee4d3299d0b0bc245f591bcd10008c7098d3a06d7c814b  bitcoin-ccb7b6a97652-x86_64-linux-gnu.tar.gz
ef9a38853dee9017a9fd0dc83c67f180250f9c9c39f69ea325e5ffbd5f561d93  src/bitcoin-ccb7b6a97652.tar.gz
c4fb9d7512f40995ea39a9e35c66292c2603f162b69f51e6918d6895027a1001  bitcoin-core-linux-22-res.yml
Done.

@fanquake
Copy link
Member Author

Linux Guix builds at ccb7b6a:

bash-5.1# find output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
efe8c167f5a153dcefb1aab2a4edae8a56187fa588318d96c4958876ec157935  output/bitcoin-ccb7b6a97652-aarch64-linux-gnu-debug.tar.gz
1dc1c3a174d4e027d597cdac64c0de64ded472280b7524b8ae5417660ee0038a  output/bitcoin-ccb7b6a97652-aarch64-linux-gnu.tar.gz
114335ee7daa54e7b4192b4fe54a698ec2fb53dfb76471ae49a43bac85b3d2b7  output/bitcoin-ccb7b6a97652-arm-linux-gnueabihf-debug.tar.gz
e103199663d2b0c0ff0b1307e36ed682d15039008ab001c241650eec98652e6a  output/bitcoin-ccb7b6a97652-arm-linux-gnueabihf.tar.gz
67d814c48a555fd4972221ef94bf53c3e955bfa28361c569a9bf79c9542b51eb  output/bitcoin-ccb7b6a97652-riscv64-linux-gnu-debug.tar.gz
fd9a4b150a4b397ce4940c715acc6b0a2d265e2c475de744f1ad905f904164b6  output/bitcoin-ccb7b6a97652-riscv64-linux-gnu.tar.gz
461f0b8f4a20b6423e64805aac61e89a4ae906433f3c43a8223a442b521d4989  output/bitcoin-ccb7b6a97652-x86_64-linux-gnu-debug.tar.gz
b01c9f5dc3fcfd489d595d81d64e0b200321bfa4314b140674808acb54ee48b7  output/bitcoin-ccb7b6a97652-x86_64-linux-gnu.tar.gz
ef9a38853dee9017a9fd0dc83c67f180250f9c9c39f69ea325e5ffbd5f561d93  output/src/bitcoin-ccb7b6a97652.tar.gz

@laanwj
Copy link
Member

laanwj commented Feb 22, 2021

Gititan build successful:

414b7b6bd1abf7fda227aeb8e65382c0bba5ec4e0ddda064677d7b86ecbc96cc  bitcoin-ccb7b6a97652-aarch64-linux-gnu-debug.tar.gz
e2a229f6b973fa6691e967330330b4e6a43560dfd69bbf23c2b8793bc8454033  bitcoin-ccb7b6a97652-aarch64-linux-gnu.tar.gz
21db0c98fbe262ae0233a4ac79f87f02c4ea271db24f381cdfccd4f3c101e56b  bitcoin-ccb7b6a97652-arm-linux-gnueabihf-debug.tar.gz
5e3949af1fd7c853d65dc22d7473b5abd12c1c10261c454f56bb9a1972b1ff7a  bitcoin-ccb7b6a97652-arm-linux-gnueabihf.tar.gz
eb8c318cd57ae1ad8cbd509101799cb32fa6ad49b10c66d461fd8265a7ed2b8b  bitcoin-ccb7b6a97652-powerpc64-linux-gnu-debug.tar.gz
2ec50b2c7188e3009f11c2c78ab77d33bac03735eebe8ac87e4af060e77f7c8a  bitcoin-ccb7b6a97652-powerpc64-linux-gnu.tar.gz
cc998e88efdbf94c489e2ef8ef6c7c118005a8f1b7cf28db2e17824361b6fcaf  bitcoin-ccb7b6a97652-powerpc64le-linux-gnu-debug.tar.gz
25ed164efdcfc4f81954ba39264f71cc62b9a44e628f05458d6e3c8ec246288b  bitcoin-ccb7b6a97652-powerpc64le-linux-gnu.tar.gz
e2bb2aee23ee1a5d4f9ae6f8ede8ace915a583a45a2b21fc9aa6a176b590cabb  bitcoin-ccb7b6a97652-riscv64-linux-gnu-debug.tar.gz
1efe0fb31af22850dccecb70597ce46c16cbe5e740b39c72c015a3a5f17283b8  bitcoin-ccb7b6a97652-riscv64-linux-gnu.tar.gz
da1473854096bb61696362bf2d8f1f8f1db96286624cbed724f9ee46a9a45f15  bitcoin-ccb7b6a97652-x86_64-linux-gnu-debug.tar.gz
485f0351307418242cee4d3299d0b0bc245f591bcd10008c7098d3a06d7c814b  bitcoin-ccb7b6a97652-x86_64-linux-gnu.tar.gz
ef9a38853dee9017a9fd0dc83c67f180250f9c9c39f69ea325e5ffbd5f561d93  src/bitcoin-ccb7b6a97652.tar.gz
594fc8c760b27c868f51630c2f8b689f4cf54ed831a7c033ce70a4af595ef844  bitcoin-core-linux-22-res.yml

@laanwj laanwj merged commit 84af293 into bitcoin:master Feb 22, 2021
@DrahtBot
Copy link
Contributor

Gitian builds

File commit 5bb64ac
(master)
commit 9fcf0b5
(master and this pull)
*-aarch64-linux-gnu-debug.tar.gz cf297442634eade2... 1520d5c8af72028f...
*-aarch64-linux-gnu.tar.gz 9c69c56c20b58c13... a2d310712c6a2537...
*-arm-linux-gnueabihf-debug.tar.gz 9d7f728c37975806... c542e81a726f04a2...
*-arm-linux-gnueabihf.tar.gz 6693b7e60ec203be... 46b37671f4f1b4d2...
*-osx-unsigned.dmg 44da1ed85e3731b1... 0bc1fb11c0642875...
*-osx64.tar.gz be774327ca566a92... b497cbdea5164b11...
*-powerpc64-linux-gnu-debug.tar.gz 3370278a5c6c7c1e... 07689e788ffe87ec...
*-powerpc64-linux-gnu.tar.gz 056afe8a29c678fb... 1283c6bb6bd0e74f...
*-powerpc64le-linux-gnu-debug.tar.gz 88daeebaef532240... d6d12b257381ad41...
*-powerpc64le-linux-gnu.tar.gz 1e4a09759535007f... edceeec176571322...
*-riscv64-linux-gnu-debug.tar.gz 12a4d4b77c6e3541... 0ecf81d67ad6d36e...
*-riscv64-linux-gnu.tar.gz 1d971d417af20715... 138b6e3e6177d7c8...
*-win64-debug.zip 90c33bf9fddbfbe1... 5504d2940e3cff3a...
*-win64-setup-unsigned.exe a6f068af77143a90... c7f1ca9d2abf3b26...
*-win64.zip ef8e326a01053278... ac635d3ce673ac24...
*-x86_64-linux-gnu-debug.tar.gz b8df4eb15a0e918c... e2b48147a4698082...
*-x86_64-linux-gnu.tar.gz 0ca0dc58d6389221... 0d9650ff8ff5b992...
*.tar.gz f5e8c8ac599ad686... 388134c90080a652...
bitcoin-core-linux-22-res.yml e6f5894ca651c0a0... 5c033cf7168ddbd3...
bitcoin-core-osx-22-res.yml 2fca43f09b77e43b... d98e43d9a295f4a9...
bitcoin-core-win-22-res.yml 2800f22b84fa7229... dff8075e7f7c34d1...
linux-build.log a40ad8a11ccb8431... 86122b261b857eae...
osx-build.log 526c3a6c02014062... a2132118000908d1...
win-build.log 449e7e5b359b1c10... 64aaafccaef374bc...
bitcoin-core-linux-22-res.yml.diff 1e12a622715c1ed8...
bitcoin-core-osx-22-res.yml.diff f5a45bc200d6dbf2...
bitcoin-core-win-22-res.yml.diff 8c0383489f4acf67...
linux-build.log.diff a84460165f58f5a2...
osx-build.log.diff c50cb2dd043870e0...
win-build.log.diff 77509a4355fab28e...

sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Feb 22, 2021
@fanquake fanquake deleted the riscv_test_symbol_check branch February 23, 2021 02:37
hebasto added a commit to hebasto/bitcoin that referenced this pull request Mar 13, 2021
The removed get_machine function is no longer used since bitcoin#21255.
fanquake added a commit that referenced this pull request Mar 18, 2021
0fc0c00 test: Drop unused get_machine function (Hennadii Stepanov)
61a0f8f test: Cleanup test files in test-{security,symbol}-check.py (Hennadii Stepanov)

Pull request description:

  1) Test source and executable files are neither ignored by `.gitignore` nor removed by `make clean` and `make distclean`.

  2) The `get_machine` function is no longer used since #21255.

ACKs for top commit:
  fanquake:
    ACK 0fc0c00

Tree-SHA512: ef3fcf22d4a04b6e4f37f748bd4be57e09696d2a77982e26292843cb2a1297789c8325f5c4bdad37d8094fce7765c4cc9ab19809e07471487943361b2b1a252c
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Mar 18, 2021
0fc0c00 test: Drop unused get_machine function (Hennadii Stepanov)
61a0f8f test: Cleanup test files in test-{security,symbol}-check.py (Hennadii Stepanov)

Pull request description:

  1) Test source and executable files are neither ignored by `.gitignore` nor removed by `make clean` and `make distclean`.

  2) The `get_machine` function is no longer used since bitcoin#21255.

ACKs for top commit:
  fanquake:
    ACK 0fc0c00

Tree-SHA512: ef3fcf22d4a04b6e4f37f748bd4be57e09696d2a77982e26292843cb2a1297789c8325f5c4bdad37d8094fce7765c4cc9ab19809e07471487943361b2b1a252c
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants