Skip to content

Conversation

edilmedeiros
Copy link
Contributor

The developer mailing list was migrated to Google Groups in February 2024 as announced in https://groups.google.com/g/bitcoindev/c/aewBuV6k-LI.

In this patch, I decided to add a link to the archives maintained by the Linux Foundation as linked in the old mailing list page.

A reasonable alternative would be link to the new archives linked in the migration announcement message. I'm not sure about the status of the archive migration, probably the old archives are more comprehensive to this date.

@DrahtBot
Copy link
Contributor

DrahtBot commented Apr 1, 2024

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK Zero-1729, josibake, Sjors

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

@DrahtBot DrahtBot added the Docs label Apr 1, 2024
@edilmedeiros
Copy link
Contributor Author

edilmedeiros commented Apr 1, 2024

The old mailing list address is also mentioned in

[bitcoin-dev](https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev).

Would be a good idea to address that as well?

All other references to the old Linux Foundation mailing list in the code base link to specific threads in the archives and all links are active to this date.

Copy link
Member

@josibake josibake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK, thanks for updating this!

In this patch, I decided to add a link to the archives maintained by the Linux Foundation as linked in the old mailing list page.

I'm not sure about this. I don't think there is any expectation this archive will be maintained.

All other references to the old Linux Foundation mailing list in the code base link to specific threads in the archives and all links are active to this date.

I think it would be better to switch all links over to the new archive. AFAIK, the archive migration is complete and matches the old archive, so I don't see any issues with switching all the links over. As a sanity check, we can spot check the URLs as part of review.

@kanzure
Copy link
Contributor

kanzure commented Apr 2, 2024

I'm not sure about the status of the archive migration, probably the old archives are more comprehensive to this date. [...] AFAIK, the archive migration is complete and matches the old archive, so I don't see any issues with switching all the links over.

The archive migration to https://gnusha.org/pi/bitcoindev was completed, and it is a complete record at this time, including new messages to the new mailing list.

the layout is not very pretty

Well.... pull requests welcome. This is a public-inbox instance. See https://public-inbox.org/ for more information. Also, mirrors of this archive would also be very much welcome. Give it a spiffy url that people will remember, and then it won't be a single point of failure. It's just git, so git clone it.

All other references to the old Linux Foundation mailing list in the code base link to specific threads in the archives and all links are active to this date. [...] I don't think there is any expectation this archive will be maintained.

The old linuxfoundation archive and urls I am told will continue to host the old emails. It will not have any of the new emails of course.

They are redirected indefinitely.

I haven't heard about this?

(and I don't think Google itself should be recommended as the canonical archive)

Agree.

@Sjors
Copy link
Member

Sjors commented Apr 2, 2024

They are redirected indefinitely.

I haven't heard about this?

I meant to say for the foreseeable future. Or did they announce a deadline for these?

Update: not redirect, but a static page.

@edilmedeiros
Copy link
Contributor Author

@josibake Given the other comments, probably the consensus approach is

  1. to update all mentions of the mailing list to the new link (CONTRIBUTING.md and dnsseed-policy.md),
  2. CONTRIBUTING.md refers to the new archive since this file is the entry point for newcomers,
  3. keep all other mentions of specific emails and threads as they are (as kanzure was told they will still be available in the long term).

I agree with Sjors to keep the old specific links as they are, that's why I opened them all before submitting the PR to ensure they are still active.

@edilmedeiros
Copy link
Contributor Author

For the record, these are the mentions of the linux foundation links:

❯ ripgrep linuxfoundation
src/validation.cpp
962:        // this, see https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2018-November/016518.html
3960:        // https://lists.linuxfoundation.org/pipermail/bitcoin-dev/attachments/20190225/a27d8837/attachment-0001.pdf).
4383:        // https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2019-February/016697.html.  Because CheckBlock() is

src/crypto/muhash.h
88: * https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2017-May/014337.html.

doc/policy/mempool-limits.md
42:post](https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2018-November/016518.html).

test/functional/test_framework/crypto/muhash.py
21:    See https://cseweb.ucsd.edu/~mihir/papers/inchash.pdf and https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2017-May/014337.html

doc/dnsseed-policy.md
47:[bitcoin-dev](https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev).

CONTRIBUTING.md
69:[mailing list](https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev)

@josibake
Copy link
Member

josibake commented Apr 2, 2024

@josibake Given the other comments, probably the consensus approach is

1. to update all mentions of the mailing list to the new link (CONTRIBUTING.md and dnsseed-policy.md),

2. CONTRIBUTING.md refers to the new archive since this file is the entry point for newcomers,

3. keep all other mentions of specific emails and threads as they are (as kanzure was told they will still be available in the long term).

I agree with Sjors to keep the old specific links as they are, that's why I opened them all before submitting the PR to ensure they are still active.

Sounds good to me! I have a slight preference for changing the old links to the new archive since the only thing we are certain of is that the new archive will be maintained going into the future by people closer to the project. But the approach you've laid out seems fine and we can always change the old links if/when they become a problem.

edilmedeiros added a commit to edilmedeiros/bitcoin that referenced this pull request Apr 2, 2024
The developer mailing list was migrated to Google Groups in February 2024
as announced in https://groups.google.com/g/bitcoindev/c/aewBuV6k-LI.

The archives maintained by the Linux Foundation stopped updating in December
2024. Thus, we point to the new archive maintained by gnusha.org.

The database refers to old discussions linked to the Linux Foundation archives.
Since all links are still active to this date, we keep them as they are.

See bitcoin#29782.
Copy link
Member

@josibake josibake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 754d42d

Excellent commit message 👍

@edilmedeiros
Copy link
Contributor Author

edilmedeiros commented Apr 2, 2024

For future reference, in case we decide to update the archive links cited in other places of the codebase, here is the mapping:

src/validation.cpp

original: https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2018-November/016518.html
update: https://gnusha.org/pi/bitcoindev/c3f68b73-84c6-7428-4bf6-b47802141392@mattcorallo.com/

original: https://lists.linuxfoundation.org/pipermail/bitcoin-dev/attachments/20190225/a27d8837/attachment-0001.pdf
update: https://gnusha.org/pi/bitcoindev/CAFp6fsGtEm9p-ZQF_XqfqyQGzZK7BS2SNp2z680QBsJiFDraEA@mail.gmail.com/2-BitcoinMerkle.pdf

original: https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2019-February/016697.html
update: https://gnusha.org/pi/bitcoindev/CAFp6fsGtEm9p-ZQF_XqfqyQGzZK7BS2SNp2z680QBsJiFDraEA@mail.gmail.com/

—

src/crypto/muhash.h

original: https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2017-May/014337.html
update: https://gnusha.org/pi/bitcoindev/CAPg+sBgruEiXya6oFy6VpmR1KPDebjeGDtZZU+facZx5=L_a5w@mail.gmail.com/

—

doc/policy/mempool-limits.md

original: https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2018-November/016518.html
update: https://gnusha.org/pi/bitcoindev/c3f68b73-84c6-7428-4bf6-b47802141392@mattcorallo.com/

—

test/functional/test_framework/crypto/muhash.py

original: https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2017-May/014337.html
update: https://gnusha.org/pi/bitcoindev/CAPg+sBgruEiXya6oFy6VpmR1KPDebjeGDtZZU+facZx5=L_a5w@mail.gmail.com/

The developer mailing list was migrated to Google Groups in February 2024
as announced in https://groups.google.com/g/bitcoindev/c/aewBuV6k-LI.

The archives maintained by the Linux Foundation stopped updating in December
2024. Thus, we point to the new archive maintained by gnusha.org.

The codebase refers to old discussions linked to the Linux Foundation archives.
Since all links are still active to this date, we keep them as they are.

See bitcoin#29782.
@edilmedeiros
Copy link
Contributor Author

edilmedeiros commented Apr 2, 2024

ACK 754d42d

Excellent commit message 👍

Thanks, but there was a typo (database instead of codebase). Amended to correct it, sorry for that.

Copy link
Contributor

@Zero-1729 Zero-1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crACK 0ead466

LGTM

@DrahtBot DrahtBot requested a review from josibake April 2, 2024 19:12
@josibake
Copy link
Member

josibake commented Apr 2, 2024

reACK 0ead466

@edilmedeiros edilmedeiros requested a review from Sjors April 3, 2024 01:54
@Sjors
Copy link
Member

Sjors commented Apr 3, 2024

ACK 0ead466

@fanquake fanquake merged commit 4373525 into bitcoin:master Apr 3, 2024
fanquake pushed a commit to fanquake/bitcoin that referenced this pull request Apr 3, 2024
The developer mailing list was migrated to Google Groups in February 2024
as announced in https://groups.google.com/g/bitcoindev/c/aewBuV6k-LI.

The archives maintained by the Linux Foundation stopped updating in December
2024. Thus, we point to the new archive maintained by gnusha.org.

The codebase refers to old discussions linked to the Linux Foundation archives.
Since all links are still active to this date, we keep them as they are.

See bitcoin#29782.

Github-Pull: bitcoin#29782
Rebased-From: 0ead466
fanquake pushed a commit to fanquake/bitcoin that referenced this pull request Apr 4, 2024
The developer mailing list was migrated to Google Groups in February 2024
as announced in https://groups.google.com/g/bitcoindev/c/aewBuV6k-LI.

The archives maintained by the Linux Foundation stopped updating in December
2024. Thus, we point to the new archive maintained by gnusha.org.

The codebase refers to old discussions linked to the Linux Foundation archives.
Since all links are still active to this date, we keep them as they are.

See bitcoin#29782.

Github-Pull: bitcoin#29782
Rebased-From: 0ead466
fanquake added a commit that referenced this pull request Apr 15, 2024
910e3e8 doc: update manual pages for v27.0 (fanquake)
2d2a0a3 build: bump version to v27.0 final (fanquake)
9442ea8 doc: import release notes from devwiki (fanquake)
fe51ace Update the developer mailing list address. (Edil Medeiros)
bde54b7 ci: Print tsan errors to stderr (MarcoFalke)
753c68d ci: Pull in qtbase5-dev instead of seperate low-level libraries (laanwj)
c4da61b doc: Suggest installing dev packages for debian/ubuntu qt5 build (laanwj)

Pull request description:

  Currently backports:
  * #29740
  * #29764
  * #29782

  Pulls release notes:  https://github.com/bitcoin-core/bitcoin-devwiki/wiki/27.0-Release-Notes-Draft.
  Finalizes `v27.0`.

ACKs for top commit:
  achow101:
    ACK 910e3e8
  stickies-v:
    ACK 910e3e8 - no changes except addressing nits

Tree-SHA512: 5dd8c6adaab154699f8ad9a5bda26de54901d3d1d09034a5a6775a37f12b44274d2d5ce6e1a527a6c211b56a75fe154f3ccb37bcbc39882be8299a4f127bfe30
@kanzure
Copy link
Contributor

kanzure commented Nov 6, 2024

For future reference, in case we decide to update the archive links cited in other places of the codebase, here is the mapping:

Unfortunately, lists.linuxfoundation.org is no longer hosting any mailing list archives, not just for bitcoin-dev but all the other mailing lists too.

Are there any particular preferences on doing that proposed replace-all update now that lists.linuxfoundation.org has pulled the content?

I see a few options here:

  1. Wait and see if they put it back up.

  2. Update those locations in the source code to the proposed new urls like https://gnusha.org/pi/bitcoindev/c3f68b73-84c6-7428-4bf6-b47802141392@mattcorallo.com/ with the Message-ID in the url.

  3. Use https://gnusha.org/url/https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2019-February/016697.html style urls to help others fight web/bit rot for similar links on the web.

See https://gnusha.org/url for more information about how that works. I made it so that it works as a simple prefix in front of the old format urls.

@edilmedeiros
Copy link
Contributor Author

Opened #31240 so that we can discuss the best approach to fix this.
I'll check if there are other broken links around.

kanzure added a commit to kanzure/bitcoinops.github.io that referenced this pull request Nov 7, 2024
Unfortunately, lists.linuxfoundation.org is no longer hosting the
bitcoin-dev and lightning-dev static email archives, nor any others for
that matter.

gnusha.org/url is a web service that redirects old style archive urls to
a new location where the content can be viewed.

"img/posts/taproot-workshop/taproot-workshop.pdf" is not updated.

For more information see:
bitcoin/bitcoin#29782 (comment)
bitcoin/bitcoin#31240
bitcointranscripts/bitcointranscripts#566
https://x.com/kanzure/status/1853779672514826334
https://gnusha.org/url/
edilmedeiros added a commit to edilmedeiros/bitcoin that referenced this pull request Nov 7, 2024
The developer mailing list was migrated to Google Groups in February 2024 as
announced in https://groups.google.com/g/bitcoindev/c/aewBuV6k-LI. The archives
maintained by the Linux Foundation stopped updating in December 2023. See
bitcoin#29782.

The codebase refers to old discussions linked to the Linux Foundation archives.
Unfortunately, as of November 2024, lists.linuxfoundation.org is no longer
hosting any mailing list archives, not just for bitcoin-dev but all the other
mailing lists too.

Change all the links to `gnusha.org` archives.

See bitcoin#31240.
kanzure added a commit to kanzure/bips that referenced this pull request Nov 9, 2024
Unfortunately, lists.linuxfoundation.org is no longer hosting the
bitcoin-dev mailing list static archives nor any other mailing list
static archives.

gnusha.org/url is a web service that redirects old style archive urls to
a new location where the content can be viewed.

For more information see:
https://gnusha.org/url/
https://x.com/kanzure/status/1853779672514826334
bitcoin/bitcoin#29782 (comment)
bitcoin/bitcoin#31240
bitcoinops/bitcoinops.github.io#2018
bitschmidty pushed a commit to bitcoinops/bitcoinops.github.io that referenced this pull request Nov 11, 2024
* update lists.linuxfoundation.org urls to gnusha.org/url

Unfortunately, lists.linuxfoundation.org is no longer hosting the
bitcoin-dev and lightning-dev static email archives, nor any others for
that matter.

gnusha.org/url is a web service that redirects old style archive urls to
a new location where the content can be viewed.

"img/posts/taproot-workshop/taproot-workshop.pdf" is not updated.

For more information see:
bitcoin/bitcoin#29782 (comment)
bitcoin/bitcoin#31240
bitcointranscripts/bitcointranscripts#566
https://x.com/kanzure/status/1853779672514826334
https://gnusha.org/url/

* update lists.linuxfoundation.org attachment urls

A few lists.linuxfoundation.org urls were linking over to an attachment
file, which is not supported by the gnusha.org/url service at this time.

Instead, these links have been replaced by a link to the attachment in
the public-inbox archive on gnusha.org/pi/bitcoindev.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants