Skip to content

Conversation

fanquake
Copy link
Member

@fanquake fanquake commented Apr 1, 2024

laanwj added 2 commits April 1, 2024 16:02
Pretty much all library packages were renamed in the 64-bit time_t
migration to add `t64` (even on 64-bit platforms).

Instead of complicating the doc with conditional package names, suggest
installing the `-dev` packages which still have the same name, and
besides that, are the right way to go about it as they contain the
"user facing" C++ headers needed to build against Qt5.

For Fedora, devel packages are already suggested.

This affects Ubuntu 24.04 and Debian Testing.

Github-Pull: bitcoin#29764
Rebased-From: a3c6a13
Fix CI build for t64 migration.

Github-Pull: bitcoin#29764
Rebased-From: 6c29904
@fanquake fanquake added this to the 27.0 milestone Apr 1, 2024
@DrahtBot
Copy link
Contributor

DrahtBot commented Apr 1, 2024

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK stickies-v, achow101

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

The developer mailing list was migrated to Google Groups in February 2024
as announced in https://groups.google.com/g/bitcoindev/c/aewBuV6k-LI.

The archives maintained by the Linux Foundation stopped updating in December
2024. Thus, we point to the new archive maintained by gnusha.org.

The codebase refers to old discussions linked to the Linux Foundation archives.
Since all links are still active to this date, we keep them as they are.

See bitcoin#29782.

Github-Pull: bitcoin#29782
Rebased-From: 0ead466
@fanquake fanquake force-pushed the finalize_or_rc2_27 branch from 2e59a96 to fe51ace Compare April 4, 2024 13:39
@DrahtBot DrahtBot removed the CI failed label Apr 5, 2024
@fanquake fanquake force-pushed the finalize_or_rc2_27 branch from dcfcd39 to fe51ace Compare April 9, 2024 07:37
@fanquake fanquake marked this pull request as ready for review April 9, 2024 08:06
@fanquake fanquake requested a review from stickies-v April 9, 2024 08:07
@fanquake fanquake changed the title [27.x] More backports (and maybe finalize) [27.x] More backports and finalize Apr 9, 2024
@darosior
Copy link
Member

Reminder it's probably worth backporting #29853 to avoid hitting it in the fuzzer.

Copy link

@vostrnad vostrnad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the release notes. A few style nits/suggestions, one entry is missing its PR number.

@bitcoin bitcoin deleted a comment Apr 14, 2024
Copy link
Contributor

@stickies-v stickies-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 4681f55 with a few release note nits

  • backports mostly clean, 753c68d being the exception because of LLVM version bump
  • release notes look good and correspond with devwiki, quickly went through merges since v26.0 and couldn't see any major omissions
  • i'm getting the same manpages output

@fanquake fanquake force-pushed the finalize_or_rc2_27 branch from 4681f55 to 910e3e8 Compare April 15, 2024 08:49
@fanquake
Copy link
Member Author

@vostrnad @stickies-v thanks, combined suggestions.

Copy link
Contributor

@stickies-v stickies-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 910e3e8 - no changes except addressing nits

@achow101
Copy link
Member

ACK 910e3e8

@fanquake fanquake merged commit d822839 into bitcoin:27.x Apr 15, 2024
@fanquake fanquake deleted the finalize_or_rc2_27 branch April 15, 2024 16:28
@bitcoin bitcoin locked and limited conversation to collaborators Apr 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants