[25.x] Parallel compact block downloads #27752
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
This was referenced May 25, 2023
|
utACK 50c86f5 I got a bit confused because this PR builds on slightly older 25.x commit. |
50c86f5 to
929af14
Compare
Github-Pull: bitcoin#27626 Rebased-From: 86cff8b
Github-Pull: bitcoin#27626 Rebased-From: a905954
Github-Pull: bitcoin#27626 Rebased-From: cce9618
…ight This is a change in behavior so that if for some reason we request a block from a peer, we don't allow an unsolicited CMPCT_BLOCK announcement for that same block to cause a request for a full block from the uninvited peer (as some type of request is already outstanding from the original peer) Github-Pull: bitcoin#27626 Rebased-From: 13f9b20
A single outbound slot is required, so if the first two slots are taken by inbound in-flights, the node will reject additional unless they are coming from outbound. This means in the case where a fast sybil peer is attempting to stall out a node, a single high bandwidth outbound peer can mitigate the attack. Github-Pull: bitcoin#27626 Rebased-From: 03423f8
Github-Pull: bitcoin#27626 Rebased-From: d7f359b
Github-Pull: bitcoin#27743 Rebased-From: d972695
929af14 to
b8ad322
Compare
|
utACK b8ad322 |
|
ACK b8ad322 ; confirmed patches are clean cherry-picks from master, and already tested patches prior to 25.0 release |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports: