p2p: Unconditionally return when compact block status == READ_STATUS_FAILED #27743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
utACK d972695 |
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
fanquake
pushed a commit
to fanquake/bitcoin
that referenced
this pull request
May 25, 2023
Github-Pull: bitcoin#27743 Rebased-From: d972695
|
Backported in #27752. |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
May 26, 2023
…tatus == READ_STATUS_FAILED d972695 Unconditionally return when compact block status == READ_STATUS_FAILED (Greg Sanders) Pull request description: Fixes bitcoin#27626 (comment) which would have resulted in wasted bandwidth every once in a while. ACKs for top commit: Sjors: utACK d972695 mzumsande: ACK d972695 Tree-SHA512: 2483cae03093fc61b36279bbc455829822258703ae608ff2797a20449410b12bfe8d40de63c02fc79ed4ef4d91b34c63281b71b81a1c691cab9647b65761586f
Sjors
pushed a commit
to Sjors/bitcoin
that referenced
this pull request
May 27, 2023
Github-Pull: bitcoin#27743 Rebased-From: d972695
fanquake
pushed a commit
to fanquake/bitcoin
that referenced
this pull request
Jun 2, 2023
Github-Pull: bitcoin#27743 Rebased-From: d972695
fanquake
pushed a commit
to fanquake/bitcoin
that referenced
this pull request
Jun 16, 2023
Github-Pull: bitcoin#27743 Rebased-From: d972695
fanquake
added a commit
that referenced
this pull request
Jul 4, 2023
b8ad322 Unconditionally return when compact block status == READ_STATUS_FAILED (Greg Sanders) cdd3de0 Add tests for parallel compact block downloads (Greg Sanders) e66a5cb Support up to 3 parallel compact block txn fetchings (Greg Sanders) d1a93f5 Only request full blocks from the peer we thought had the block in-flight (Greg Sanders) 38e3af9 Convert mapBlocksInFlight to a multimap (Greg Sanders) a45159b Remove nBlocksInFlight (Greg Sanders) 722361e alias BlockDownloadMap for mapBlocksInFlight (Greg Sanders) Pull request description: Backports: * #27626 * #27743 ACKs for top commit: instagibbs: utACK b8ad322 ajtowns: ACK b8ad322 ; confirmed patches are clean cherry-picks from master, and already tested patches prior to 25.0 release Tree-SHA512: 438901496a5ed927662e62f936e3d1e7ffb727cb235869854983e8e29a68e144eb3bff307d9fc3ae785fb276b67a216b1cce397689252ca49c5d761efc1380ac
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27626 (comment) which would have resulted in wasted bandwidth every once in a while.