ci: Run iwyu on all src files #27571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced May 4, 2023
|
Is this dependant on #27573 |
|
Yes, I can't figure out how to fight |
|
Concept ACK on removing the continual manual updating of this list |
fa1adc7 to
fade263
Compare
Looks like it's mostly working, except GUI stuff is still being dragged in |
And |
fa09249 to
fa08bbf
Compare
|
Concept ACK. I've been adding sources files to this list while working on each pull. |
This makes it easier to look at the CI output of a file without having to manually add it first.
|
Should be ready for review |
hebasto
reviewed
May 16, 2023
| # accepted in src/.bear-tidy-config | ||
| # Filter out: | ||
| # * qt qrc and moc generated files | ||
| # * walletutil (temporarily) |
There was a problem hiding this comment.
Mind elaborating about skipping walletutil?
There was a problem hiding this comment.
because it crashes. See:
# python3 "/include-what-you-use/iwyu_tool.py" -p . ./src/wallet/walletutil.cpp -j 9 -- -Xiwyu --cxx17ns -Xiwyu --mapping_file="$PWD/contrib/devtools/iwyu/bitcoin.core.imp"
In file included from wallet/walletutil.cpp:5:
In file included from ./wallet/walletutil.h:8:
In file included from ./script/descriptor.h:8:
In file included from ./outputtype.h:9:
In file included from ./script/signingprovider.h:10:
In file included from ./key.h:10:
In file included from ./pubkey.h:10:
In file included from ./hash.h:10:
In file included from ./crypto/common.h:12:
In file included from /usr/lib64/clang/16/include/stdint.h:52:
In file included from /usr/include/stdint.h:26:
In file included from /usr/include/bits/libc-header-start.h:33:
/usr/include/features.h:413:4: warning: _FORTIFY_SOURCE requires compiling with optimization (-O) [-W#warnings]
# warning _FORTIFY_SOURCE requires compiling with optimization (-O)
^
In file included from wallet/walletutil.cpp:5:
In file included from ./wallet/walletutil.h:8:
In file included from ./script/descriptor.h:8:
In file included from ./outputtype.h:9:
In file included from ./script/signingprovider.h:10:
In file included from ./key.h:10:
In file included from ./pubkey.h:10:
In file included from ./hash.h:14:
In file included from ./serialize.h:17:
In file included from /usr/lib/gcc/x86_64-redhat-linux/13/../../../../include/c++/13/memory:78:
/usr/lib/gcc/x86_64-redhat-linux/13/../../../../include/c++/13/bits/unique_ptr.h:97:16: error: invalid application of 'sizeof' to an incomplete type 'wallet::DescriptorScriptPubKeyMan'
static_assert(sizeof(_Tp)>0,
^~~~~~~~~~~
/usr/lib/gcc/x86_64-redhat-linux/13/../../../../include/c++/13/bits/unique_ptr.h:404:4: note: in instantiation of member function 'std::default_delete<wallet::DescriptorScriptPubKeyMan>::operator()' requested here
get_deleter()(std::move(__ptr));
^
/usr/lib/gcc/x86_64-redhat-linux/13/../../../../include/c++/13/bits/stl_construct.h:151:19: note: in instantiation of member function 'std::unique_ptr<wallet::DescriptorScriptPubKeyMan>::~unique_ptr' requested here
__pointer->~_Tp();
^
/usr/lib/gcc/x86_64-redhat-linux/13/../../../../include/c++/13/bits/stl_construct.h:196:2: note: in instantiation of function template specialization 'std::_Destroy_aux<false>::__destroy<std::unique_ptr<wallet::DescriptorScriptPubKeyMan> *>' requested here
__destroy(__first, __last);
^
/usr/lib/gcc/x86_64-redhat-linux/13/../../../../include/c++/13/bits/alloc_traits.h:947:7: note: in instantiation of function template specialization 'std::_Destroy<std::unique_ptr<wallet::DescriptorScriptPubKeyMan> *>' requested here
_Destroy(__first, __last);
^
/usr/lib/gcc/x86_64-redhat-linux/13/../../../../include/c++/13/bits/stl_vector.h:732:7: note: in instantiation of function template specialization 'std::_Destroy<std::unique_ptr<wallet::DescriptorScriptPubKeyMan> *, std::unique_ptr<wallet::DescriptorScriptPubKeyMan>>' requested here
std::_Destroy(this->_M_impl._M_start, this->_M_impl._M_finish,
^
./wallet/walletutil.h:122:8: note: in instantiation of member function 'std::vector<std::unique_ptr<wallet::DescriptorScriptPubKeyMan>>::~vector' requested here
struct MigrationData
^
./wallet/walletutil.h:119:7: note: forward declaration of 'wallet::DescriptorScriptPubKeyMan'
class DescriptorScriptPubKeyMan;
^
hebasto
approved these changes
May 16, 2023
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
May 17, 2023
fanquake
added a commit
to bitcoin-core/gui
that referenced
this pull request
May 29, 2023
1f97572 Fix `#include`s in `src/wallet` (Hennadii Stepanov) Pull request description: This PR is a minimum required changes to fix bitcoin/bitcoin#27571 (comment). ACKs for top commit: MarcoFalke: lgtm ACK 1f97572 Tree-SHA512: de885210076d23f3394c42ca50e6ae2470c0ae6523399a2fa3ebb7c06383bdacef9c26166fa19747200396bed796c8772165e24416eb30ed8edd024e3394b2fe
DashCoreAutoGuix
pushed a commit
to DashCoreAutoGuix/dash
that referenced
this pull request
Jul 26, 2025
1f97572 Fix `#include`s in `src/wallet` (Hennadii Stepanov) Pull request description: This PR is a minimum required changes to fix bitcoin#27571 (comment). ACKs for top commit: MarcoFalke: lgtm ACK 1f97572 Tree-SHA512: de885210076d23f3394c42ca50e6ae2470c0ae6523399a2fa3ebb7c06383bdacef9c26166fa19747200396bed796c8772165e24416eb30ed8edd024e3394b2fe
DashCoreAutoGuix
pushed a commit
to DashCoreAutoGuix/dash
that referenced
this pull request
Jul 26, 2025
1f97572 Fix `#include`s in `src/wallet` (Hennadii Stepanov) Pull request description: This PR is a minimum required changes to fix bitcoin#27571 (comment). ACKs for top commit: MarcoFalke: lgtm ACK 1f97572 Tree-SHA512: de885210076d23f3394c42ca50e6ae2470c0ae6523399a2fa3ebb7c06383bdacef9c26166fa19747200396bed796c8772165e24416eb30ed8edd024e3394b2fe
DashCoreAutoGuix
pushed a commit
to DashCoreAutoGuix/dash
that referenced
this pull request
Aug 1, 2025
1f97572 Fix `#include`s in `src/wallet` (Hennadii Stepanov) Pull request description: This PR is a minimum required changes to fix bitcoin#27571 (comment). ACKs for top commit: MarcoFalke: lgtm ACK 1f97572 Tree-SHA512: de885210076d23f3394c42ca50e6ae2470c0ae6523399a2fa3ebb7c06383bdacef9c26166fa19747200396bed796c8772165e24416eb30ed8edd024e3394b2fe
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to look at the CI output of a file without having to manually add it first to the list.