Skip to content

Fix #includes in src/wallet #27759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2023
Merged

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented May 25, 2023

This PR is a minimum required changes to fix #27571 (comment).

@DrahtBot
Copy link
Contributor

DrahtBot commented May 25, 2023

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK MarcoFalke

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #25797 (build: Add CMake-based build system by hebasto)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@DrahtBot DrahtBot mentioned this pull request May 25, 2023
16 tasks
@fanquake fanquake requested a review from maflcko May 29, 2023 12:28
@maflcko
Copy link
Member

maflcko commented May 29, 2023

lgtm ACK 1f97572

@DrahtBot DrahtBot removed the request for review from maflcko May 29, 2023 14:22
@fanquake fanquake merged commit dfe6580 into bitcoin:master May 29, 2023
@hebasto hebasto deleted the 230525-walletutil branch May 29, 2023 15:40
@maflcko
Copy link
Member

maflcko commented May 29, 2023

May be good to report the crash upstream if you can reduce the reproducer

sidhujag pushed a commit to syscoin/syscoin that referenced this pull request May 29, 2023
@bitcoin bitcoin locked and limited conversation to collaborators May 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants