depends: qrencode 4.1.1 #27312
depends: qrencode 4.1.1 #27312
Conversation
Upgrade to the latest qrencode, and disable some warnings that cause compile failures with newer compilers (clang-15+). Fixes part of bitcoin#27299.
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
|
Concept ACK.
Yeah, this situation is a real concern, unfortunately. |
There was a problem hiding this comment.
Code review ACK eb1c3ad
I checked that the additional cflags indeed suppress errors when building with clang-15. Also went though the changed configure flags and did a quick sanity check in the gui.
|
There is this library which is maintained and available in multiple programming languages (C and C++ are two of them): https://github.com/nayuki/QR-Code-generator |
I can take a look and attempt migrating to it, unless you e want to work on it yourself, @prusnak |
Feel free to explore that area. |
eb1c3ad depends: qrencode 4.1.1 (fanquake) Pull request description: Upgrade to the latest qrencode, and disable some warnings that cause compile failures with newer compilers (clang-15+). I haven't tested this (from a GUI perspective) at all. This is just "good enough" to keep things compiling, and uses some similar work-arounds as we have with other older packages, i.e bdb. Note that upstream, libqrencode is effectively unmaintained. No code changes for > 2 years. No responses to issues/PRs. Seems like the author has mostly dropped off of GitHub as well. This fixes part of bitcoin#27299. ACKs for top commit: TheCharlatan: Code review ACK eb1c3ad Tree-SHA512: 898eaac3e9915dfcdc0a011b736fff685a3b46990bd27f6038ef4d3e7cb6a276206438ea50d45908a051ce55c9b0779347d4be1d35271b67f76f409a7dc21fed
…used in depenendencies.md a12d9cf doc: correct sqlite & qrencode versions used in depenendencies.md (fanquake) Pull request description: Followup to bitcoin/bitcoin#27312 & bitcoin/bitcoin#25378. ACKs for top commit: achow101: ACK a12d9cf hebasto: ACK a12d9cf, I have reviewed the code and it looks OK, I agree it can be merged. jarolrod: ACK a12d9cf Tree-SHA512: 29e1fe4c31089fce6acbadb14aa7619fdd55738a882b490f1a0835d7648798a68b4f0d62e213c60d92f8e021ea856a4d1759578da07413265fef2338840da506
…depenendencies.md a12d9cf doc: correct sqlite & qrencode versions used in depenendencies.md (fanquake) Pull request description: Followup to bitcoin#27312 & bitcoin#25378. ACKs for top commit: achow101: ACK a12d9cf hebasto: ACK a12d9cf, I have reviewed the code and it looks OK, I agree it can be merged. jarolrod: ACK a12d9cf Tree-SHA512: 29e1fe4c31089fce6acbadb14aa7619fdd55738a882b490f1a0835d7648798a68b4f0d62e213c60d92f8e021ea856a4d1759578da07413265fef2338840da506
Upgrade to the latest qrencode, and disable some warnings that cause compile failures with newer compilers (clang-15+).
I haven't tested this (from a GUI perspective) at all. This is just "good enough" to keep things compiling, and uses some similar work-arounds as we have with other older packages, i.e bdb.
Note that upstream, libqrencode is effectively unmaintained. No code changes for > 2 years. No responses to issues/PRs. Seems like the author has mostly dropped off of GitHub as well.
This fixes part of #27299.