build: use sqlite 3380500 in depends #25378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Concept ACK. |
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsNo conflicts as of last run. |
Guix builds on
|
Guix builds on
|
|
GUIX hashes on arm64, mine match @hebasto and @fanquake: |
|
CVE-2021-45346 doesn't affect us, right? |
I would say, no. |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jun 20, 2022
9d6a7b2 build: sqlite 3380500 in depends (fanquake) Pull request description: Move to using [sqlite 3380500](https://www.sqlite.org/releaselog/3_38_5.html) in depends. Other than bug fixes and improvements compared to our current version (3320100), the newer version contains changes that deal with warnings produced with newer versions of GCC (11.2.0), which are also more likely to appear when building with LTO: ```bash ../depends/work/build/x86_64-pc-linux-gnu/sqlite/3320100-973d921a018/sqlite3.c: In function 'sqlite3SelectNew': ../depends/work/build/x86_64-pc-linux-gnu/sqlite/3320100-973d921a018/sqlite3.c:129016: warning: function may return address of local variable [-Wreturn-local-addr] ../depends/work/build/x86_64-pc-linux-gnu/sqlite/3320100-973d921a018/sqlite3.c:128976: note: declared here In function 'memcpy', inlined from 'sqlite3Fts5IndexQuery' at ../depends/work/build/x86_64-pc-linux-gnu/sqlite/3320100-973d921a018/sqlite3.c:220862:18: /usr/include/x86_64-linux-gnu/bits/string_fortified.h:29:10: warning: '__builtin_memcpy' specified bound 18446744073709551615 exceeds maximum object size 9223372036854775807 [-Wstringop-overflow=] 29 | return __builtin___memcpy_chk (__dest, __src, __len, | ^ ``` Relevant upstream discussions: https://sqlite.org/forum/forumpost/845dd0be91a54ec8 https://sqlite.org/forum/forumpost/f5eed70bd46ede56 Guix Build (x86_64): ```bash 5a2bb2a0c09ade10bc78af0eae910e842402598c28cd82dfe67fa7f0bdc7c7d0 guix-build-9d6a7b2fb1e0/output/aarch64-linux-gnu/SHA256SUMS.part e7e82c3ab4654c33389ffda83647723179f548b6d0372204914a94df1479f29c guix-build-9d6a7b2fb1e0/output/aarch64-linux-gnu/bitcoin-9d6a7b2fb1e0-aarch64-linux-gnu-debug.tar.gz 3574852251d08749193a05161a048ae7933aee8910da230a3c32fa874d4df027 guix-build-9d6a7b2fb1e0/output/aarch64-linux-gnu/bitcoin-9d6a7b2fb1e0-aarch64-linux-gnu.tar.gz a9d87e7197998051ff4d76253c5c8d86e859c3907d1f29023a62d40b5ca8f82f guix-build-9d6a7b2fb1e0/output/arm-linux-gnueabihf/SHA256SUMS.part a0813408afb86f505f1ffd6f9361881c08b35b1a7cd869da7e1dad9f042a63ae guix-build-9d6a7b2fb1e0/output/arm-linux-gnueabihf/bitcoin-9d6a7b2fb1e0-arm-linux-gnueabihf-debug.tar.gz e3d13d137c3bde9a25bf585ecdfe9001bc10b8c82b206d8fbf4977f3ab5da374 guix-build-9d6a7b2fb1e0/output/arm-linux-gnueabihf/bitcoin-9d6a7b2fb1e0-arm-linux-gnueabihf.tar.gz a84a8f5c152048e1a3287afe42f4909d2ea9a271b2474d7406a83482fb1de3c7 guix-build-9d6a7b2fb1e0/output/arm64-apple-darwin/SHA256SUMS.part 4241ed6de223e899995d4df3ba8566e472e08a125cd1ecd5e1fdab5bc88bb6fd guix-build-9d6a7b2fb1e0/output/arm64-apple-darwin/bitcoin-9d6a7b2fb1e0-arm64-apple-darwin-unsigned.dmg 75e5096ccab23b546393a368d9beb9b2b0867bb0d0c84604ff2a131f4afb24fa guix-build-9d6a7b2fb1e0/output/arm64-apple-darwin/bitcoin-9d6a7b2fb1e0-arm64-apple-darwin-unsigned.tar.gz ec453221fbd951b0fddfad283a310a550aa15b55aefe6ba6a0f290cfff1d2cb2 guix-build-9d6a7b2fb1e0/output/arm64-apple-darwin/bitcoin-9d6a7b2fb1e0-arm64-apple-darwin.tar.gz e01c2894eec3827c98241f5cf9c779b07cb4dee8e9e043a6840c8fcf6a91a23c guix-build-9d6a7b2fb1e0/output/dist-archive/bitcoin-9d6a7b2fb1e0.tar.gz c926dcf8c351548c845e4c6c047a851cb99a72b028005c6c6b0e3e4f1d7384f7 guix-build-9d6a7b2fb1e0/output/powerpc64-linux-gnu/SHA256SUMS.part a6dea61ce6397ba4d5b3c35fae2c7b729cee23e07b71b5de6737663dd144d234 guix-build-9d6a7b2fb1e0/output/powerpc64-linux-gnu/bitcoin-9d6a7b2fb1e0-powerpc64-linux-gnu-debug.tar.gz 77d6271322db5bb5ea25f20c5df5fc5a0150cfd1570a8e1a5d0c111702eca77c guix-build-9d6a7b2fb1e0/output/powerpc64-linux-gnu/bitcoin-9d6a7b2fb1e0-powerpc64-linux-gnu.tar.gz 57793bf2ea341012806d6dafb49659b40496eaeee3fe1da580e7c7aed07572ba guix-build-9d6a7b2fb1e0/output/powerpc64le-linux-gnu/SHA256SUMS.part 6a37d39313150ad90101b1e29ac7a7a32f3001cb9395326484b117c5538b27a3 guix-build-9d6a7b2fb1e0/output/powerpc64le-linux-gnu/bitcoin-9d6a7b2fb1e0-powerpc64le-linux-gnu-debug.tar.gz 985ceb6eeba7590bef83755b73f1efdef922d50c5ebee7e0c521b27388874482 guix-build-9d6a7b2fb1e0/output/powerpc64le-linux-gnu/bitcoin-9d6a7b2fb1e0-powerpc64le-linux-gnu.tar.gz 21a30c6f53d4544376ebc5f9fa3326edb305bf1dd55079512b7eaf16c408fcfc guix-build-9d6a7b2fb1e0/output/riscv64-linux-gnu/SHA256SUMS.part c80d159154a4785dcaf42f77175aad38dd9498e8e0128f2c6277b4a2668f8aae guix-build-9d6a7b2fb1e0/output/riscv64-linux-gnu/bitcoin-9d6a7b2fb1e0-riscv64-linux-gnu-debug.tar.gz d2ed0cde0f6e0245662e8f335091dbe0ed57dcb661ff1d5eac94f5af7cde4daf guix-build-9d6a7b2fb1e0/output/riscv64-linux-gnu/bitcoin-9d6a7b2fb1e0-riscv64-linux-gnu.tar.gz d054f0bf16e69ad7b557faed4b5c349bdfba3ff554a2d3636ad913ac307dc2e9 guix-build-9d6a7b2fb1e0/output/x86_64-apple-darwin/SHA256SUMS.part a7279c357838b0aa1d3548b45be8568d759b141828e3b7d2ab2d2de9a95b7a8c guix-build-9d6a7b2fb1e0/output/x86_64-apple-darwin/bitcoin-9d6a7b2fb1e0-x86_64-apple-darwin-unsigned.dmg efe4d4d9e4d7e966e19dcc819456169d02891087fa7e767c305afd297e981af2 guix-build-9d6a7b2fb1e0/output/x86_64-apple-darwin/bitcoin-9d6a7b2fb1e0-x86_64-apple-darwin-unsigned.tar.gz e1b72c3904a6cb3ba0c9eb156288ab216a94be5da2b10288d414d224ffa525b1 guix-build-9d6a7b2fb1e0/output/x86_64-apple-darwin/bitcoin-9d6a7b2fb1e0-x86_64-apple-darwin.tar.gz 80e5b6ffce2bf33bc024ee1decd0d024fe2f23211dbe73cf1ade89abcf5910d9 guix-build-9d6a7b2fb1e0/output/x86_64-linux-gnu/SHA256SUMS.part 9903f76bfce98415c6d6d1cc2057683b4fad9d02f4da0c2afe37b108a4d8d496 guix-build-9d6a7b2fb1e0/output/x86_64-linux-gnu/bitcoin-9d6a7b2fb1e0-x86_64-linux-gnu-debug.tar.gz 9a05903423afef05222e13646c3b249c747b8cb9d487eceb1a120ca018b02dea guix-build-9d6a7b2fb1e0/output/x86_64-linux-gnu/bitcoin-9d6a7b2fb1e0-x86_64-linux-gnu.tar.gz bbb8e284b9dced4db64c6fbb7ac53ddcc622b9c367300b280beaae2e288140b9 guix-build-9d6a7b2fb1e0/output/x86_64-w64-mingw32/SHA256SUMS.part b7064f1abbf8653e5c045c84244db112cef48043610a30fc878ba644e01b41ae guix-build-9d6a7b2fb1e0/output/x86_64-w64-mingw32/bitcoin-9d6a7b2fb1e0-win64-debug.zip be1a9b270d834d59a731adebed1d4f2424fb6a1bb082808fadb5cf3b930a31a1 guix-build-9d6a7b2fb1e0/output/x86_64-w64-mingw32/bitcoin-9d6a7b2fb1e0-win64-setup-unsigned.exe b893e54fb43b5c256d46e4a58d65a8d3fc111eb65417cb56810f793b1813ca86 guix-build-9d6a7b2fb1e0/output/x86_64-w64-mingw32/bitcoin-9d6a7b2fb1e0-win64-unsigned.tar.gz 603eb61bcf37ad0939cc588c79c544be545d443043bc194094d203eaab7981d2 guix-build-9d6a7b2fb1e0/output/x86_64-w64-mingw32/bitcoin-9d6a7b2fb1e0-win64.zip ``` Guix Build (arm64): ```bash e4bd8215fb9ff88c58b7d1b2d13f90110585e3a7de7be20a962b4b00b5817012 guix-build-9d6a7b2fb1e0/output/arm-linux-gnueabihf/SHA256SUMS.part e03b9d5201b68087c267875a570e675a838753cc4062105bc3820b594dfbddc1 guix-build-9d6a7b2fb1e0/output/arm-linux-gnueabihf/bitcoin-9d6a7b2fb1e0-arm-linux-gnueabihf-debug.tar.gz 7bb1d6c34910fcd8036adcf1c92ddff330242ad92ecd489864b7a44386e6afec guix-build-9d6a7b2fb1e0/output/arm-linux-gnueabihf/bitcoin-9d6a7b2fb1e0-arm-linux-gnueabihf.tar.gz 2e8dd34a1ff1ee041a7c2eb423ee84bdf00be28d71b2ffeb20752f10d10b856b guix-build-9d6a7b2fb1e0/output/arm64-apple-darwin/SHA256SUMS.part b448114fdb7be57070d7bc563cfc8a3ef7b6658689598e8c1091c359f62a2445 guix-build-9d6a7b2fb1e0/output/arm64-apple-darwin/bitcoin-9d6a7b2fb1e0-arm64-apple-darwin-unsigned.dmg ea9d06d6208d3279c11eb2845fc6c1cbee4293ca0169e1ac3a6cec737f022230 guix-build-9d6a7b2fb1e0/output/arm64-apple-darwin/bitcoin-9d6a7b2fb1e0-arm64-apple-darwin-unsigned.tar.gz 0a267860eb0414ac2a213b9c6accd24cc73da3474d535c85ec7d542aa08fda30 guix-build-9d6a7b2fb1e0/output/arm64-apple-darwin/bitcoin-9d6a7b2fb1e0-arm64-apple-darwin.tar.gz e01c2894eec3827c98241f5cf9c779b07cb4dee8e9e043a6840c8fcf6a91a23c guix-build-9d6a7b2fb1e0/output/dist-archive/bitcoin-9d6a7b2fb1e0.tar.gz 8b3a0634a29579352a50b596ff79b58442d53951e6fe7ca291362d697d8bff26 guix-build-9d6a7b2fb1e0/output/powerpc64-linux-gnu/SHA256SUMS.part 2acc3541cf7d09eb0302605b8131aae4561918969bee2a397ef550412afecd86 guix-build-9d6a7b2fb1e0/output/powerpc64-linux-gnu/bitcoin-9d6a7b2fb1e0-powerpc64-linux-gnu-debug.tar.gz eec1781a5daf7e98213299c6aac37d111528f03bd5fa595371e4984491137e0b guix-build-9d6a7b2fb1e0/output/powerpc64-linux-gnu/bitcoin-9d6a7b2fb1e0-powerpc64-linux-gnu.tar.gz b8d4b83f8194d77bbc09e1cbda9406365655865959bcb200eca76d5db630a0e3 guix-build-9d6a7b2fb1e0/output/powerpc64le-linux-gnu/SHA256SUMS.part 05502d75b749465cc2deedcafdb34a910a14c75d3c0b25964899ef102dec8da3 guix-build-9d6a7b2fb1e0/output/powerpc64le-linux-gnu/bitcoin-9d6a7b2fb1e0-powerpc64le-linux-gnu-debug.tar.gz 7c66573cc96f62a75549a5333d2b5c27fde78691f3fe8d863bb676a0a1052a0b guix-build-9d6a7b2fb1e0/output/powerpc64le-linux-gnu/bitcoin-9d6a7b2fb1e0-powerpc64le-linux-gnu.tar.gz fac4613cf7d47f2f22a45c0030c480802dae805f46f59a596a98f4fd709209fd guix-build-9d6a7b2fb1e0/output/riscv64-linux-gnu/SHA256SUMS.part df3d1045cb10d815f5b3bba5246c3349654346a156982c767e2c3b076598185b guix-build-9d6a7b2fb1e0/output/riscv64-linux-gnu/bitcoin-9d6a7b2fb1e0-riscv64-linux-gnu-debug.tar.gz 64ec31b702d3c6c25615618be64de631c70f69383e150f27493139933591f024 guix-build-9d6a7b2fb1e0/output/riscv64-linux-gnu/bitcoin-9d6a7b2fb1e0-riscv64-linux-gnu.tar.gz d054f0bf16e69ad7b557faed4b5c349bdfba3ff554a2d3636ad913ac307dc2e9 guix-build-9d6a7b2fb1e0/output/x86_64-apple-darwin/SHA256SUMS.part a7279c357838b0aa1d3548b45be8568d759b141828e3b7d2ab2d2de9a95b7a8c guix-build-9d6a7b2fb1e0/output/x86_64-apple-darwin/bitcoin-9d6a7b2fb1e0-x86_64-apple-darwin-unsigned.dmg efe4d4d9e4d7e966e19dcc819456169d02891087fa7e767c305afd297e981af2 guix-build-9d6a7b2fb1e0/output/x86_64-apple-darwin/bitcoin-9d6a7b2fb1e0-x86_64-apple-darwin-unsigned.tar.gz e1b72c3904a6cb3ba0c9eb156288ab216a94be5da2b10288d414d224ffa525b1 guix-build-9d6a7b2fb1e0/output/x86_64-apple-darwin/bitcoin-9d6a7b2fb1e0-x86_64-apple-darwin.tar.gz 05fa5c84dce57bb1728a8ac36a967177f25d9f8892b272da0483e4b8f4ea2b94 guix-build-9d6a7b2fb1e0/output/x86_64-linux-gnu/SHA256SUMS.part 40cb0712447dc4e1f0574fcd307012206ce64c32aa12a240666070a18cf6af51 guix-build-9d6a7b2fb1e0/output/x86_64-linux-gnu/bitcoin-9d6a7b2fb1e0-x86_64-linux-gnu-debug.tar.gz 7f6b0696f28348584eb62d69ab936f864310dd42a7e4cba7abe087e563b3b77f guix-build-9d6a7b2fb1e0/output/x86_64-linux-gnu/bitcoin-9d6a7b2fb1e0-x86_64-linux-gnu.tar.gz d79bab5b5d4414d23cf26eaddb3c5eabc88e0700e9fd62686e5b44735c62453b guix-build-9d6a7b2fb1e0/output/x86_64-w64-mingw32/SHA256SUMS.part 55029375d671803013ba49c8f287101c49f62033569240efe9f089907dc47a58 guix-build-9d6a7b2fb1e0/output/x86_64-w64-mingw32/bitcoin-9d6a7b2fb1e0-win64-debug.zip be1a9b270d834d59a731adebed1d4f2424fb6a1bb082808fadb5cf3b930a31a1 guix-build-9d6a7b2fb1e0/output/x86_64-w64-mingw32/bitcoin-9d6a7b2fb1e0-win64-setup-unsigned.exe b893e54fb43b5c256d46e4a58d65a8d3fc111eb65417cb56810f793b1813ca86 guix-build-9d6a7b2fb1e0/output/x86_64-w64-mingw32/bitcoin-9d6a7b2fb1e0-win64-unsigned.tar.gz 9626a24a47af1a1d5240a50c3d7fd74053657bc87a5dff32007b200f48e5573d guix-build-9d6a7b2fb1e0/output/x86_64-w64-mingw32/bitcoin-9d6a7b2fb1e0-win64.zip ``` ACKs for top commit: hebasto: ACK 9d6a7b2. Confirming that `-Wreturn-local-addr` and `-Wstringop-overflow=` warnings are gone. Verified the hash of the new source archive. Tree-SHA512: 28783479623be0ccc8169ff63e169a61f850106e820f12917b867b07087d2817fe0d5432a5e1ddf564ed90ba371aaf801dd4e7b32acb3907736dc4dcdd129355
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Nov 3, 2022
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Dec 5, 2022
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jan 13, 2023
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jan 21, 2023
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jan 21, 2023
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jan 21, 2023
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jan 21, 2023
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jan 21, 2023
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jan 21, 2023
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jan 31, 2023
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Feb 1, 2023
PastaPastaPasta
pushed a commit
to kwvg/dash
that referenced
this pull request
Feb 3, 2023
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Feb 3, 2023
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Feb 4, 2023
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Feb 4, 2023
PastaPastaPasta
pushed a commit
to kwvg/dash
that referenced
this pull request
Feb 7, 2023
PastaPastaPasta
added a commit
to dashpay/dash
that referenced
this pull request
Feb 7, 2023
achow101
added a commit
to bitcoin-core/gui
that referenced
this pull request
Apr 11, 2023
…used in depenendencies.md a12d9cf doc: correct sqlite & qrencode versions used in depenendencies.md (fanquake) Pull request description: Followup to bitcoin/bitcoin#27312 & bitcoin/bitcoin#25378. ACKs for top commit: achow101: ACK a12d9cf hebasto: ACK a12d9cf, I have reviewed the code and it looks OK, I agree it can be merged. jarolrod: ACK a12d9cf Tree-SHA512: 29e1fe4c31089fce6acbadb14aa7619fdd55738a882b490f1a0835d7648798a68b4f0d62e213c60d92f8e021ea856a4d1759578da07413265fef2338840da506
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Apr 11, 2023
…depenendencies.md a12d9cf doc: correct sqlite & qrencode versions used in depenendencies.md (fanquake) Pull request description: Followup to bitcoin#27312 & bitcoin#25378. ACKs for top commit: achow101: ACK a12d9cf hebasto: ACK a12d9cf, I have reviewed the code and it looks OK, I agree it can be merged. jarolrod: ACK a12d9cf Tree-SHA512: 29e1fe4c31089fce6acbadb14aa7619fdd55738a882b490f1a0835d7648798a68b4f0d62e213c60d92f8e021ea856a4d1759578da07413265fef2338840da506
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move to using sqlite 3380500 in depends.
Other than bug fixes and improvements compared to our current version (3320100), the newer version contains changes that deal with warnings produced with newer versions of GCC (11.2.0), which are also more likely to appear when building with LTO:
Relevant upstream discussions:
https://sqlite.org/forum/forumpost/845dd0be91a54ec8
https://sqlite.org/forum/forumpost/f5eed70bd46ede56
Guix Build (x86_64):
Guix Build (arm64):