Skip to content

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented Feb 9, 2023

#26977 made current git rev-list -1 HEAD ./depends not working.

This PR fixes this issue with an idea from #26977 (comment).

@DrahtBot
Copy link
Contributor

DrahtBot commented Feb 9, 2023

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK MarcoFalke

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

@maflcko
Copy link
Member

maflcko commented Feb 10, 2023

lgtm ACK d66efa3

@maflcko maflcko merged commit 4f841cb into bitcoin:master Feb 10, 2023
@hebasto hebasto deleted the 230209-ci-deps branch February 10, 2023 08:44
@real-or-random
Copy link
Contributor

Just checking if I get this right: git rev-parse HEAD:foo uses the contents of foo as fingerprint (instead of the revision in which it was touched last)?

@maflcko
Copy link
Member

maflcko commented Feb 10, 2023

Yeah, it is probably even more correct, as it doesn't commit to irrelevant stuff such as the commit message. So the fingerprint hash will be different, however, the important part is that the output should commit to the content of the depends system.

git log -1 ./depends, git rev-list -1 HEAD ./depends, git rev-parse HEAD:depends, and git ls-tree HEAD ./depends should all have this property.

@hebasto
Copy link
Member Author

hebasto commented Feb 10, 2023

Yeah, it is probably even more correct, as it doesn't commit to irrelevant stuff such as the commit message. So the fingerprint hash will be different, however, the important part is that the output should commit to the content of the depends system.

git log -1 ./depends, git rev-list -1 HEAD ./depends, git rev-parse HEAD:depends, and git ls-tree HEAD ./depends should all have this property.

A shallow repo, which is used in the CI, lacks details. Therefore, only git rev-parse HEAD:depends and git ls-tree HEAD ./depends are suitable as they return the same output for both deep and shallow repos.

sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Feb 10, 2023
@bitcoin bitcoin locked and limited conversation to collaborators Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants