Skip to content

Conversation

maflcko
Copy link
Member

@maflcko maflcko commented Jan 27, 2023

Should cut 20s from each build, with no downside?

This is possible since commit fad7281

@DrahtBot
Copy link
Contributor

DrahtBot commented Jan 27, 2023

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK real-or-random

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Copy link
Contributor

@real-or-random real-or-random left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK faa65f1

@fanquake fanquake merged commit 4b51290 into bitcoin:master Jan 27, 2023
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Jan 27, 2023
faa65f1 ci: Fetch no git history, unless lint (MarcoFalke)

Pull request description:

  Should cut 20s from each build, with no downside?

  This is possible since commit fad7281

ACKs for top commit:
  real-or-random:
    ACK faa65f1

Tree-SHA512: 1912d6a2c494de0ac2f69ac1dad568b7b2b9eb52e261d98e05f1184852281cd7fa9bc065ffe632b29ef204c3c7208034ef7b3b516aab3f3eba6b7a81db96ddee
@maflcko maflcko deleted the 2301-ci-no-hist-🏥 branch January 28, 2023 09:47
@hebasto
Copy link
Member

hebasto commented Feb 9, 2023

Apparently, this patch broke caching of depends subdirectories which use git rev-list -1 HEAD ./depends to detect whether a cache should be invalidated.

For example, https://api.cirrus-ci.com/v1/task/5585583192408064/logs/depends_built.log:

echo $CIRRUS_TASK_NAME $(git rev-list -1 HEAD ./depends)
32-bit + dash [gui] [CentOS 8] dc905f6c2a60961aee73578fd3092bf90b28409f

Cache miss for depends_built-8fd621cab3e906716ac5f0063b2bd29796bfe47bbc565c729e434be9c1c97a91! No script to populate with.

@maflcko
Copy link
Member Author

maflcko commented Feb 9, 2023

@hebasto
Copy link
Member

hebasto commented Feb 10, 2023

Should use git rev-parse HEAD:depends instead?

Thanks! Done in ##27070.

maflcko pushed a commit to bitcoin-core/gui that referenced this pull request Feb 10, 2023
…s` subdir caches

d66efa3 ci: Fix `fingerprint_script` for `depends` subdir caches (Hennadii Stepanov)

Pull request description:

  bitcoin/bitcoin#26977 made current `git rev-list -1 HEAD ./depends` [not working](bitcoin/bitcoin#26977 (comment)).

  This PR fixes this issue with an idea from bitcoin/bitcoin#26977 (comment).

ACKs for top commit:
  MarcoFalke:
    lgtm ACK d66efa3

Tree-SHA512: e6dbb1a80439bf8c044e50afc44b8b08b0903d20da5ef9dcbb265f2d64b6810ea5f4cb8abb44e00b96673082f1dbdd350627627d9d28f362bdb662c92ef257d8
@bitcoin bitcoin locked and limited conversation to collaborators Jan 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants