-
Notifications
You must be signed in to change notification settings - Fork 37.8k
ci: Fetch no git history, unless lint #26977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The head ref may contain hidden characters: "2301-ci-no-hist-\u{1F3E5}"
Conversation
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
1d38079
to
faed4a5
Compare
faed4a5
to
faa65f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK faa65f1
faa65f1 ci: Fetch no git history, unless lint (MarcoFalke) Pull request description: Should cut 20s from each build, with no downside? This is possible since commit fad7281 ACKs for top commit: real-or-random: ACK faa65f1 Tree-SHA512: 1912d6a2c494de0ac2f69ac1dad568b7b2b9eb52e261d98e05f1184852281cd7fa9bc065ffe632b29ef204c3c7208034ef7b3b516aab3f3eba6b7a81db96ddee
Apparently, this patch broke caching of For example, https://api.cirrus-ci.com/v1/task/5585583192408064/logs/depends_built.log:
|
Should use |
Thanks! Done in ##27070. |
…s` subdir caches d66efa3 ci: Fix `fingerprint_script` for `depends` subdir caches (Hennadii Stepanov) Pull request description: bitcoin/bitcoin#26977 made current `git rev-list -1 HEAD ./depends` [not working](bitcoin/bitcoin#26977 (comment)). This PR fixes this issue with an idea from bitcoin/bitcoin#26977 (comment). ACKs for top commit: MarcoFalke: lgtm ACK d66efa3 Tree-SHA512: e6dbb1a80439bf8c044e50afc44b8b08b0903d20da5ef9dcbb265f2d64b6810ea5f4cb8abb44e00b96673082f1dbdd350627627d9d28f362bdb662c92ef257d8
Should cut 20s from each build, with no downside?
This is possible since commit fad7281