refactor: add most of src/util to iwyu #25324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Concept ACK. |
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced Jun 9, 2022
Closed
This was referenced Jun 29, 2022
hebasto
reviewed
Jul 7, 2022
Comment on lines
+49
to
+61
| " src/util/bip32.cpp"\ | ||
| " src/util/bytevectorhash.cpp"\ | ||
| " src/util/error.cpp"\ | ||
| " src/util/getuniquepath.cpp"\ | ||
| " src/util/hasher.cpp"\ | ||
| " src/util/message.cpp"\ | ||
| " src/util/moneystr.cpp"\ | ||
| " src/util/serfloat.cpp"\ | ||
| " src/util/spanparsing.cpp"\ | ||
| " src/util/strencodings.cpp"\ | ||
| " src/util/syserror.cpp"\ | ||
| " src/util/url.cpp"\ |
There was a problem hiding this comment.
Actually, this PR affects more files, e.g., asmap.cpp, readwritefile.cpp etc. Should they be listed here as well?
There was a problem hiding this comment.
IWYU generates spurious output for some .cpp files, which would require adding headers that I'm not sure are correct, so I've excluded them for now.
These files change infrequently, and not much header shuffling is required. We don't add everything in src/util/ yet, because IWYU makes some dubious suggestions, which I'm going to follow up with upstream.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These files change infrequently, and not much header shuffling is required.
We don't add everything in src/util/ yet, because IWYU makes some
dubious suggestions, which I'm going to follow up with upstream.
Soon we'll swap
src/util/xyz.cppfor justsrc/util/.