Skip to content

util: Move error message formatting of NonFatalCheckError to cpp #25112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 16, 2022
Merged

util: Move error message formatting of NonFatalCheckError to cpp #25112

merged 1 commit into from
Nov 16, 2022

Conversation

maflcko
Copy link
Member

@maflcko maflcko commented May 12, 2022

This allows to strip down the header file.

@maflcko maflcko force-pushed the 2205-err-impl- branch 2 times, most recently from fa8bc3d to fa13e2f Compare May 12, 2022 10:54
@DrahtBot DrahtBot mentioned this pull request May 24, 2022
Closed
@DrahtBot
Copy link
Contributor

DrahtBot commented May 24, 2022 •
edited
Loading

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type Count Reviewers
ACK 2 aureleoules, hebasto
Concept ACK 1 laanwj

Conflicts

No conflicts as of last run.

This was referenced May 28, 2022
Merged
Merged
laanwj
laanwj reviewed May 30, 2022
View reviewed changes
@laanwj
Copy link
Member

laanwj commented May 30, 2022

Concept ACK

@DrahtBot DrahtBot mentioned this pull request May 31, 2022
Closed
@DrahtBot DrahtBot mentioned this pull request Jun 9, 2022
Merged
This was referenced Jul 1, 2022
Merged
Merged
@DrahtBot DrahtBot mentioned this pull request Oct 12, 2022
Merged
@maflcko maflcko force-pushed the 2205-err-impl- branch 2 times, most recently from fad0aa1 to fadbc71 Compare November 14, 2022 11:59
@maflcko maflcko mentioned this pull request Nov 16, 2022
Closed
@hebasto
Copy link
Member

hebasto commented Nov 16, 2022

Concept ACK.

hebasto
hebasto approved these changes Nov 16, 2022
View reviewed changes
Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK fadbc71, I have reviewed the code and it looks OK, I agree it can be merged.

util: Move error message formatting of NonFatalCheckError to cpp
2222ec7 
This allows to strip down the header file
hebasto
hebasto approved these changes Nov 16, 2022
View reviewed changes
Copy link
Member

@hebasto hebasto left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-ACK 2222ec7, only rebased and suggested changes since my recent review.

aureleoules
aureleoules approved these changes Nov 16, 2022
View reviewed changes
Copy link
Contributor

@aureleoules aureleoules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 2222ec7

@maflcko maflcko merged commit 6863ad7 into bitcoin:master Nov 16, 2022
@maflcko maflcko deleted the 2205-err-impl-🗡 branch November 16, 2022 14:19
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Nov 16, 2022
Merge bitcoin#25112: util: Move error message formatting of NonFatalC…
6031a31 
…heckErr…
@bitcoin bitcoin locked and limited conversation to collaborators Mar 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@laanwj laanwj laanwj left review comments

@ryanofsky ryanofsky ryanofsky left review comments

@hebasto hebasto hebasto approved these changes

+1 more reviewer

@aureleoules aureleoules aureleoules approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@maflcko @DrahtBot @laanwj @hebasto @ryanofsky @aureleoules