Skip to content

Conversation

fanquake
Copy link
Member

We no-longer support Clang 7 (#24164). Introduced in #20720.

This reverts commit e9189a7.

@laanwj
Copy link
Member

laanwj commented May 30, 2022

ACK 460854c makes sense to revert this workaround.

Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 460854c

We no-longer support Clang 7 (bitcoin#24164).

This reverts commit e9189a7.
@fanquake fanquake force-pushed the remove_clang_7_note branch from 460854c to a7973bf Compare May 31, 2022 05:41
Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-ACK a7973bf

@maflcko maflcko merged commit bd6c5e4 into bitcoin:master May 31, 2022
@fanquake fanquake deleted the remove_clang_7_note branch May 31, 2022 07:45
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request May 31, 2022
…ction support"

a7973bf Revert "build: more robustly check for fcf-protection support" (fanquake)

Pull request description:

  We no-longer support Clang 7 (bitcoin#24164). Introduced in bitcoin#20720.

  This reverts commit e9189a7.

ACKs for top commit:
  hebasto:
    re-ACK a7973bf

Tree-SHA512: 82559637f21a97434ab29f908ebda1aada08b0786cbbf0b4d11085241942314c3f04261a624c5cd2cb3c94c99046b56626830da6b9775981ab4ba10d5979f998
@bitcoin bitcoin locked and limited conversation to collaborators May 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants