Skip to content

test: Fix intermittent failure in feature_segwit #24578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2022
Merged

test: Fix intermittent failure in feature_segwit #24578

merged 1 commit into from
Mar 18, 2022

Conversation

maflcko
Copy link
Member

@maflcko maflcko commented Mar 16, 2022 •
edited
Loading

There are intermittent failures on current master (#24421 (comment)) as the witness txs occasionally make it into other node's mempools when they shouldn't.

Fix this by removing the test as suggested earlier in #24421 (comment).

Fixes #24590

@DrahtBot DrahtBot added the Tests label Mar 16, 2022
@maflcko maflcko mentioned this pull request Mar 16, 2022
Closed
@DrahtBot
Copy link
Contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #24535 (test: Fix generate calls and comments in feature_segwit by MarcoFalke)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@DrahtBot DrahtBot mentioned this pull request Mar 17, 2022
Merged
@aureleoules
Copy link
Contributor

tACK d6b24e1.
Tested on NixOS 22.05 64 bits.

I was able to reproduce the bug (#24421 (comment)) prior to this fix using: seq 100 | xargs -i -P 20 python test/functional/feature_segwit.py (100 tests in batches of 20).
Could not reproduce the bug after this PR using the same command with 1000 tests.

@maflcko maflcko mentioned this pull request Mar 17, 2022
Merged
@jnewbery
Copy link
Contributor

Code review ACK d6b24e1

Is there a way to introduce random sleeps into the test logic to flush out other racy test bugs?

@maflcko
Copy link
Member Author

maflcko commented Mar 18, 2022

Sure, it should be possible to inject a random sleep after sendrawtransaction. Though, I am not sure if this is going to give consistent results either. I think the only way would be to do the same for txs that was done for blocks. (Always sync unless opted out).

@maflcko maflcko merged commit 66e2d21 into bitcoin:master Mar 18, 2022
@maflcko maflcko deleted the 2203-testInt-💮 branch March 18, 2022 13:17
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Mar 18, 2022
Merge bitcoin#24578: test: Fix intermittent failure in feature_segwit
d6df2cc 
d6b24e1 test: Fix intermittent failure in feature_segwit (DrahtBot)

Pull request description:

  There are intermittent failures on current master (bitcoin#24421 (comment)) as the witness txs occasionally make it into other node's mempools when they shouldn't.

  Fix this by removing the test as suggested earlier in bitcoin#24421 (comment).

  Fixes bitcoin#24590

ACKs for top commit:
  aureleoules:
    tACK d6b24e1.
  jnewbery:
    Code review ACK d6b24e1

Tree-SHA512: ef7be52bdbde97b6921b44824e7fbc2dd92b77b8f076794867259f2b0bff08e0def06f4b2576f63a8ccb737a15cd8441fb7db20fa1f0d4fa9c7c76d5b83388ef
@glozow
Copy link
Member

glozow commented Mar 19, 2022

post merge ACK

@bitcoin bitcoin locked and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

qa: Intermittent failure in feature_segwit.py --descriptors
5 participants
@maflcko @DrahtBot @aureleoules @jnewbery @glozow