test: Fix generate calls and comments in feature_segwit #24535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsNo conflicts as of last run. |
|
tACK fa41268 ( Verified that the number of blocks mined is reduced and do not alter the tests. |
fa41268 to
fa8593f
Compare
theStack
approved these changes
Mar 19, 2022
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Mar 23, 2022
…_segwit fa8593f test: Fix generate calls and comments in feature_segwit (MarcoFalke) Pull request description: There are currently a few incorrect comments: Block `432` is mined "twice" (The second one is actually 433). There isn't any need to mine this many blocks anyway, so remove a few calls. ACKs for top commit: theStack: Tested ACK fa8593f Tree-SHA512: b034077b85e6c978a80aa4de493797b4ae451d686cfb3e4fe40f37a38f41f7cb886f8e00a1c245a284be3502164b17414097fcb0bef66d155a1c1db5cfbe9e8f
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are currently a few incorrect comments: Block
432is mined "twice" (The second one is actually 433).There isn't any need to mine this many blocks anyway, so remove a few calls.