Skip to content

ci: Bump CentOS 8 image #24212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 1, 2022
Merged

ci: Bump CentOS 8 image #24212

merged 3 commits into from
Feb 1, 2022

Conversation

maflcko
Copy link
Member

@maflcko maflcko commented Jan 31, 2022 •
edited
Loading

CentOS 8 was just shut down:

$ pob centos:8 
[root_e606059da4d9 /]# dnf update
Failed to set locale, defaulting to C.UTF-8
CentOS Linux 8 - AppStream
Error: Failed to download metadata for repo 'appstream': Cannot prepare internal mirrorlist: No URLs in mirrorlist

Fix that by bumping the image.

@hebasto
Copy link
Member

hebasto commented Jan 31, 2022

Concept ACK, considering:

  • CentOS Linux 8 EOL: 2021-12-31
  • CentOS Stream 8 EOL: 2024-05-31

@DrahtBot DrahtBot added the Tests label Jan 31, 2022
@fanquake
Copy link
Member 

  zeromq-4.3.4-2.el8.x86_64                                                     
Removed:
  coreutils-single-8.30-12.el8.x86_64                                           

Complete!
bash: free: command not found

Exit status: 127

@maflcko
Copy link
Member Author

maflcko commented Jan 31, 2022

Trying with procps-ng ...

@maflcko maflcko force-pushed the 2201-ciBC branch 2 times, most recently from fa96dfe to fa388b1 Compare January 31, 2022 10:55
@maflcko
Copy link
Member Author

maflcko commented Jan 31, 2022 

Building libevent...
make[1]: Entering directory '/tmp/cirrus-ci-build/depends/work/build/i686-pc-linux-gnu/libevent/2.1.12-stable-dbc4e9c2bf0'
make[1]: -c: Command not found
make[1]: *** [Makefile:1425: config.h] Error 127
make[1]: Leaving directory '/tmp/cirrus-ci-build/depends/work/build/i686-pc-linux-gnu/libevent/2.1.12-stable-dbc4e9c2bf0'
make: *** [funcs.mk:282: /tmp/cirrus-ci-build/depends/work/build/i686-pc-linux-gnu/libevent/2.1.12-stable-dbc4e9c2bf0/./.stamp_built] Error 2
make: Leaving directory '/tmp/cirrus-ci-build/depends'
Exit status: 2

@joshuacwnewton joshuacwnewton mentioned this pull request Jan 31, 2022
Closed
@hebasto
Copy link
Member

hebasto commented Jan 31, 2022

@MarcoFalke

libevent build can be fixed with the following patch:

--- a/ci/test/05_before_script.sh
+++ b/ci/test/05_before_script.sh
@@ -47,7 +47,7 @@ if [[ $HOST = *-mingw32 ]]; then
   DOCKER_EXEC update-alternatives --set "${HOST}-g++" \$\(which "${HOST}-g++-posix"\)
 fi
 if [ -z "$NO_DEPENDS" ]; then
-  if [[ $DOCKER_NAME_TAG == centos* ]]; then
+  if [[ $DOCKER_NAME_TAG == *centos* ]]; then
     # CentOS has problems building the depends if the config shell is not explicitly set
     # (i.e. for libevent a Makefile with an empty SHELL variable is generated, leading to
     #  an error as the first command is executed)

@hebasto hebasto mentioned this pull request Jan 31, 2022
Closed
MarcoFalke added 3 commits February 1, 2022 10:13
ci: Bump CentOS 8 image
fa5457e
scripted-diff: Rename DOCKER_EXEC to CI_EXEC
fa33236 
-BEGIN VERIFY SCRIPT-
 sed -i "s/DOCKER_EXEC/CI_EXEC/g" $(git grep -l DOCKER_EXEC)
-END VERIFY SCRIPT-
ci: Use dash when building depends in centos build
fafc55a
@Sjors
Copy link
Member

Sjors commented Feb 1, 2022

utACK fafc55a with the caveat that I've never used CentOS.

@maflcko
Copy link
Member Author

maflcko commented Feb 1, 2022

Just to give some more context:

  • Only the first commit is needed as a bug fix
  • The second commit is an unrelated rename. docker->ci, since it is possible to run the ci without docker
  • The third commit makes sense because we use the centos build to test with dash

@maflcko maflcko merged commit 133f73e into bitcoin:master Feb 1, 2022
@maflcko maflcko deleted the 2201-ciBC branch February 1, 2022 10:30
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Feb 1, 2022
Merge bitcoin#24212: ci: Bump CentOS 8 image
7f9f55a
This was referenced Feb 2, 2022
Merged
Merged
Merged
fanquake pushed a commit to fanquake/bitcoin that referenced this pull request Feb 4, 2022
@fanquake
ci: Bump CentOS 8 image
c9d0a52 
Github-Pull: bitcoin#24212
Rebased-From: fa5457e
fanquake pushed a commit to fanquake/bitcoin that referenced this pull request Feb 4, 2022
@fanquake
ci: Use dash when building depends in centos build
95f726f 
Github-Pull: bitcoin#24212
Rebased-From: fafc55a
@fanquake fanquake mentioned this pull request Feb 4, 2022
Merged
hebasto pushed a commit to hebasto/bitcoin that referenced this pull request Feb 6, 2022
@hebasto
ci: Bump CentOS 8 image
ed27691 
Github-Pull: bitcoin#24212
Rebased-From: fa5457e
hebasto pushed a commit to hebasto/bitcoin that referenced this pull request Feb 6, 2022
@hebasto
ci: Use dash when building depends in centos build
d25c9c7 
Github-Pull: bitcoin#24212
Rebased-From: fafc55a
fanquake pushed a commit to fanquake/bitcoin that referenced this pull request Feb 9, 2022
@fanquake
ci: Bump CentOS 8 image
201ed80 
Github-Pull: bitcoin#24212
Rebased-From: fa5457e
fanquake pushed a commit to fanquake/bitcoin that referenced this pull request Feb 9, 2022
@fanquake
ci: Use dash when building depends in centos build
40cc39a 
Github-Pull: bitcoin#24212
Rebased-From: fafc55a
fanquake pushed a commit to fanquake/bitcoin that referenced this pull request Feb 9, 2022
@fanquake
ci: Bump CentOS 8 image
c362722 
Github-Pull: bitcoin#24212
Rebased-From: fa5457e
fanquake pushed a commit to fanquake/bitcoin that referenced this pull request Feb 9, 2022
@fanquake
ci: Use dash when building depends in centos build
611a1d6 
Github-Pull: bitcoin#24212
Rebased-From: fafc55a
fanquake pushed a commit to fanquake/bitcoin that referenced this pull request Feb 14, 2022
@fanquake
ci: Bump CentOS 8 image
b1f3858 
Github-Pull: bitcoin#24212
Rebased-From: fa5457e
fanquake pushed a commit to fanquake/bitcoin that referenced this pull request Feb 14, 2022
@fanquake
ci: Use dash when building depends in centos build
37e8ea5 
Github-Pull: bitcoin#24212
Rebased-From: fafc55a
fanquake pushed a commit to fanquake/bitcoin that referenced this pull request Feb 14, 2022
@fanquake
ci: Bump CentOS 8 image
bba5856 
Github-Pull: bitcoin#24212
Rebased-From: fa5457e
fanquake pushed a commit to fanquake/bitcoin that referenced this pull request Feb 14, 2022
@fanquake
ci: Use dash when building depends in centos build
0075274 
Github-Pull: bitcoin#24212
Rebased-From: fafc55a
fanquake pushed a commit to fanquake/bitcoin that referenced this pull request Feb 14, 2022
@fanquake
ci: Bump CentOS 8 image
b5d12ed 
Github-Pull: bitcoin#24212
Rebased-From: fa5457e
fanquake pushed a commit to fanquake/bitcoin that referenced this pull request Feb 14, 2022
@fanquake
ci: Use dash when building depends in centos build
d34691c 
Github-Pull: bitcoin#24212
Rebased-From: fafc55a
@fanquake
Copy link
Member

Being backported in #24256.

fanquake added a commit that referenced this pull request Feb 15, 2022
@fanquake
Merge #24256: [22.x] build: Bump depends packages (zmq, libXau)
eff9709 
d34691c ci: Use dash when building depends in centos build (MarcoFalke)
b5d12ed ci: Bump CentOS 8 image (MarcoFalke)
685ac6a build: fix depends zeromq dash compatibility (fanquake)
4b92a6b build: libXau 1.0.9 (fanquake)

Pull request description:

  Backports #24212 to the 22.x branch. Included a bump to libXau and an additional commit for zeromq to fix dash compatibility.

ACKs for top commit:
  hebasto:
    ACK d34691c

Tree-SHA512: 862b819df6d74cfb0499d1f1040cfbf70dc4449108521466ff22db48b942949fec5c5e93d5f652109f228eac8e60413830f7c22b3879a0bd2441a60b87470972
@bitcoin bitcoin locked and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@maflcko @hebasto @fanquake @Sjors @DrahtBot