-
Notifications
You must be signed in to change notification settings - Fork 37.7k
[22.x] build: Bump depends packages (zmq, libXau) #24256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks like libXau 1.0.8 couldn't be built with |
This branch works: https://github.com/hebasto/bitcoin/commits/pr24256-22.x/fixed |
Github-Pull: bitcoin#23489 Rebased-From: fc65127
eafdee6
to
40cc39a
Compare
Changed title |
I would rather not backport a full zmq bump to a release branch. Should have resolved this be just picking the relevant commit from upstream: zeromq/libzmq@9a39766. Also rebased for #24215. |
An alternative would be to simply not support |
Concept ACK on supporting dash in CentOS. |
611a1d6
to
37e8ea5
Compare
37e8ea5
to
0075274
Compare
Picks upstream commit 9a397666d28ca5f3c0d8233be3d39b2206555f45 to fix dash compatibility. This fixes building zeromq in our CentOS 8 CI. This is my preferred fix over backporting a zeromq update (which would contain this change).
Github-Pull: bitcoin#24212 Rebased-From: fa5457e
Github-Pull: bitcoin#24212 Rebased-From: fafc55a
0075274
to
d34691c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK d34691c
Backports #24212 to the 22.x branch. Included a bump to libXau and an additional commit for zeromq to fix dash compatibility.