Bugfixes for BIP 174 combining and deserialization #13721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checks that all of the one byte type keys are actually one byte and throw an error if they are not. Add tests for each type to check for this behavior.
Actually merge the global unknown key-value pairs. Add a test for merging unknown key-value pairs.
|
Concept ACK Thanks for taking another look at this code |
|
utACK fad231a |
|
utACK fad231a |
laanwj
added a commit
that referenced
this pull request
Jul 25, 2018
fad231a Fix merging of global unknown data in PSBTs (Andrew Chow) 41df035 Check that PSBT keys are the correct length (Andrew Chow) Pull request description: This PR fixes a few bugs that were found and adds tests checking for these errors. Specifically: - Single byte keys are checked to actually be one byte. - Unknown global data must be merged when combining two PSBTs. Tree-SHA512: c0e7b4bc607d510cc005aaa7c0813ee58c5467ab7ce4adce485522dfeee92b1af3d29fe89df778b0ea812bb3827e085b30e04d4f4ebcefd8364d809573991332
kwvg
pushed a commit
to kwvg/dash
that referenced
this pull request
Jun 4, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jun 4, 2021
UdjinM6
pushed a commit
to UdjinM6/dash
that referenced
this pull request
Jun 7, 2021
barrystyle
pushed a commit
to pacprotocol/pacprotocol
that referenced
this pull request
Jun 8, 2021
…coin#13666, bitcoin#13723: BIP 174 PSBT Serializations and RPCs (PR#4186)
barrystyle
pushed a commit
to pacprotocol/pacprotocol
that referenced
this pull request
Jun 8, 2021
merge bitcoin#13269, bitcoin#13425, bitcoin#13557, bitcoin#13721, bitcoin#13666, bitcoin#13723: from kittywhiskers:psbt
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jun 9, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jul 9, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jul 13, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jul 13, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jul 13, 2021
PastaPastaPasta
added a commit
to dashpay/dash
that referenced
this pull request
Jul 13, 2021
merge bitcoin#13269, bitcoin#13425, bitcoin#13557, bitcoin#13721, bitcoin#13666, bitcoin#13723: BIP 174 PSBT Serializations and RPCs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a few bugs that were found and adds tests checking for these errors.
Specifically: