refactoring: Drop UpdateTransaction in favor of UpdateInput #13269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kallewoof
approved these changes
May 18, 2018
promag
reviewed
May 18, 2018
src/test/transaction_tests.cpp
Outdated
| @@ -629,7 +629,7 @@ BOOST_AUTO_TEST_CASE(test_witness) | |||
| CreateCreditAndSpend(keystore2, scriptMulti, output2, input2, false); | |||
| CheckWithFlag(output2, input2, 0, false); | |||
| BOOST_CHECK(*output1 == *output2); | |||
| UpdateTransaction(input1, 0, CombineSignatures(output1->vout[0].scriptPubKey, MutableTransactionSignatureChecker(&input1, 0, output1->vout[0].nValue), DataFromTransaction(input1, 0), DataFromTransaction(input2, 0))); | |||
| UpdateInput(input1.vin.at(0), CombineSignatures(output1->vout[0].scriptPubKey, MutableTransactionSignatureChecker(&input1, 0, output1->vout[0].nValue), DataFromTransaction(input1, 0), DataFromTransaction(input2, 0))); | |||
There was a problem hiding this comment.
Replace all .at() usages with operator[].
There was a problem hiding this comment.
Thanks, I used at because UpdateTransaction asserted on the length, so it seemed more consistent, but I see now that CreateCreditAndSpend consistently creates this input.
49d8e2d to
3285434
Compare
Updating the input explicitly requires the caller to present a mutable input, which more clearly communicates the effects and intent of the method. In most cases, this input is already immediately available and need not be looked up.
3285434 to
6aa33fe
Compare
|
utACK 6aa33fe. |
|
utACK 6aa33fe |
1 similar comment
|
utACK 6aa33fe |
laanwj
added a commit
that referenced
this pull request
Jun 5, 2018
…nput 6aa33fe Drop UpdateTransaction in favor of UpdateInput (Ben Woosley) Pull request description: Updating the input explicitly requires the caller to present a mutable input, which more clearly communicates the effects and intent of the call (and, often, the enclosing loop). In most cases, this input is already immediately available and need not be looked up. Tree-SHA512: 8c7914a8b7ae975d8ad0e9d760e3c5da65776a5f79d060b8ffb6b3ff7a32235f71ad705f2185b368d9263742d7796bb562395d22b806d90e8502d8c496011e57
kwvg
pushed a commit
to kwvg/dash
that referenced
this pull request
Jun 4, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jun 4, 2021
UdjinM6
pushed a commit
to UdjinM6/dash
that referenced
this pull request
Jun 7, 2021
barrystyle
pushed a commit
to pacprotocol/pacprotocol
that referenced
this pull request
Jun 8, 2021
…coin#13666, bitcoin#13723: BIP 174 PSBT Serializations and RPCs (PR#4186)
barrystyle
pushed a commit
to pacprotocol/pacprotocol
that referenced
this pull request
Jun 8, 2021
merge bitcoin#13269, bitcoin#13425, bitcoin#13557, bitcoin#13721, bitcoin#13666, bitcoin#13723: from kittywhiskers:psbt
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jun 9, 2021
UdjinM6
pushed a commit
to UdjinM6/dash
that referenced
this pull request
Jun 19, 2021
…UpdateInput 6aa33fe Drop UpdateTransaction in favor of UpdateInput (Ben Woosley) Pull request description: Updating the input explicitly requires the caller to present a mutable input, which more clearly communicates the effects and intent of the call (and, often, the enclosing loop). In most cases, this input is already immediately available and need not be looked up. Tree-SHA512: 8c7914a8b7ae975d8ad0e9d760e3c5da65776a5f79d060b8ffb6b3ff7a32235f71ad705f2185b368d9263742d7796bb562395d22b806d90e8502d8c496011e57
UdjinM6
pushed a commit
to UdjinM6/dash
that referenced
this pull request
Jun 24, 2021
…UpdateInput 6aa33fe Drop UpdateTransaction in favor of UpdateInput (Ben Woosley) Pull request description: Updating the input explicitly requires the caller to present a mutable input, which more clearly communicates the effects and intent of the call (and, often, the enclosing loop). In most cases, this input is already immediately available and need not be looked up. Tree-SHA512: 8c7914a8b7ae975d8ad0e9d760e3c5da65776a5f79d060b8ffb6b3ff7a32235f71ad705f2185b368d9263742d7796bb562395d22b806d90e8502d8c496011e57
UdjinM6
pushed a commit
to UdjinM6/dash
that referenced
this pull request
Jun 26, 2021
…UpdateInput 6aa33fe Drop UpdateTransaction in favor of UpdateInput (Ben Woosley) Pull request description: Updating the input explicitly requires the caller to present a mutable input, which more clearly communicates the effects and intent of the call (and, often, the enclosing loop). In most cases, this input is already immediately available and need not be looked up. Tree-SHA512: 8c7914a8b7ae975d8ad0e9d760e3c5da65776a5f79d060b8ffb6b3ff7a32235f71ad705f2185b368d9263742d7796bb562395d22b806d90e8502d8c496011e57
UdjinM6
pushed a commit
to UdjinM6/dash
that referenced
this pull request
Jun 26, 2021
…UpdateInput 6aa33fe Drop UpdateTransaction in favor of UpdateInput (Ben Woosley) Pull request description: Updating the input explicitly requires the caller to present a mutable input, which more clearly communicates the effects and intent of the call (and, often, the enclosing loop). In most cases, this input is already immediately available and need not be looked up. Tree-SHA512: 8c7914a8b7ae975d8ad0e9d760e3c5da65776a5f79d060b8ffb6b3ff7a32235f71ad705f2185b368d9263742d7796bb562395d22b806d90e8502d8c496011e57
UdjinM6
pushed a commit
to UdjinM6/dash
that referenced
this pull request
Jun 28, 2021
…UpdateInput 6aa33fe Drop UpdateTransaction in favor of UpdateInput (Ben Woosley) Pull request description: Updating the input explicitly requires the caller to present a mutable input, which more clearly communicates the effects and intent of the call (and, often, the enclosing loop). In most cases, this input is already immediately available and need not be looked up. Tree-SHA512: 8c7914a8b7ae975d8ad0e9d760e3c5da65776a5f79d060b8ffb6b3ff7a32235f71ad705f2185b368d9263742d7796bb562395d22b806d90e8502d8c496011e57
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jul 9, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jul 13, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jul 13, 2021
PastaPastaPasta
added a commit
to dashpay/dash
that referenced
this pull request
Jul 13, 2021
merge bitcoin#13269, bitcoin#13425, bitcoin#13557, bitcoin#13721, bitcoin#13666, bitcoin#13723: BIP 174 PSBT Serializations and RPCs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the input explicitly requires the caller to present a mutable
input, which more clearly communicates the effects and intent of the call
(and, often, the enclosing loop).
In most cases, this input is already immediately available and need not be
looked up.