Stop translating command line options #13341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Concept ACK. But I think we should reduce abbreviations like |
Fine with me, but that's very much out of scope here. This simply makes the change suggested in the PR and issue, nothing more. |
|
How about also get rid of translations of |
|
Concept ACK. Needs release notes? |
Done, good catch.
I don't think that's necessary to mention explicitly. This is hardly even noticeable to the user. |
|
utACK 2047cde5fe3aaa9cd8318a8d47e8080880a2757b (also verified that the manpages don't change) Please squash. |
|
Concept ACK |
|
utACK 2047cde5fe3aaa9cd8318a8d47e8080880a2757b |
|
Concept ACK |
|
Thanks. Finally! |
Many options are extremely technical, and refer internals, making it difficult to translate usefully. This came up in discussion of e.g. bitcoin#10949. If a message is not understood by translators (which are typically end-users, not developers) they'll either translate it literally, making it harder to understand instead of easier, with the added drawback of the user no longer being able to google it. Also the translation was only working for bitcoin-qt as with the console programs, there is no translation backend. So it was injecting never-used translation messages for bitcoin-cli, -tx. For these reasons, stop translating options help completely. This should not affect the output **in any way** except for bitcoin-qt when a non-English language is configured in the locale. This implements bitcoin#10962.
2047cde to
3d4fa83
Compare
|
Squashed 2047cde5fe3aaa9cd8318a8d47e8080880a2757b → 3d4fa83
Good idea. |
|
Will test. |
|
re-ACK 3d4fa83 (No changes, so didn't re-test) |
|
Tested ACK 3d4fa83 |
maflcko
pushed a commit
that referenced
this pull request
May 30, 2018
3d4fa83 Stop translating command line options (Wladimir J. van der Laan) Pull request description: Many options are extremely technical, and refer internals, making it difficult to translate usefully. This came up in discussion of e.g. #10949. If a message is not understood by translators (which are typically end-users, not developers) they'll either translate it literally, making it harder to understand instead of easier, with the added drawback of the user no longer being able to google it. Also the translation was only working for bitcoin-qt as with the console programs, there is no translation backend. So it was injecting never-used translation messages for bitcoin-cli, -tx. For these reasons, stop translating options help completely. This should not affect the output **in any way** \* except for bitcoin-qt when a non-English language is configured in the locale. This implements #10962. \*) I checked this, but please do verify this. Tree-SHA512: 46c5f2ac0d4dbe9a6710fab498781e442dd6d6ac17613a99fcfe7a62bf6811fa1c92400d35bd389772cb4b31c6918df261548cbc677addba653f44083b9aeeda
|
Tested ACK 3d4fa83. Help -> Command line options window also show not translated. |
This was referenced May 30, 2018
laanwj
added a commit
that referenced
this pull request
Jul 4, 2018
747ee89 Docs: Modify policy to not translate command-line help (Chun Kuan Lee) Pull request description: After #13341, command-line helps would no longer be translated. Tree-SHA512: 73e7a7545b316cc6ec07f2527cc0e63c922d8e382abd779638583d55a4ee0f3b26ecc9d63f51da8bab2eda9829ec5d1b3162a1115c78a1add2621ba2ccdb839e
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 7, 2020
…e help 747ee89 Docs: Modify policy to not translate command-line help (Chun Kuan Lee) Pull request description: After bitcoin#13341, command-line helps would no longer be translated. Tree-SHA512: 73e7a7545b316cc6ec07f2527cc0e63c922d8e382abd779638583d55a4ee0f3b26ecc9d63f51da8bab2eda9829ec5d1b3162a1115c78a1add2621ba2ccdb839e
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 7, 2020
…e help 747ee89 Docs: Modify policy to not translate command-line help (Chun Kuan Lee) Pull request description: After bitcoin#13341, command-line helps would no longer be translated. Tree-SHA512: 73e7a7545b316cc6ec07f2527cc0e63c922d8e382abd779638583d55a4ee0f3b26ecc9d63f51da8bab2eda9829ec5d1b3162a1115c78a1add2621ba2ccdb839e
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 8, 2020
…e help 747ee89 Docs: Modify policy to not translate command-line help (Chun Kuan Lee) Pull request description: After bitcoin#13341, command-line helps would no longer be translated. Tree-SHA512: 73e7a7545b316cc6ec07f2527cc0e63c922d8e382abd779638583d55a4ee0f3b26ecc9d63f51da8bab2eda9829ec5d1b3162a1115c78a1add2621ba2ccdb839e
UdjinM6
added a commit
to UdjinM6/dash
that referenced
this pull request
Mar 19, 2021
UdjinM6
pushed a commit
to UdjinM6/dash
that referenced
this pull request
Mar 19, 2021
3d4fa83 Stop translating command line options (Wladimir J. van der Laan) Pull request description: Many options are extremely technical, and refer internals, making it difficult to translate usefully. This came up in discussion of e.g. bitcoin#10949. If a message is not understood by translators (which are typically end-users, not developers) they'll either translate it literally, making it harder to understand instead of easier, with the added drawback of the user no longer being able to google it. Also the translation was only working for bitcoin-qt as with the console programs, there is no translation backend. So it was injecting never-used translation messages for bitcoin-cli, -tx. For these reasons, stop translating options help completely. This should not affect the output **in any way** \* except for bitcoin-qt when a non-English language is configured in the locale. This implements bitcoin#10962. \*) I checked this, but please do verify this. Tree-SHA512: 46c5f2ac0d4dbe9a6710fab498781e442dd6d6ac17613a99fcfe7a62bf6811fa1c92400d35bd389772cb4b31c6918df261548cbc677addba653f44083b9aeeda
UdjinM6
pushed a commit
to UdjinM6/dash
that referenced
this pull request
Mar 19, 2021
3d4fa83 Stop translating command line options (Wladimir J. van der Laan) Pull request description: Many options are extremely technical, and refer internals, making it difficult to translate usefully. This came up in discussion of e.g. bitcoin#10949. If a message is not understood by translators (which are typically end-users, not developers) they'll either translate it literally, making it harder to understand instead of easier, with the added drawback of the user no longer being able to google it. Also the translation was only working for bitcoin-qt as with the console programs, there is no translation backend. So it was injecting never-used translation messages for bitcoin-cli, -tx. For these reasons, stop translating options help completely. This should not affect the output **in any way** \* except for bitcoin-qt when a non-English language is configured in the locale. This implements bitcoin#10962. \*) I checked this, but please do verify this. Tree-SHA512: 46c5f2ac0d4dbe9a6710fab498781e442dd6d6ac17613a99fcfe7a62bf6811fa1c92400d35bd389772cb4b31c6918df261548cbc677addba653f44083b9aeeda
random-zebra
added a commit
to PIVX-Project/PIVX
that referenced
this pull request
Sep 6, 2021
d838f20 Update manpages to reflect newer template (Fuzzbawls) d510ce0 [Docs] Reformat -help output for help2man (Fuzzbawls) 7f655de Run make translate to update source files (Fuzzbawls) 8608d3a Stop translating command line options (Fuzzbawls) 00dcec7 Stop translating remaining usages of PACKAGE_NAME (Fuzzbawls) 03a002a Unify product name to as few places as possible (Fuzzbawls) Pull request description: This stops the practice of repeatedly translating the string literal `PIVX Core` in multiple strings, which should never be localized as it is a proper product name. Also stops translating command line arguments as they were only ever translated for pivx-qt and not for the command line programs. Many of these arguments are highly technical in nature, and translating them has been problematic (with translation errors or literal translations that result in incorrect argument names) and leads to more confusion rather than less confusion. Lastly, a quick formatting change to the `-help` output of binary programs is included to make the release-distributed manpages more compliant with the help2man expected formatting. Overall, this results in a reduction of strings to translate by ~190, which should assist in getting language translations to meet our minimum translation threshold for inclusion in releases. ------- Based on the following upstream commits/PRs: - bitcoin@d5f4683 - bitcoin#13341 - bitcoin#13872 - bitcoin#16291 ACKs for top commit: furszy: ACK d838f20 random-zebra: utACK d838f20. Merging. Tree-SHA512: bb57d637b7b905421279483fcf95cfea4f4acf301fb1556e6bc8d2ab6e1c4f00d5a232be8d17181119c847047b3b81c4d2f5f62ec949999e4274836ef27e680f
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many options are extremely technical, and refer internals, making it difficult to translate usefully. This came up in discussion of e.g. #10949. If a message is not understood by translators (which are typically end-users, not developers) they'll either translate it literally, making it harder to understand instead of easier, with the added drawback of the user no longer being able to google it.
Also the translation was only working for bitcoin-qt as with the console programs, there is no translation backend. So it was injecting never-used translation messages for bitcoin-cli, -tx.
For these reasons, stop translating options help completely. This should not affect the output in any way * except for bitcoin-qt when a non-English language is configured in the locale.
This implements #10962.
*) I checked this, but please do verify this.