Skip to content

Clarify help message for -discardfee #10949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2017
Merged

Clarify help message for -discardfee #10949

merged 1 commit into from
Jul 31, 2017

Conversation

morcos
Copy link
Contributor

@morcos morcos commented Jul 28, 2017

No description provided.

@TheBlueMatt
Copy link
Contributor

utACK, maybe a 15 tag?

@maflcko maflcko added this to the 0.15.0 milestone Jul 30, 2017
@maflcko maflcko added the Docs label Jul 30, 2017
@laanwj
Copy link
Member

laanwj commented Jul 31, 2017 •
edited
Loading

Thanks, utACK bdd5543

@laanwj laanwj merged commit bdd5543 into bitcoin:master Jul 31, 2017
laanwj added a commit that referenced this pull request Jul 31, 2017
@laanwj
Merge #10949: Clarify help message for -discardfee
af56397 
bdd5543 Clarify help message for -discardfee (Alex Morcos)

Pull request description:

Tree-SHA512: 7c2f644d1c18e18f11fd85a7b6ca38c480e1ee3932daa4bb19a3965b88146dda899ead0f34d8da02db640598197167bcf69d511501b729e3a8b5b7b6adf08d4e
@laanwj laanwj mentioned this pull request Jul 31, 2017
Closed
@laanwj laanwj mentioned this pull request May 29, 2018
Merged
laanwj added a commit to laanwj/bitcoin that referenced this pull request May 30, 2018
@laanwj
Stop translating command line options
3d4fa83 
Many options are extremely technical, and refer internals, making it
difficult to translate usefully. This came up in discussion of e.g.
 bitcoin#10949. If a message is not understood by translators (which are
typically end-users, not developers) they'll either translate it
literally, making it harder to understand instead of easier, with the
added drawback of the user no longer being able to google it.

Also the translation was only working for bitcoin-qt as with
the console programs, there is no translation backend. So it was
injecting never-used translation messages for bitcoin-cli, -tx.

For these reasons, stop translating options help completely. This should
not affect the output **in any way** except for bitcoin-qt when a
non-English language is configured in the locale.

This implements bitcoin#10962.
maflcko pushed a commit that referenced this pull request May 30, 2018
Merge #13341: Stop translating command line options
25d2df2 
3d4fa83 Stop translating command line options (Wladimir J. van der Laan)

Pull request description:

  Many options are extremely technical, and refer internals, making it difficult to translate usefully. This came up in discussion of e.g.  #10949. If a message is not understood by translators (which are typically end-users, not developers) they'll either translate it literally, making it harder to understand instead of easier, with the added drawback of the user no longer being able to google it.

  Also the translation was only working for bitcoin-qt as with the console programs, there is no translation backend. So it was injecting never-used translation messages for bitcoin-cli, -tx.

  For these reasons, stop translating options help completely. This should not affect the output **in any way** \* except for bitcoin-qt when a non-English language is configured in the locale.

  This implements #10962.

  \*) I checked this, but please do verify this.

Tree-SHA512: 46c5f2ac0d4dbe9a6710fab498781e442dd6d6ac17613a99fcfe7a62bf6811fa1c92400d35bd389772cb4b31c6918df261548cbc677addba653f44083b9aeeda
stamhe pushed a commit to stamhe/bitcoin that referenced this pull request Jun 27, 2018
@laanwj @stamhe
Stop translating command line options
32fbfda 
Many options are extremely technical, and refer internals, making it
difficult to translate usefully. This came up in discussion of e.g.
 bitcoin#10949. If a message is not understood by translators (which are
typically end-users, not developers) they'll either translate it
literally, making it harder to understand instead of easier, with the
added drawback of the user no longer being able to google it.

Also the translation was only working for bitcoin-qt as with
the console programs, there is no translation backend. So it was
injecting never-used translation messages for bitcoin-cli, -tx.

For these reasons, stop translating options help completely. This should
not affect the output **in any way** except for bitcoin-qt when a
non-English language is configured in the locale.

This implements bitcoin#10962.
@HashUnlimited HashUnlimited mentioned this pull request Sep 10, 2018
Merged
HashUnlimited pushed a commit to HashUnlimited/chaincoin that referenced this pull request Sep 10, 2018
@laanwj
Stop translating command line options
14ceb37 
Many options are extremely technical, and refer internals, making it
difficult to translate usefully. This came up in discussion of e.g.
 bitcoin#10949. If a message is not understood by translators (which are
typically end-users, not developers) they'll either translate it
literally, making it harder to understand instead of easier, with the
added drawback of the user no longer being able to google it.

Also the translation was only working for bitcoin-qt as with
the console programs, there is no translation backend. So it was
injecting never-used translation messages for bitcoin-cli, -tx.

For these reasons, stop translating options help completely. This should
not affect the output **in any way** except for bitcoin-qt when a
non-English language is configured in the locale.

This implements bitcoin#10962.
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Sep 8, 2019
@laanwj @PastaPastaPasta
Merge bitcoin#10949: Clarify help message for -discardfee
6c758fa 
bdd5543 Clarify help message for -discardfee (Alex Morcos)

Pull request description:

Tree-SHA512: 7c2f644d1c18e18f11fd85a7b6ca38c480e1ee3932daa4bb19a3965b88146dda899ead0f34d8da02db640598197167bcf69d511501b729e3a8b5b7b6adf08d4e
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Sep 8, 2019
@laanwj @PastaPastaPasta
Merge bitcoin#10949: Clarify help message for -discardfee
b0a85b4 
bdd5543 Clarify help message for -discardfee (Alex Morcos)

Pull request description:

Tree-SHA512: 7c2f644d1c18e18f11fd85a7b6ca38c480e1ee3932daa4bb19a3965b88146dda899ead0f34d8da02db640598197167bcf69d511501b729e3a8b5b7b6adf08d4e
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Sep 8, 2019
@laanwj @PastaPastaPasta
Merge bitcoin#10949: Clarify help message for -discardfee
c2e6a2f 
bdd5543 Clarify help message for -discardfee (Alex Morcos)

Pull request description:

Tree-SHA512: 7c2f644d1c18e18f11fd85a7b6ca38c480e1ee3932daa4bb19a3965b88146dda899ead0f34d8da02db640598197167bcf69d511501b729e3a8b5b7b6adf08d4e
barrystyle pushed a commit to PACGlobalOfficial/PAC that referenced this pull request Jan 22, 2020
@laanwj
Merge bitcoin#10949: Clarify help message for -discardfee
ba421fd 
bdd5543 Clarify help message for -discardfee (Alex Morcos)

Pull request description:

Tree-SHA512: 7c2f644d1c18e18f11fd85a7b6ca38c480e1ee3932daa4bb19a3965b88146dda899ead0f34d8da02db640598197167bcf69d511501b729e3a8b5b7b6adf08d4e
UdjinM6 pushed a commit to UdjinM6/dash that referenced this pull request Mar 19, 2021
@UdjinM6
Merge bitcoin#13341: Stop translating command line options
d78bf47 
3d4fa83 Stop translating command line options (Wladimir J. van der Laan)

Pull request description:

  Many options are extremely technical, and refer internals, making it difficult to translate usefully. This came up in discussion of e.g.  bitcoin#10949. If a message is not understood by translators (which are typically end-users, not developers) they'll either translate it literally, making it harder to understand instead of easier, with the added drawback of the user no longer being able to google it.

  Also the translation was only working for bitcoin-qt as with the console programs, there is no translation backend. So it was injecting never-used translation messages for bitcoin-cli, -tx.

  For these reasons, stop translating options help completely. This should not affect the output **in any way** \* except for bitcoin-qt when a non-English language is configured in the locale.

  This implements bitcoin#10962.

  \*) I checked this, but please do verify this.

Tree-SHA512: 46c5f2ac0d4dbe9a6710fab498781e442dd6d6ac17613a99fcfe7a62bf6811fa1c92400d35bd389772cb4b31c6918df261548cbc677addba653f44083b9aeeda
UdjinM6 pushed a commit to UdjinM6/dash that referenced this pull request Mar 19, 2021
@UdjinM6
Merge bitcoin#13341: Stop translating command line options
b27554b 
3d4fa83 Stop translating command line options (Wladimir J. van der Laan)

Pull request description:

  Many options are extremely technical, and refer internals, making it difficult to translate usefully. This came up in discussion of e.g.  bitcoin#10949. If a message is not understood by translators (which are typically end-users, not developers) they'll either translate it literally, making it harder to understand instead of easier, with the added drawback of the user no longer being able to google it.

  Also the translation was only working for bitcoin-qt as with the console programs, there is no translation backend. So it was injecting never-used translation messages for bitcoin-cli, -tx.

  For these reasons, stop translating options help completely. This should not affect the output **in any way** \* except for bitcoin-qt when a non-English language is configured in the locale.

  This implements bitcoin#10962.

  \*) I checked this, but please do verify this.

Tree-SHA512: 46c5f2ac0d4dbe9a6710fab498781e442dd6d6ac17613a99fcfe7a62bf6811fa1c92400d35bd389772cb4b31c6918df261548cbc677addba653f44083b9aeeda
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Docs Wallet
Projects
None yet
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.
5 participants
@morcos @TheBlueMatt @laanwj @fanquake @maflcko