-
Notifications
You must be signed in to change notification settings - Fork 37.7k
depends: Remove ccache #12607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
depends: Remove ccache #12607
Conversation
Concept ACK, let's see what Travis says |
utACK ec7602b39eea0a7f8bc59eca3ac530e96e1e90e6 |
Looks like configure picked up the ccache: utACK ec7602b |
Lets see the gitian builder says: |
@jonasschnelli 's gitian build seems fine |
What we still need to check is whether travis caches the ccache result, even though Edit: I tried through the GUI, as well as the travis command line tool, but with neither I was able to locate the cache for this PR. This might either mean it doesn't exist, or I couldn't get at it for another reason (e.g. some upper limit to the number of shown caches). Seems the former. At the end of the travis logs it says:
It's not writing the cache at all because it detects no changes?! |
.travis.yml
Outdated
directories: | ||
- depends/built | ||
- depends/sdk-sources | ||
- $HOME/.ccache |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My guess is that this needs to be re-added
Just in case it's helpful, I successfully complied this on NetBSD 7.0 (64-bit). These are the commands I used:
If you'd like me to try building with different parameters, or check for the presence of certain files/directories, please let me know. |
@randolf Thanks for testing, however this does not affect normal autotools builds, if you don't use the depends system. And I don't think the depends system works on NetBSD (though never tried). |
@laanwj I don't know enough about the "depends system" to provide helpful perspective there, but I'd be happy to try if there are some instructions somewhere that I can follow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK cc87967
re-utACK cc87967 Caching works on arm and osx cross-builds at least |
utACK cc87967 - will merge this tomorrow after the meeting to minimize the amount of interference with ongoing travis testing |
@laanwj I assume the meeting is over? |
cc87967 depends: Remove ccache (fanquake) Pull request description: After discussion with @theuni, we can possibly just remove ccache from depends entirely. Related to #12606 Tree-SHA512: ae0a60c8d97467fa41d617daa48ed22159cf32613808634a983304901dd5ed27124e77868d2314004e5144f7b35ba1333f720bb12daec4c5ca03aaf29d593ef2
The travis builds on all my PR's seem to be failing with errors like:
An example is https://travis-ci.org/bitcoin/bitcoin/jobs/350509177#L1055 |
@ryanofsky This is a travis bug. The command you mention above was removed from the travis yaml, it shouldn't be executed at all. You can either ignore the failure or rebase your pull request on master. (Just changing the commit id via Edit: Just checked that rebase is not needed. You can just change the commit id |
cc87967 depends: Remove ccache (fanquake) Pull request description: After discussion with @theuni, we can possibly just remove ccache from depends entirely. Related to bitcoin#12606 Tree-SHA512: ae0a60c8d97467fa41d617daa48ed22159cf32613808634a983304901dd5ed27124e77868d2314004e5144f7b35ba1333f720bb12daec4c5ca03aaf29d593ef2
cc87967 depends: Remove ccache (fanquake) Pull request description: After discussion with @theuni, we can possibly just remove ccache from depends entirely. Related to bitcoin#12606 Tree-SHA512: ae0a60c8d97467fa41d617daa48ed22159cf32613808634a983304901dd5ed27124e77868d2314004e5144f7b35ba1333f720bb12daec4c5ca03aaf29d593ef2
Summary: This removes `ccache` from the depends. Host `ccache` will be used instead if installed. Backport of core [[bitcoin/bitcoin#12607 | PR12607]]. This will fix a future issue when porting [[bitcoin/bitcoin#12402 | PR12402]], so these PR are ported in reverse order. Test Plan: Run the Gitian builds twice and ensure the build is still deterministic. Reviewers: #bitcoin_abc, jasonbcox Reviewed By: #bitcoin_abc, jasonbcox Differential Revision: https://reviews.bitcoinabc.org/D5503
Summary: This removes `ccache` from the depends. Host `ccache` will be used instead if installed. Backport of core [[bitcoin/bitcoin#12607 | PR12607]]. This will fix a future issue when porting [[bitcoin/bitcoin#12402 | PR12402]], so these PR are ported in reverse order. Test Plan: Run the Gitian builds twice and ensure the build is still deterministic. Reviewers: #bitcoin_abc, jasonbcox Reviewed By: #bitcoin_abc, jasonbcox Differential Revision: https://reviews.bitcoinabc.org/D5503
After discussion with @theuni, we can possibly just remove ccache from depends entirely.
Related to #12606