Skip to content

Conversation

maflcko
Copy link
Member

@maflcko maflcko commented Mar 5, 2018

According to #12515 cross-compiling for windows on linux requires a work-around. I believe that for this reason, the nightly builds for linux and windows are not available: https://bitcoin.jonasschnelli.ch/build/522

It should be safe to just revert to the previously known-to-be-working version of ccache.

Fixes #12515

Reverts one commit of #12402

@laanwj
Copy link
Member

laanwj commented Mar 5, 2018

Will this bring back the problem @achow101 reported in #12402 (comment) ?

It looks like ccache's bundled zlib is failing to build with mingw which is causing #12515. This was also reported in IRC as causing an issue with a new gitian setup.

@maflcko
Copy link
Member Author

maflcko commented Mar 5, 2018

@laanwj The problem exists in 3.4.1 (our current version) and is fixed in 3.4.2 (which is not yet released). I think we can also fix it by reverting to 3.3.4.

@laanwj
Copy link
Member

laanwj commented Mar 5, 2018

Oops, sorry, I was confused there, then.

I think we can also fix it by reverting to 3.3.4.

An alternative just mentioned @theuni was to remove ccache from the depends, and have it use the OS's ccache if installed and none if not.

@achow101
Copy link
Member

achow101 commented Mar 5, 2018

utACK faf8994

@laanwj
Copy link
Member

laanwj commented Mar 5, 2018

utACK faf8994, if this fixes the issue for now. Other solutions can be pursued later.

On second thought, this will cause travis to rebuild everything (all the depends) as everything depends on ccache, so better to merge only one change, and @fanquake is already working on a PR that will completely retire ccache. So better to hold off merging this for now.

@fanquake fanquake mentioned this pull request Mar 5, 2018
@maflcko maflcko closed this Mar 6, 2018
@maflcko maflcko deleted the Mf1803-dependsCCache branch March 6, 2018 14:34
maflcko pushed a commit that referenced this pull request Mar 8, 2018
cc87967 depends: Remove ccache (fanquake)

Pull request description:

  After discussion with @theuni, we can possibly just remove ccache from depends entirely.

  Related to #12606

Tree-SHA512: ae0a60c8d97467fa41d617daa48ed22159cf32613808634a983304901dd5ed27124e77868d2314004e5144f7b35ba1333f720bb12daec4c5ca03aaf29d593ef2
codablock pushed a commit to codablock/dash that referenced this pull request Nov 4, 2019
cc87967 depends: Remove ccache (fanquake)

Pull request description:

  After discussion with @theuni, we can possibly just remove ccache from depends entirely.

  Related to bitcoin#12606

Tree-SHA512: ae0a60c8d97467fa41d617daa48ed22159cf32613808634a983304901dd5ed27124e77868d2314004e5144f7b35ba1333f720bb12daec4c5ca03aaf29d593ef2
barrystyle pushed a commit to PACGlobalOfficial/PAC that referenced this pull request Jan 22, 2020
cc87967 depends: Remove ccache (fanquake)

Pull request description:

  After discussion with @theuni, we can possibly just remove ccache from depends entirely.

  Related to bitcoin#12606

Tree-SHA512: ae0a60c8d97467fa41d617daa48ed22159cf32613808634a983304901dd5ed27124e77868d2314004e5144f7b35ba1333f720bb12daec4c5ca03aaf29d593ef2
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instructions for compiling Bitcoin Core missing steps or otherwise not compiling bitcoin for windows in linux
3 participants