Skip to content

[berkeleydb] Fix build error with Visual Studio 16.7.0 #12870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 21, 2020
Merged

[berkeleydb] Fix build error with Visual Studio 16.7.0 #12870

merged 2 commits into from
Aug 21, 2020

Conversation

LilyWangL
Copy link
Contributor

Describe the pull request

  • What does your PR fix? Fixes [berkeleydb] build failure #12791
    Due to berkeleydb defining a function-like macro atomic_init of the same name as a standard library, berkeleydb build failed with Visual Studio 16.7.0. Adding patch to rename macro atomic_init, this will fix this issue temporarily.
  • Which triplets are supported/not supported? Have you updated the CI baseline?
    No
  • Does your PR follow the maintainer guide?
    Yes

@LilyWangL LilyWangL added category:port-bug The issue is with a library, which is something the port should already support info:internal labels Aug 12, 2020
@LilyWangL LilyWangL requested a review from BillyONeal August 12, 2020 08:55
@BillyONeal
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@BillyONeal
Copy link
Member

I don't know why there were the linux failures; it looks like an incorrectly declared dependency, but when I try myself the problem doesn't repro. Just going to try rerun...

/usr/bin/c++  -DEMBED_PLUGINS=1 -DOIIO_STATIC_DEFINE=1 -DUSE_BOOST_ASIO=1 -DUSE_HEIF=1 -DUSE_JPEG_TURBO=1 -DUSE_STD_REGEX -D__STDC_CONSTANT_MACROS -D__STDC_LIMIT_MACROS -Iinclude -Isrc/include -I/mnt/vcpkg-ci/buildtrees/openimageio/src/9c73ea82cc-f088f982ce.clean/src/include -I/mnt/vcpkg-ci/buildtrees/openimageio/src/9c73ea82cc-f088f982ce.clean/src/dds.imageio/squish -I/mnt/vcpkg-ci/packages/openimageio_x64-linux/debug/include -isystem /mnt/vcpkg-ci/installed/x64-linux/include -isystem /mnt/vcpkg-ci/installed/x64-linux/include/OpenEXR -fPIC -g -fPIC   -Wall -Wno-unused-local-typedefs -Wno-unused-result -Wno-aligned-new -Wno-noexcept-type -fno-math-errno -std=c++14 -MD -MT src/libOpenImageIO/CMakeFiles/OpenImageIO.dir/__/heif.imageio/heifoutput.cpp.o -MF src/libOpenImageIO/CMakeFiles/OpenImageIO.dir/__/heif.imageio/heifoutput.cpp.o.d -o src/libOpenImageIO/CMakeFiles/OpenImageIO.dir/__/heif.imageio/heifoutput.cpp.o -c /mnt/vcpkg-ci/buildtrees/openimageio/src/9c73ea82cc-f088f982ce.clean/src/heif.imageio/heifoutput.cpp
/mnt/vcpkg-ci/buildtrees/openimageio/src/9c73ea82cc-f088f982ce.clean/src/heif.imageio/heifoutput.cpp:10:10: fatal error: libheif/heif_cxx.h: No such file or directory
 #include <libheif/heif_cxx.h>
          ^~~~~~~~~~~~~~~~~~~~
compilation terminated.

@BillyONeal
Copy link
Member

Well now it passed ¯_(ツ)_/¯

@BillyONeal
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@BillyONeal
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@BillyONeal BillyONeal marked this pull request as ready for review August 21, 2020 23:32
@BillyONeal BillyONeal merged commit cd81eb1 into microsoft:master Aug 21, 2020
@BillyONeal
Copy link
Member

Thanks for your contribution! I merged even though this was marked draft because it is blocking the infrastructure update to 16.7.

@StarGate-One
Copy link
Contributor

@BillyONeal @LilyWangL Thank you, works like before. Have a great weekend.

remz1337 pushed a commit to remz1337/vcpkg that referenced this pull request Aug 23, 2020
@LilyWangL @remz1337
[berkeleydb] Fix build error with Visual Studio 16.7.0 (microsoft#12870)
983448a
@sipsorcery sipsorcery mentioned this pull request Aug 31, 2020
Merged
maflcko pushed a commit to bitcoin/bitcoin that referenced this pull request Aug 31, 2020
Merge #19842: Update the vcpkg checkout commit ID in appveyor config
068bc21 
a104cae Update the vcpkg checkout commit ID in appveyor config. (Aaron Clauson)

Pull request description:

  A recent appveyor vm update broke the build of the `berkeleydb` vcpkg dependency, see #19839. The temporary resolution was to switch back to the previous appveyor vm.

  This PR updates the pegged vcpkg commit ID to the most recent commit as of 31 Aug 2020. That commit ID has been tested against the latest appveyor vm and is able to build Bitcoin Core successfully.

  The vcpkg bump includes a [patch](microsoft/vcpkg#12870) to the `berkeleydb` build config which allows it to be built on the latest appveyor vm.

ACKs for top commit:
  MarcoFalke:
    Concept ACK a104cae

Tree-SHA512: 6d363d1615c51bb3d4b324eb96d53950648fc97fc81ffaef91ee6e92f1336776d150d89f6e859f354ee75ce66afcef07aa19ed39b725dbb3f47ba67d26e111db
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillyONeal BillyONeal Awaiting requested review from BillyONeal

Assignees

@BillyONeal BillyONeal

@JackBoosY JackBoosY

Labels
category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[berkeleydb] build failure
4 participants
@LilyWangL @BillyONeal @StarGate-One @JackBoosY