rpc: gui: Don't change behavior based on private keys disabled, instead add new buttons/rpcs/menu items #18627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit does not change behavior.
So it can be used in the GUI.
co-authored-by: Glenn Willen <gwillen@nerdnet.org>
co-authored-by: Glenn Willen <gwillen@nerdnet.org>
Instead of changing Send to make an unsigned tx for wallets with private keys disabled, have a separate button for that functionality and disable Send for such wallets.
Instead of changing GUI bumpfee behavior based on private keys, make a separate menu action to do that.
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced Apr 13, 2020
|
concept and light GUI tACK 11f2521
|
|
Concept ACK |
With psbtbumpfee, we can deprecate bumpfee's psbt creation behavior. So put that behind a -deprecatedrpc
11f2521 to
55436f3
Compare
|
Concept ACK |
This was referenced Apr 15, 2020
meshcollider
added a commit
that referenced
this pull request
Aug 13, 2020
…tbumpfee 79d6332 moveonly: Fix indentation in bumpfee RPC (Andrew Chow) 431071c Hide bumpfee's psbt creation behavior behind -deprecatedrpc (Andrew Chow) 4638224 Add psbtbumpfee RPC (Andrew Chow) Pull request description: Adds a new RPC `psbtbumpfee` which always creates a psbt. `bumpfee` will then only be able to create and broadcast fee bumping transactions instead of changing its behavior based on `IsWalletSet(WALLET_FLAG_DISABLE_PRIVATE_KEYS)`. Split from #18627 ACKs for top commit: Sjors: re-utACK 79d6332 meshcollider: utACK 79d6332 fjahr: Code review ACK 79d6332 Tree-SHA512: 1c92c4b4461bb30e78be3ee73165f624398ef33996ce36043b61a8931be667030d0fca12fd0b30097b78c56e4e9092c69582b237cbdac51d56f6be23d8c0f1bb
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Aug 14, 2020
…nto psbtbumpfee 79d6332 moveonly: Fix indentation in bumpfee RPC (Andrew Chow) 431071c Hide bumpfee's psbt creation behavior behind -deprecatedrpc (Andrew Chow) 4638224 Add psbtbumpfee RPC (Andrew Chow) Pull request description: Adds a new RPC `psbtbumpfee` which always creates a psbt. `bumpfee` will then only be able to create and broadcast fee bumping transactions instead of changing its behavior based on `IsWalletSet(WALLET_FLAG_DISABLE_PRIVATE_KEYS)`. Split from bitcoin#18627 ACKs for top commit: Sjors: re-utACK 79d6332 meshcollider: utACK 79d6332 fjahr: Code review ACK 79d6332 Tree-SHA512: 1c92c4b4461bb30e78be3ee73165f624398ef33996ce36043b61a8931be667030d0fca12fd0b30097b78c56e4e9092c69582b237cbdac51d56f6be23d8c0f1bb
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of changing some actions' behavior based on
IsWalletFlagSet(WALLET_FLAG_DISABLE_PRIVATE_KEYS), make separate things that work with no private keys. In particular, instead of havingbumpfeegive out a psbt when there are no private keys, add apsbtbumpfeeRPC that always gives out a psbt and just havebumpfeebe disabled when there are no private keys. This is mirrored in the GUI bumpfee menu items. Additionally, instead of changing theSendbutton toCreate Unsignedwhen there are no private keys, just always have aCreate Unsignedbutton and disableSendwhen there are no private keys. To deal withbumpfeealready doing the mutated behavior thing, that behavior is hidden behind a-deprecatedrpc=bumpfeeoption.To make the GUI stuff easier to follow, test, and review, this is being based on #17509