gui: Add bumpFeePSBT action instead of changing normal bumpfee behavior #18655
Conversation
Instead of changing GUI bumpfee behavior based on private keys, make a separate menu action to do that.
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
I'm not a fan of cluttering the UI with disabled options. You could hide them instead. But then it's not very clear to me what the point is of this change. |
|
This would likely confuse users as-is. Can we simplify the workflow so it always makes a PSBT, but in a way that users can easily sign+broadcast? Perhaps the PSBT dialog can become like the current bump-fee dialog unless an expert-mode option is enabled? |
|
@Sjors I think this change(along with others) is to de-couple the concept of "disabled private keys" and being able to easily make PSBT stuff in GUI. f.e., in a descriptor wallet you may have 1 of the 3 privkeys in the wallet, so you may want to be able to have both buttons/options displayed to avoid having to figure out solveability. |
|
I'd rather achieve that by adding a bumpfee dialog, and having a "make PSBT" checkbox. Such a dialog is useful anyway, in order to specify an amount. |
|
Since this action does eventually bring up a dialog, I can change this to add a button to that dialog. |
Similar to #18654, instead of a single fee bumping action that changes its behavior based on
IsWalletFlagSet(WALLET_FLAG_DISABLE_PRIVATE_KEYS), separate it to have one that always tries to sign and send, and another that copies a psbt to the clipboard. So a new menu action is added and the original action will be disabled if private keys are disabled.Split from #18627