gitian: Add missing automake package to gitian-win-signer.yml #18598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
automake is needed to build osslsigncode otherwise autogen.sh fails.
hebasto
reviewed
Apr 11, 2020
| @@ -8,6 +8,7 @@ architectures: | |||
| packages: | |||
| - "libssl-dev" | |||
| - "autoconf" | |||
| - "automake" | |||
There was a problem hiding this comment.
nit: automake depends on autoconf, therefore, the latter could be dropped.
fanquake
approved these changes
Apr 12, 2020
|
@achow101 UPDATE: my base manifest already containes |
That's interesting. Which virtualization are you using? Can you post your install.log? I use docker which has a very minimal dependency base. So if you are using something else, maybe a dependency is installed that requires automake. |
It is not quite informative:
LXC 3.0.3 |
Maybe it is worth to mention Docker in the OP? |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Apr 17, 2020
…in-signer.yml e44aeef gitian: Add missing automake package to gitian-win-signer.yml (Andrew Chow) Pull request description: automake is needed to build osslsigncode otherwise autogen.sh fails with the docker virtualization method. ACKs for top commit: hebasto: ACK e44aeef, for `osslsigncode-1.7.1` we did not run `autogen.sh` in the past. fanquake: ACK e44aeef jonatack: ACK e44aeef Tree-SHA512: a0e615c1b099ee1c469ce41f886f2ece6746234a5a800743a4e8be671e4114fd30e1c35bc0ddcb75778409564129d0fde7ac4e3d70b0f7691f97f729f34c8e0c
fanquake
pushed a commit
to fanquake/bitcoin
that referenced
this pull request
Apr 23, 2020
automake is needed to build osslsigncode otherwise autogen.sh fails. Github-Pull: bitcoin#18598 Rebased-From: e44aeef
Merged
laanwj
added a commit
that referenced
this pull request
May 11, 2020
7f7548d rpc: Do not advertise dumptxoutset as a way to flush the chainstate (MarcoFalke) a9ca65b Fix naming of macOS SDK and clarify version (Andrew Chow) 54d2063 Do not expose and consider -logthreadnames when it does not work (Hennadii Stepanov) 6986b26 build: fix ASLR for bitcoin-cli on Windows (fanquake) 1d1e358 build: Set libevent minimum version to 2.0.21 (Hennadii Stepanov) 842b13a Avoid non-trivial global constants in SHA-NI code (Pieter Wuille) ade4185 gitian: Add missing automake package to gitian-win-signer.yml (Andrew Chow) Pull request description: Currently backports the following to the 0.20 branch: * #18598 - gitian: Add missing automake package to gitian-win-signer.yml * #18702 - build: fix ASLR for bitcoin-cli on Windows * #18676 - build: Check libevent minimum version in configure script * #18665 - Do not expose and consider -logthreadnames when it does not work * #18553 - Avoid non-trivial global constants in SHA-NI code * #18589 - Fix naming of macOS SDK and clarify version ACKs for top commit: laanwj: ACK 7f7548d Tree-SHA512: 2cba748414a440e3fb901940085a7ae059e8b926c9187fbbbdeb7846a32e7374f318cc21e499c911ff803c42aef2c844b04af10b87f9c5a2b3edf6deb03ebb04
backpacker69
referenced
this pull request
in peercoin/peercoin
Mar 28, 2021
automake is needed to build osslsigncode otherwise autogen.sh fails. Github-Pull: #18598 Rebased-From: e44aeef
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
automake is needed to build osslsigncode otherwise autogen.sh fails with the docker virtualization method.