[0.20] rc2 Backports #18748
Merged
[0.20] rc2 Backports #18748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
automake is needed to build osslsigncode otherwise autogen.sh fails. Github-Pull: bitcoin#18598 Rebased-From: e44aeef
Github-Pull: bitcoin#18553 Rebased-From: 8508473
Github-Pull: bitcoin#18676 Rebased-From: b68e717
ASLR is not currently working for the bitcoin-cli.exe binary. This is due to it not having a .reloc section, which is stripped by default by the mingw-w64 ld we use for gitian builds. A good summary of issues with ld and mingw-w64 is available in this thread: https://sourceware.org/bugzilla/show_bug.cgi?id=19011. All other Windows binaries that we distribute (bitcoind, bitcoin-qt, bitcoin-wallet, bitcoin-tx and test_bitcoin) do not suffer this issue, and currently having working ASLR. This is due to them exporting (inadvertent or not) libsecp256k1 symbols, and, as a result, the .reloc section is not stripped by ld. This change is a temporary workaround, also the same one described here: https://www.kb.cert.org/vuls/id/307144/, that causes main() to be exported. Exporting a symbol will mean that the .reloc section is not stripped, and ASLR will function correctly. Github-Pull: bitcoin#18702 Rebased-From: 315a4d3
Github-Pull: bitcoin#18665 Rebased-From: b91e4ae
Github-Pull: bitcoin#18589 Rebased-From: eb37275
|
There will be a few more backports, so I suggest piling them all up here and do one merge for rc2. |
That was the intent |
Github-Pull: bitcoin#18809 Rebased-From: fac0cf6
|
ACK 7f7548d It looks like 0.20.0 ran out of steam, to keep things moving a bit I'm going to merge this now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently backports the following to the 0.20 branch: