build: remove double LIBBITCOIN_SERVER from bench-Makefile #18429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Concept ACK |
|
Code Review ACK 1f97b69 |
|
ACK unless someone sees a reason why this would break in certain untested environments. |
Gitian builds
|
hebasto
approved these changes
Mar 26, 2020
theStack
approved these changes
Mar 26, 2020
MarkLTZ
added a commit
to litecoinz-core/litecoinz
that referenced
this pull request
Mar 27, 2020
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Mar 28, 2020
…h-Makefile 1f97b69 build: remove double LIBBITCOIN_SERVER from bench-Makefile (Harris) Pull request description: This PR removes the redundant **LIBBITCOIN_SERVER** linking from bench's Makefile. This PR is similar to bitcoin#17910 Originally, this PR was part of bitcoin#18377, which later got replaced by a better one bitcoin#18397 written by **hebasto**. ACKs for top commit: Empact: Code Review ACK bitcoin@1f97b69 theStack: ACK bitcoin@1f97b69 hebasto: ACK 1f97b69 Tree-SHA512: e43035262361d4458a7dcfc920445540f19301387814cde1be0539c936fc20da0dcbe49e5ea25385e6d36d9639515b7a4171228223da568d93427e9c32810945
MarkLTZ
added a commit
to litecoinz-core/litecoinz
that referenced
this pull request
Apr 6, 2020
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Nov 1, 2021
…h-Makefile 1f97b69 build: remove double LIBBITCOIN_SERVER from bench-Makefile (Harris) Pull request description: This PR removes the redundant **LIBBITCOIN_SERVER** linking from bench's Makefile. This PR is similar to bitcoin#17910 Originally, this PR was part of bitcoin#18377, which later got replaced by a better one bitcoin#18397 written by **hebasto**. ACKs for top commit: Empact: Code Review ACK bitcoin@1f97b69 theStack: ACK bitcoin@1f97b69 hebasto: ACK 1f97b69 Tree-SHA512: e43035262361d4458a7dcfc920445540f19301387814cde1be0539c936fc20da0dcbe49e5ea25385e6d36d9639515b7a4171228223da568d93427e9c32810945
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Dec 22, 2021
…h-Makefile 1f97b69 build: remove double LIBBITCOIN_SERVER from bench-Makefile (Harris) Pull request description: This PR removes the redundant **LIBBITCOIN_SERVER** linking from bench's Makefile. This PR is similar to bitcoin#17910 Originally, this PR was part of bitcoin#18377, which later got replaced by a better one bitcoin#18397 written by **hebasto**. ACKs for top commit: Empact: Code Review ACK bitcoin@1f97b69 theStack: ACK bitcoin@1f97b69 hebasto: ACK 1f97b69 Tree-SHA512: e43035262361d4458a7dcfc920445540f19301387814cde1be0539c936fc20da0dcbe49e5ea25385e6d36d9639515b7a4171228223da568d93427e9c32810945
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Dec 22, 2021
…h-Makefile 1f97b69 build: remove double LIBBITCOIN_SERVER from bench-Makefile (Harris) Pull request description: This PR removes the redundant **LIBBITCOIN_SERVER** linking from bench's Makefile. This PR is similar to bitcoin#17910 Originally, this PR was part of bitcoin#18377, which later got replaced by a better one bitcoin#18397 written by **hebasto**. ACKs for top commit: Empact: Code Review ACK bitcoin@1f97b69 theStack: ACK bitcoin@1f97b69 hebasto: ACK 1f97b69 Tree-SHA512: e43035262361d4458a7dcfc920445540f19301387814cde1be0539c936fc20da0dcbe49e5ea25385e6d36d9639515b7a4171228223da568d93427e9c32810945
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the redundant LIBBITCOIN_SERVER linking from bench's Makefile.
This PR is similar to #17910
Originally, this PR was part of #18377, which later got replaced by a better one #18397 written by hebasto.