build: fix libevent linking errors for bench-only builds #18377
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsNo conflicts as of last run. |
|
ACK 4f20bcb code review + built locally before and after on Mac |
laanwj
reviewed
Mar 19, 2020
Gitian builds
|
Gitian builds
|
|
Please look into #18397. |
|
@hebasto , Thanks. Should I close this PR then? |
|
Yes, lets use the approach in #18397. Some of your changes are included there as well. |
Btw. I will open a new PR regarding the double $(LIBBITCOIN_SERVER). |
fanquake
added a commit
that referenced
this pull request
Mar 26, 2020
cd04286 build: Fix typo in EVENT_CFLAGS variable (Hennadii Stepanov) f709ad0 build: Fix libevent linking for bench_bitcoin binary (Hennadii Stepanov) Pull request description: This change fixes `libevent` linking error for the `bench_bitcoin` binary. This PR is an alternative to #18377. Fix #18373. Also fixed a typo in `EVENT_CFLAGS` variable noted by **brakmic**. ACKs for top commit: fanquake: ACK cd04286 Tree-SHA512: a62f7457e86b11d3a55d603ea5d83f3a413792e2f28a0c72300e54d12591bd6f0acc1d76a4bd4b591e0223bc6d530e7a4b9a8b939fe2fdbf2dddfda5b1b537be
fanquake
added a commit
that referenced
this pull request
Mar 26, 2020
1f97b69 build: remove double LIBBITCOIN_SERVER from bench-Makefile (Harris) Pull request description: This PR removes the redundant **LIBBITCOIN_SERVER** linking from bench's Makefile. This PR is similar to #17910 Originally, this PR was part of #18377, which later got replaced by a better one #18397 written by **hebasto**. ACKs for top commit: Empact: Code Review ACK 1f97b69 theStack: ACK 1f97b69 hebasto: ACK 1f97b69 Tree-SHA512: e43035262361d4458a7dcfc920445540f19301387814cde1be0539c936fc20da0dcbe49e5ea25385e6d36d9639515b7a4171228223da568d93427e9c32810945
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Mar 28, 2020
…nary cd04286 build: Fix typo in EVENT_CFLAGS variable (Hennadii Stepanov) f709ad0 build: Fix libevent linking for bench_bitcoin binary (Hennadii Stepanov) Pull request description: This change fixes `libevent` linking error for the `bench_bitcoin` binary. This PR is an alternative to bitcoin#18377. Fix bitcoin#18373. Also fixed a typo in `EVENT_CFLAGS` variable noted by **brakmic**. ACKs for top commit: fanquake: ACK cd04286 Tree-SHA512: a62f7457e86b11d3a55d603ea5d83f3a413792e2f28a0c72300e54d12591bd6f0acc1d76a4bd4b591e0223bc6d530e7a4b9a8b939fe2fdbf2dddfda5b1b537be
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Mar 28, 2020
…h-Makefile 1f97b69 build: remove double LIBBITCOIN_SERVER from bench-Makefile (Harris) Pull request description: This PR removes the redundant **LIBBITCOIN_SERVER** linking from bench's Makefile. This PR is similar to bitcoin#17910 Originally, this PR was part of bitcoin#18377, which later got replaced by a better one bitcoin#18397 written by **hebasto**. ACKs for top commit: Empact: Code Review ACK bitcoin@1f97b69 theStack: ACK bitcoin@1f97b69 hebasto: ACK 1f97b69 Tree-SHA512: e43035262361d4458a7dcfc920445540f19301387814cde1be0539c936fc20da0dcbe49e5ea25385e6d36d9639515b7a4171228223da568d93427e9c32810945
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Nov 1, 2021
…h-Makefile 1f97b69 build: remove double LIBBITCOIN_SERVER from bench-Makefile (Harris) Pull request description: This PR removes the redundant **LIBBITCOIN_SERVER** linking from bench's Makefile. This PR is similar to bitcoin#17910 Originally, this PR was part of bitcoin#18377, which later got replaced by a better one bitcoin#18397 written by **hebasto**. ACKs for top commit: Empact: Code Review ACK bitcoin@1f97b69 theStack: ACK bitcoin@1f97b69 hebasto: ACK 1f97b69 Tree-SHA512: e43035262361d4458a7dcfc920445540f19301387814cde1be0539c936fc20da0dcbe49e5ea25385e6d36d9639515b7a4171228223da568d93427e9c32810945
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Dec 22, 2021
…h-Makefile 1f97b69 build: remove double LIBBITCOIN_SERVER from bench-Makefile (Harris) Pull request description: This PR removes the redundant **LIBBITCOIN_SERVER** linking from bench's Makefile. This PR is similar to bitcoin#17910 Originally, this PR was part of bitcoin#18377, which later got replaced by a better one bitcoin#18397 written by **hebasto**. ACKs for top commit: Empact: Code Review ACK bitcoin@1f97b69 theStack: ACK bitcoin@1f97b69 hebasto: ACK 1f97b69 Tree-SHA512: e43035262361d4458a7dcfc920445540f19301387814cde1be0539c936fc20da0dcbe49e5ea25385e6d36d9639515b7a4171228223da568d93427e9c32810945
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Dec 22, 2021
…h-Makefile 1f97b69 build: remove double LIBBITCOIN_SERVER from bench-Makefile (Harris) Pull request description: This PR removes the redundant **LIBBITCOIN_SERVER** linking from bench's Makefile. This PR is similar to bitcoin#17910 Originally, this PR was part of bitcoin#18377, which later got replaced by a better one bitcoin#18397 written by **hebasto**. ACKs for top commit: Empact: Code Review ACK bitcoin@1f97b69 theStack: ACK bitcoin@1f97b69 hebasto: ACK 1f97b69 Tree-SHA512: e43035262361d4458a7dcfc920445540f19301387814cde1be0539c936fc20da0dcbe49e5ea25385e6d36d9639515b7a4171228223da568d93427e9c32810945
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the linking errors for bench-only builds by adding a -levent flag to EVENT_LIBS.
Additionally, it fixes a typo in $(EVENT_CFLAGS) and removes the double $(LIBBITCOIN_SERVER) linking entry, because a similar one was also fixed in the Makefile.am: #17910
Fixes #18373