tests: Add fuzzing harnesses for functions in addrdb.h, net_permissions.h and timedata.h #18417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maflcko
reviewed
Mar 24, 2020
| (void)median_filter.median(); | ||
| assert(median_filter.size() > 0); | ||
| assert(static_cast<size_t>(median_filter.size()) == median_filter.sorted().size()); | ||
| assert(static_cast<unsigned int>(median_filter.size()) <= max_size || max_size == 0); |
There was a problem hiding this comment.
Why is this needed?
Suggested change
| assert(static_cast<unsigned int>(median_filter.size()) <= max_size || max_size == 0); | |
| assert(static_cast<unsigned int>(median_filter.size()) <= max_size); |
There was a problem hiding this comment.
It is needed since max_size == 0 means unbounded size as CMedianFilter is currently implemented :)
39d387e to
4308aa6
Compare
maflcko
reviewed
Mar 24, 2020
| } | ||
| return CBanEntry{}; | ||
| }(); | ||
| assert(!ban_entry.banReasonToString().empty()); |
There was a problem hiding this comment.
Would it make sense to also add an AssertEqualAfterSerializeDeserialize here?
There was a problem hiding this comment.
I'm afraid equality is not defined for CBanEntry. That goes for quite a few of our classes :)
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Aug 6, 2020
…data.h Summary: bitcoin/bitcoin@43ff0d9 --- Depends on D7133 Partial backport of Core [[bitcoin/bitcoin#18417 | PR18417]] Test Plan: cmake -GNinja .. -DENABLE_SANITIZERS="address;fuzzer" -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ ninja bitcoin-fuzzers ./src/test/fuzz/timedata Reviewers: #bitcoin_abc, jasonbcox Reviewed By: #bitcoin_abc, jasonbcox Differential Revision: https://reviews.bitcoinabc.org/D7134
jasonbcox
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Aug 6, 2020
…permissions.h Summary: bitcoin/bitcoin@4308aa6 --- Depends on D7134 Concludes backport of Core [[bitcoin/bitcoin#18417 | PR18417]] Test Plan: cmake -GNinja .. -DENABLE_SANITIZERS="address;fuzzer" -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ ninja bitcoin-fuzzers ./src/test/fuzz/net_permissions Reviewers: #bitcoin_abc, jasonbcox Reviewed By: #bitcoin_abc, jasonbcox Differential Revision: https://reviews.bitcoinabc.org/D7135
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
May 7, 2022
… net_permissions.h and timedata.h
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
May 7, 2022
… net_permissions.h and timedata.h
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jun 14, 2022
… net_permissions.h and timedata.h
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jun 14, 2022
… net_permissions.h and timedata.h
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jun 18, 2022
… net_permissions.h and timedata.h
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jul 4, 2022
… net_permissions.h and timedata.h
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jul 6, 2022
… net_permissions.h and timedata.h
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jul 6, 2022
… net_permissions.h and timedata.h
PastaPastaPasta
added a commit
to dashpay/dash
that referenced
this pull request
Jul 12, 2022
backport: bitcoin#18417, bitcoin#18521, bitcoin#18529, bitcoin#18176, bitcoin#18423, bitcoin#17926, bitcoin#18353, bitcoin#18407, bitcoin#18455, bitcoin#18565, bitcoin#18867 (fuzzing harness backports: part 2)
knst
pushed a commit
to knst/dash
that referenced
this pull request
Jul 21, 2022
… net_permissions.h and timedata.h
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add fuzzing harnesses for functions in
addrdb.h,net_permissions.handtimedata.h.