-
Notifications
You must be signed in to change notification settings - Fork 37.8k
tests: Add fuzzing harness for CScript and CScriptNum operations #18176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1996425
to
0730ac9
Compare
ACK 0730ac9 |
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsNo conflicts as of last run. |
e2fb330
to
ab67715
Compare
@MarcoFalke Added |
ab67715
to
1be90b4
Compare
1be90b4
to
f137f64
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
f137f64
to
7d27b9f
Compare
@MarcoFalke Thanks for reviewing. All feedback addressed. Please re-review :) |
7d27b9f
to
ad040fc
Compare
Rebased again :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK ad040fc 👦
Show signature and timestamp
Signature:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
ACK ad040fc2a503a0a5c7097dfe8aa6d341901436d9 👦
-----BEGIN PGP SIGNATURE-----
iQGzBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p
pUgKHwv+OE49ZDbtGMchMWXzOuFyxStj7biNTlNtYQH2AIBvgxPl2zZbczejRMMA
xbUrKDh3SiE+mzPNyzOZ69XejxNGCTX1Kfel22F/XIwbKDw2kFv0v1F39pYyp4ZV
j7/CLVpqZaWdgqcdFvE5tYCBcflm/6bU95TabNkv3yjsZ0XEy7WGaGJTRsgeMoQd
wHIOc6kZerms8G04U/84PtHJBO4x0pU4zk2PRiEv9IcYYkAUFh1NDgIoJ+8MH9bt
uuSjVmOzKmbuc5mrq8VFbvgeHJlIBWtjNP7Ux2OkvUCxGeUDoMOluO4MlME/tZVQ
VJAQ6ZdOHSp032e5aOs9A9rwU+S6SlGxuoBlrjvK5vZm/nTwM8QXTU+hgza8hcdj
7IWPhHIFiEExdYRd31q/aZ7kU4fpp9GaD4jXq+5hiAFso2jkWTxAIH3sdIn0ilKp
+XxdLNNDSevd2KlCZK/DiwtTvU/Hp6WDPG9JW1YG0DS6jV1VeDmoacoN5M1hMYQz
8kqbBKQP
=dRzS
-----END PGP SIGNATURE-----
Timestamp of file with hash 009db7b3b5d4284568143d3ed9fcbb2849ef578b5853b7f040cd0dd8c4f64f5f -
ad040fc
to
e37f536
Compare
ACK e37f536 🦂 Show signature and timestampSignature:
Timestamp of file with hash |
…ptNum operations e37f536 Make lifetime correctness easier to see (avoid reference lifetime extension) (practicalswift) e7ddbd9 tests: Add fuzzing harness for CScriptNum operations (practicalswift) 65a52a0 tests: Add fuzzing harness for CScript operations (practicalswift) eb7c50c tests: Add common Consume* fuzzing functions (practicalswift) Pull request description: Add fuzzing harness for `CScript` and `CScriptNum` operations. Test this PR using: ``` $ make distclean $ ./autogen.sh $ CC=clang CXX=clang++ ./configure --enable-fuzz \ --with-sanitizers=address,fuzzer,undefined $ make $ src/test/fuzz/script_ops … $ src/test/fuzz/scriptnum_ops … ``` ACKs for top commit: MarcoFalke: ACK e37f536 🦂 Tree-SHA512: 5165d918ffe3f1e3e85ab0e61d8b05934f682d324cf63ce188da5890899df2b5727aba9ed10c0437260ecff8055250e60c79d81d764bc740a7652d543a7c5fa3
…ptNum operations e37f536 Make lifetime correctness easier to see (avoid reference lifetime extension) (practicalswift) e7ddbd9 tests: Add fuzzing harness for CScriptNum operations (practicalswift) 65a52a0 tests: Add fuzzing harness for CScript operations (practicalswift) eb7c50c tests: Add common Consume* fuzzing functions (practicalswift) Pull request description: Add fuzzing harness for `CScript` and `CScriptNum` operations. Test this PR using: ``` $ make distclean $ ./autogen.sh $ CC=clang CXX=clang++ ./configure --enable-fuzz \ --with-sanitizers=address,fuzzer,undefined $ make $ src/test/fuzz/script_ops … $ src/test/fuzz/scriptnum_ops … ``` ACKs for top commit: MarcoFalke: ACK e37f536 🦂 Tree-SHA512: 5165d918ffe3f1e3e85ab0e61d8b05934f682d324cf63ce188da5890899df2b5727aba9ed10c0437260ecff8055250e60c79d81d764bc740a7652d543a7c5fa3
Summary: ``` Add fuzzing harness for CScript and CScriptNum operations. ``` Backport of core [[bitcoin/bitcoin#18176 | PR18176]]. Test Plan: ninja bitcoin-fuzzers ./test/fuzz/test_runner.py <path_to_corpus> Reviewers: #bitcoin_abc, PiRK Reviewed By: #bitcoin_abc, PiRK Differential Revision: https://reviews.bitcoinabc.org/D8959
backport: bitcoin#18417, bitcoin#18521, bitcoin#18529, bitcoin#18176, bitcoin#18423, bitcoin#17926, bitcoin#18353, bitcoin#18407, bitcoin#18455, bitcoin#18565, bitcoin#18867 (fuzzing harness backports: part 2)
Add fuzzing harness for
CScript
andCScriptNum
operations.Test this PR using: