Skip to content

Conversation

practicalswift
Copy link
Contributor

@practicalswift practicalswift commented Feb 18, 2020

Add fuzzing harness for CScript and CScriptNum operations.

Test this PR using:

$ make distclean
$ ./autogen.sh
$ CC=clang CXX=clang++ ./configure --enable-fuzz \
      --with-sanitizers=address,fuzzer,undefined
$ make
$ src/test/fuzz/script_ops
…
$ src/test/fuzz/scriptnum_ops
…

@maflcko
Copy link
Member

maflcko commented Feb 18, 2020

ACK 0730ac9

@DrahtBot
Copy link
Contributor

DrahtBot commented Feb 18, 2020

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

No conflicts as of last run.

@practicalswift practicalswift force-pushed the fuzzers-script_ops branch 2 times, most recently from e2fb330 to ab67715 Compare February 19, 2020 16:51
@practicalswift practicalswift changed the title tests: Add fuzzing harness for CScript operations tests: Add fuzzing harness for CScript and CScriptNum operations Feb 19, 2020
@practicalswift
Copy link
Contributor Author

@MarcoFalke Added CScriptNum fuzzer too. Moved common functions to fuzz.h. Please re-review :)

Copy link
Member

@maflcko maflcko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@practicalswift
Copy link
Contributor Author

@MarcoFalke Thanks for reviewing. All feedback addressed. Please re-review :)

@practicalswift
Copy link
Contributor Author

Rebased again :)

Copy link
Member

@maflcko maflcko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK ad040fc 👦

Show signature and timestamp

Signature:

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

ACK ad040fc2a503a0a5c7097dfe8aa6d341901436d9 👦
-----BEGIN PGP SIGNATURE-----

iQGzBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p
pUgKHwv+OE49ZDbtGMchMWXzOuFyxStj7biNTlNtYQH2AIBvgxPl2zZbczejRMMA
xbUrKDh3SiE+mzPNyzOZ69XejxNGCTX1Kfel22F/XIwbKDw2kFv0v1F39pYyp4ZV
j7/CLVpqZaWdgqcdFvE5tYCBcflm/6bU95TabNkv3yjsZ0XEy7WGaGJTRsgeMoQd
wHIOc6kZerms8G04U/84PtHJBO4x0pU4zk2PRiEv9IcYYkAUFh1NDgIoJ+8MH9bt
uuSjVmOzKmbuc5mrq8VFbvgeHJlIBWtjNP7Ux2OkvUCxGeUDoMOluO4MlME/tZVQ
VJAQ6ZdOHSp032e5aOs9A9rwU+S6SlGxuoBlrjvK5vZm/nTwM8QXTU+hgza8hcdj
7IWPhHIFiEExdYRd31q/aZ7kU4fpp9GaD4jXq+5hiAFso2jkWTxAIH3sdIn0ilKp
+XxdLNNDSevd2KlCZK/DiwtTvU/Hp6WDPG9JW1YG0DS6jV1VeDmoacoN5M1hMYQz
8kqbBKQP
=dRzS
-----END PGP SIGNATURE-----

Timestamp of file with hash 009db7b3b5d4284568143d3ed9fcbb2849ef578b5853b7f040cd0dd8c4f64f5f -

@maflcko
Copy link
Member

maflcko commented Mar 10, 2020

ACK e37f536 🦂

Show signature and timestamp

Signature:

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

ACK e37f53648e3acc6aea75adafec4de2bdbd8cb293 🦂
-----BEGIN PGP SIGNATURE-----

iQGzBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p
pUiTxwv/fFqtr5Cy14W/HZr4I58Tpz3S86mobLUDaulSWhFpMz8b38ilBC5ltwIH
rOznRDmgl46dP3YPMU07vCM2LS39DZyQH8uLTbECZw1aP5/x+XHb7me4aN/Ws1hB
tvD5zKvFcFnw+wbmkStYqDMaNKH2vFOSJKhWckcRouaB+fwZLNMzps1CH7tqixVg
Yo6i/PfETRSK9FveNFzbhSvhpGozLuFkqr0p5XyVWG42DxyOfe61VJP+e5RtlUFb
QUPiEZnm2UFgy3DFhPGw0y2Gz81kDvW5H3RD+nKxg2FmXeBuQlNpos/naAqq1pQ1
WsNtbwzJw5mrvxWvtALFFzvkBOv1W7kjes987ojGLQscMCtb1N/ZTb81sUSRzkW/
L5AkNgnyP8d6WFvzuztTgLt7ZxM/0hTJtIO3x1qC/VySZKR2Enhh/DrOACKQ8u0s
x3uTHh0e4qcOMz/6gKlMO2Boq48EUmUTNOSNY/95XY+0A5J7c6v6NuFIvhHq8Jfj
1N+3Xt0G
=AMUq
-----END PGP SIGNATURE-----

Timestamp of file with hash de3f5a712c02cb66b6ad6e76c0ec5a38c880d09962e085e811ec889daf153c65 -

@maflcko maflcko merged commit 6fb4bbf into bitcoin:master Mar 10, 2020
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Mar 11, 2020
…ptNum operations

e37f536 Make lifetime correctness easier to see (avoid reference lifetime extension) (practicalswift)
e7ddbd9 tests: Add fuzzing harness for CScriptNum operations (practicalswift)
65a52a0 tests: Add fuzzing harness for CScript operations (practicalswift)
eb7c50c tests: Add common Consume* fuzzing functions (practicalswift)

Pull request description:

  Add fuzzing harness for `CScript` and `CScriptNum` operations.

  Test this PR using:

  ```
  $ make distclean
  $ ./autogen.sh
  $ CC=clang CXX=clang++ ./configure --enable-fuzz \
        --with-sanitizers=address,fuzzer,undefined
  $ make
  $ src/test/fuzz/script_ops
  …
  $ src/test/fuzz/scriptnum_ops
  …
  ```

ACKs for top commit:
  MarcoFalke:
    ACK e37f536 🦂

Tree-SHA512: 5165d918ffe3f1e3e85ab0e61d8b05934f682d324cf63ce188da5890899df2b5727aba9ed10c0437260ecff8055250e60c79d81d764bc740a7652d543a7c5fa3
sidhujag pushed a commit to syscoin-core/syscoin that referenced this pull request Nov 10, 2020
…ptNum operations

e37f536 Make lifetime correctness easier to see (avoid reference lifetime extension) (practicalswift)
e7ddbd9 tests: Add fuzzing harness for CScriptNum operations (practicalswift)
65a52a0 tests: Add fuzzing harness for CScript operations (practicalswift)
eb7c50c tests: Add common Consume* fuzzing functions (practicalswift)

Pull request description:

  Add fuzzing harness for `CScript` and `CScriptNum` operations.

  Test this PR using:

  ```
  $ make distclean
  $ ./autogen.sh
  $ CC=clang CXX=clang++ ./configure --enable-fuzz \
        --with-sanitizers=address,fuzzer,undefined
  $ make
  $ src/test/fuzz/script_ops
  …
  $ src/test/fuzz/scriptnum_ops
  …
  ```

ACKs for top commit:
  MarcoFalke:
    ACK e37f536 🦂

Tree-SHA512: 5165d918ffe3f1e3e85ab0e61d8b05934f682d324cf63ce188da5890899df2b5727aba9ed10c0437260ecff8055250e60c79d81d764bc740a7652d543a7c5fa3
Fabcien pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Jan 19, 2021
Summary:
```
Add fuzzing harness for CScript and CScriptNum operations.
```

Backport of core [[bitcoin/bitcoin#18176 | PR18176]].

Test Plan:
  ninja bitcoin-fuzzers
  ./test/fuzz/test_runner.py <path_to_corpus>

Reviewers: #bitcoin_abc, PiRK

Reviewed By: #bitcoin_abc, PiRK

Differential Revision: https://reviews.bitcoinabc.org/D8959
@practicalswift practicalswift deleted the fuzzers-script_ops branch April 10, 2021 19:40
kwvg added a commit to kwvg/dash that referenced this pull request May 7, 2022
kwvg added a commit to kwvg/dash that referenced this pull request May 7, 2022
kwvg added a commit to kwvg/dash that referenced this pull request Jun 14, 2022
kwvg added a commit to kwvg/dash that referenced this pull request Jun 14, 2022
kwvg added a commit to kwvg/dash that referenced this pull request Jun 18, 2022
kwvg added a commit to kwvg/dash that referenced this pull request Jul 4, 2022
kwvg added a commit to kwvg/dash that referenced this pull request Jul 4, 2022
kwvg added a commit to kwvg/dash that referenced this pull request Jul 6, 2022
kwvg added a commit to kwvg/dash that referenced this pull request Jul 6, 2022
knst pushed a commit to knst/dash that referenced this pull request Jul 21, 2022
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants