Load vcpkg port files from a separate repository. #17995
Conversation
Prior to this change the vcpkg port files were taken directly from the main vcpkg repository. This results in a dependency changing from time-to-time and breaking the Bitcoin Core build. This change places the port files in a separate repository where they and the dependencies they install will only be updated when necessary.
|
@sipsorcery why not just using a specific commit of vcpkg instead? |
That's also an option. Doesn't give the same flexibility though. We may want to update the versions of different dependencies separately. If we reference a vcpkg commit then we're tied to the specific combination of port files in it. That being said using a vcpkg commit reference should fix the original concern and be a lighter touch than the separate repo approach used in this PR. I think either approach would be fine and don't have strong feelings as to which. |
|
I think just using a specific commit is easier to review (only one line adding the |
Agree with @NicolasDorier . We don't need the flexibility. All we need is packages not to randomly change from down under us. |
|
Closed in deference to #18001. |
…t ID 2bcc705 Updated appveyor job to checkout a specific vcpkg commit ID. (Aaron Clauson) Pull request description: This PR sets the vcpkg packages in stone by checking out a specific commit ID whenever they need to be reinstalled. The commit ID was chosen as the most recent commit at the time of this PR. As per discussion on #17995 (and prior PR's/issues). ACKs for top commit: fanquake: ACK 2bcc705 - thanks for trying/suggesting all the different approaches, however this looks like the way to go. Should prevent `vcpkg` packages from changing out from under us. Tree-SHA512: ced9c9c6df2287214a966d10110edda43a06380bae270a0d9ba1fd3dde48c27c109881423978e173b3e02512f6380600096b30510e90d37a6967fd8bf9186cb6
Prior to this change the vcpkg port files were taken directly from the main vcpkg repository. This results in a dependency changing from time-to-time and breaking the Bitcoin Core build.
This change places the port files in a separate repository where they and the dependencies they install will only be updated when necessary.
I've put the port files in a repository under my account. It's a one line change to the appveyor job to switch to a Bitcoin Core repository.
As discussed in #17976 and #17991.