Skip to content

Add vcpkg custom port files #17991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add vcpkg custom port files #17991

wants to merge 1 commit into from

Conversation

sipsorcery
Copy link
Contributor

@sipsorcery sipsorcery commented Jan 23, 2020 •
edited
Loading

The purpose is to allow control of the vcpkg package versions installed by the appveyor CI job. The main vcpkg port files change regularly and can potentially break the Bitcoin Core build.

  • Copies the current vcpkg port files required for Bitcoin Core dependencies.
  • Updates the appveyor CI job to use custom port files.

P.S. as discussed in #17976.

@sipsorcery
Add vcpkg custom port files
886f897 
The purpose is to allow control of the vcpkg package versions installed by the appveyor CI job. The main vcpkg port files change regularly and can potentially break the Bitcoin Core build.

- Copies the current vcpkg port files for Bitcoin Core dependencies.
- Updates the appveyor CI job to use custom port files.
@sipsorcery
Copy link
Contributor Author

I think the linter will need to be turned off for build_msvc\vcpkg-ports. Otherwise it will be a never ending task keeping the port files in sync with the main vcpkg repo.

Anyone know if I can and if so where I add a linter exclusion?

@maflcko
Copy link
Member

maflcko commented Jan 23, 2020

See test/lint/lint-whitespace.sh

@laanwj
Copy link
Member

laanwj commented Jan 23, 2020

Concept ACK, but adding 335 files to the repository is a bit too much, IMO. I'm not sure it is good to add that to the maintenance bottleneck. Should we create a new repo for this?

@sipsorcery
Copy link
Contributor Author

+1 for a separate repo.

@fanquake
Copy link
Member

Concept ACK, but adding 335 files to the repository is a bit too much, IMO. I'm not sure it is good to add that to the maintenance bottleneck. Should we create a new repo for this?

+1 for a separate repo. I'd rather remove build_msvc/ and appveyor.yml from this repository then have to add ~300 files just to try and pin some dependencies.

@sipsorcery
Copy link
Contributor Author

I'd rather remove build_msvc/ and appveyor.yml from this repository then have to add ~300 files just to try and pin some dependencies.

Only the port files need to be put in a separate repo. The existing build_msvc directory can stay as is.

I'll create a repo on my account to demonstrate how it works. It can be switched over to a Bitcoin Core repo afterwards if that's deemed appropriate.

@sipsorcery sipsorcery closed this Jan 24, 2020
@sipsorcery sipsorcery mentioned this pull request Jan 24, 2020
Closed
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Tests Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sipsorcery @maflcko @laanwj @fanquake