build: Included test_bitcoin-qt in msvc build #17741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on task. Otherwise it doesn't get run.
|
Concept ACK |
maflcko
pushed a commit
that referenced
this pull request
Dec 30, 2019
592af5a Moved the include of the system projects to before the build depends on task. Otherwise it doesn't get run. (Aaron Clauson) 6e22151 Included test_bitcoin-qt in msvc build. (Aaron Clauson) Pull request description: This PR includes the `test_bitcoin-qt` project in the msvc build. The project is already in the repo but is not part of the solution and therefore does not get built. The test executable output from this project does not pass successfully on Windows (it may never have). This PR only builds the project and does not add a step to execute the tests. MarcoFalke mentioned the fact that it's missing in #17571. Top commit has no ACKs. Tree-SHA512: ebb8fc7710022b995e842708bbf83b9c0084dac5e1a22fa3f53d9ea472faabe96d75ad53150cc915ded5f782515a896f2b60840390bde38c1d0f80d0fd56a4ea
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jan 2, 2020
592af5a Moved the include of the system projects to before the build depends on task. Otherwise it doesn't get run. (Aaron Clauson) 6e22151 Included test_bitcoin-qt in msvc build. (Aaron Clauson) Pull request description: This PR includes the `test_bitcoin-qt` project in the msvc build. The project is already in the repo but is not part of the solution and therefore does not get built. The test executable output from this project does not pass successfully on Windows (it may never have). This PR only builds the project and does not add a step to execute the tests. MarcoFalke mentioned the fact that it's missing in bitcoin#17571. Top commit has no ACKs. Tree-SHA512: ebb8fc7710022b995e842708bbf83b9c0084dac5e1a22fa3f53d9ea472faabe96d75ad53150cc915ded5f782515a896f2b60840390bde38c1d0f80d0fd56a4ea
sidhujag
pushed a commit
to syscoin-core/syscoin
that referenced
this pull request
Nov 10, 2020
592af5a Moved the include of the system projects to before the build depends on task. Otherwise it doesn't get run. (Aaron Clauson) 6e22151 Included test_bitcoin-qt in msvc build. (Aaron Clauson) Pull request description: This PR includes the `test_bitcoin-qt` project in the msvc build. The project is already in the repo but is not part of the solution and therefore does not get built. The test executable output from this project does not pass successfully on Windows (it may never have). This PR only builds the project and does not add a step to execute the tests. MarcoFalke mentioned the fact that it's missing in bitcoin#17571. Top commit has no ACKs. Tree-SHA512: ebb8fc7710022b995e842708bbf83b9c0084dac5e1a22fa3f53d9ea472faabe96d75ad53150cc915ded5f782515a896f2b60840390bde38c1d0f80d0fd56a4ea
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the
test_bitcoin-qtproject in the msvc build. The project is already in the repo but is not part of the solution and therefore does not get built.The test executable output from this project does not pass successfully on Windows (it may never have). This PR only builds the project and does not add a step to execute the tests.
MarcoFalke mentioned the fact that it's missing in #17571.