Add libtest_util library to msvc build configuration #17571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
4d05360 to
1b8cc2e
Compare
msbuild /p:TrackFileAccess=false /p:CLToolExe=clcache.exe build_msvc\bitcoin.sln /m /v:q /nologo
bench_bench.obj : error LNK2001: unresolved external symbol "public: __cdecl TestingSetup::~TestingSetup(void)" (??1TestingSetup@@QEAA@XZ) [C:\projects\bitcoin\build_msvc\bench_bitcoin\bench_bitcoin.vcxproj]
bench_bench.obj : error LNK2001: unresolved external symbol "public: __cdecl TestingSetup::TestingSetup(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &)" (??0TestingSetup@@QEAA@AEBV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@Z) [C:\projects\bitcoin\build_msvc\bench_bitcoin\bench_bitcoin.vcxproj]
bench_verify_script.obj : error LNK2001: unresolved external symbol "struct CMutableTransaction __cdecl BuildSpendingTransaction(class CScript const &,struct CScriptWitness const &,class CTransaction const &)" (?BuildSpendingTransaction@@YA?AUCMutableTransaction@@AEBVCScript@@AEBUCScriptWitness@@AEBVCTransaction@@@Z) [C:\projects\bitcoin\build_msvc\bench_bitcoin\bench_bitcoin.vcxproj]
bench_verify_script.obj : error LNK2001: unresolved external symbol "struct CMutableTransaction __cdecl BuildCreditingTransaction(class CScript const &,int)" (?BuildCreditingTransaction@@YA?AUCMutableTransaction@@AEBVCScript@@H@Z) [C:\projects\bitcoin\build_msvc\bench_bitcoin\bench_bitcoin.vcxproj]
libbitcoin_server.lib(validation.obj) : error LNK2001: unresolved external symbol "class std::function<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl(char const *)> const G_TRANSLATION_FUN" (?G_TRANSLATION_FUN@@3V?$function@$$A6A?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@PEBD@Z@std@@B) [C:\projects\bitcoin\build_msvc\bench_bitcoin\bench_bitcoin.vcxproj]
C:\projects\bitcoin\build_msvc\x64\Release\bench_bitcoin.exe : fatal error LNK1120: 5 unresolved externals [C:\projects\bitcoin\build_msvc\bench_bitcoin\bench_bitcoin.vcxproj] |
1b8cc2e to
b509554
Compare
|
Appveyor should now pass. Ready for review. |
fanquake
added a commit
that referenced
this pull request
Nov 23, 2019
b509554 Added libtest_util library to msvc build configuration. (Aaron Clauson) Pull request description: libtest_util was introduced in #17542. This PR adds the msvc build configuration. ACKs for top commit: fanquake: ACK b509554 - Appveyor looks good. Tree-SHA512: abd9f8427375ae0e75e8227d853cccc666fd9e906038d97b787d9185dec1024232a6c64301e26e66fcaf86492183328abe4a7abd7af3321f062cd8722eb83b4c
|
Are the gui unit tests not built on appveyor? |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Nov 23, 2019
…tion b509554 Added libtest_util library to msvc build configuration. (Aaron Clauson) Pull request description: libtest_util was introduced in bitcoin#17542. This PR adds the msvc build configuration. ACKs for top commit: fanquake: ACK b509554 - Appveyor looks good. Tree-SHA512: abd9f8427375ae0e75e8227d853cccc666fd9e906038d97b787d9185dec1024232a6c64301e26e66fcaf86492183328abe4a7abd7af3321f062cd8722eb83b4c
|
@MarcoFalke there's no msbuild project for the Qt tests so they have never been built on appveyor. I don't think there's any reason they can't be built. I'll look into it. |
|
Interestingly, even though this build succeeded, the build on master did not |
|
Did the appveyor job fail at the test stage? I do get occasional failures on a python test. I haven't tracked down the culprit yet. All my appveyor builds on master since this PR have worked. |
maflcko
pushed a commit
that referenced
this pull request
Dec 30, 2019
592af5a Moved the include of the system projects to before the build depends on task. Otherwise it doesn't get run. (Aaron Clauson) 6e22151 Included test_bitcoin-qt in msvc build. (Aaron Clauson) Pull request description: This PR includes the `test_bitcoin-qt` project in the msvc build. The project is already in the repo but is not part of the solution and therefore does not get built. The test executable output from this project does not pass successfully on Windows (it may never have). This PR only builds the project and does not add a step to execute the tests. MarcoFalke mentioned the fact that it's missing in #17571. Top commit has no ACKs. Tree-SHA512: ebb8fc7710022b995e842708bbf83b9c0084dac5e1a22fa3f53d9ea472faabe96d75ad53150cc915ded5f782515a896f2b60840390bde38c1d0f80d0fd56a4ea
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jan 2, 2020
592af5a Moved the include of the system projects to before the build depends on task. Otherwise it doesn't get run. (Aaron Clauson) 6e22151 Included test_bitcoin-qt in msvc build. (Aaron Clauson) Pull request description: This PR includes the `test_bitcoin-qt` project in the msvc build. The project is already in the repo but is not part of the solution and therefore does not get built. The test executable output from this project does not pass successfully on Windows (it may never have). This PR only builds the project and does not add a step to execute the tests. MarcoFalke mentioned the fact that it's missing in bitcoin#17571. Top commit has no ACKs. Tree-SHA512: ebb8fc7710022b995e842708bbf83b9c0084dac5e1a22fa3f53d9ea472faabe96d75ad53150cc915ded5f782515a896f2b60840390bde38c1d0f80d0fd56a4ea
sidhujag
pushed a commit
to syscoin-core/syscoin
that referenced
this pull request
Nov 10, 2020
…tion b509554 Added libtest_util library to msvc build configuration. (Aaron Clauson) Pull request description: libtest_util was introduced in bitcoin#17542. This PR adds the msvc build configuration. ACKs for top commit: fanquake: ACK b509554 - Appveyor looks good. Tree-SHA512: abd9f8427375ae0e75e8227d853cccc666fd9e906038d97b787d9185dec1024232a6c64301e26e66fcaf86492183328abe4a7abd7af3321f062cd8722eb83b4c
sidhujag
pushed a commit
to syscoin-core/syscoin
that referenced
this pull request
Nov 10, 2020
592af5a Moved the include of the system projects to before the build depends on task. Otherwise it doesn't get run. (Aaron Clauson) 6e22151 Included test_bitcoin-qt in msvc build. (Aaron Clauson) Pull request description: This PR includes the `test_bitcoin-qt` project in the msvc build. The project is already in the repo but is not part of the solution and therefore does not get built. The test executable output from this project does not pass successfully on Windows (it may never have). This PR only builds the project and does not add a step to execute the tests. MarcoFalke mentioned the fact that it's missing in bitcoin#17571. Top commit has no ACKs. Tree-SHA512: ebb8fc7710022b995e842708bbf83b9c0084dac5e1a22fa3f53d9ea472faabe96d75ad53150cc915ded5f782515a896f2b60840390bde38c1d0f80d0fd56a4ea
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libtest_util was introduced in #17542. This PR adds the msvc build configuration.