depends: add ability to skip building zeromq #16089
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
utACK c995c87 Thanks for fixing this! |
|
Gitian builds for commit e043bfc (master):
Gitian builds for commit 3e4c44d (master and this pull):
|
|
Concept ACK |
dongcarl
reviewed
May 28, 2019
| @@ -103,6 +105,10 @@ ifneq ($(qt_packages_),) | |||
| native_packages += $(qt_native_packages) | |||
| endif | |||
|
|
|||
| ifneq ($(zmq_packages_),) | |||
There was a problem hiding this comment.
Would it work if you removed this ifneq and tacked $(zmp_packages_) on to the end of that long packages += line on line 101?
|
utACK c995c87 |
|
Tested ACK c995c87
Just for info, ARM executable size with/without zmq: |
pull bot
pushed a commit
to jaschadub/bitcoin
that referenced
this pull request
May 29, 2019
c995c87 depends: add ability to skip building zeromq (fanquake) Pull request description: Similar to other depends packages, add the ability to skip building `zeromq` by passing `NO_ZMQ=1`. Fixes bitcoin#15918. ACKs for commit c995c8: practicalswift: utACK c995c87 jonasschnelli: utACK c995c87 Tree-SHA512: 72269707916d5af0bc8ecdd89f61e49264dba29350f9508fe0a497e8ce8dae66f6a828cf0bf4d97b6f95356b505cb3e6c365e8476219dd56c4535c850df393c9
laanwj
added a commit
that referenced
this pull request
Dec 7, 2019
c8becb8 depends: add ability to skip building qrencode (fanquake) Pull request description: Similar to other depends packages, add the ability to skip building `qrencode` by passing `NO_QR=1`. Same as #16089. ACKs for top commit: promag: ACK c8becb8. hebasto: ACK c8becb8, I have reviewed the code and it looks OK, I agree it can be merged. Tree-SHA512: 86c7a87a31b1b2e65be2b79f533ce49f8b0074cf31331411cb3d32bb542d0b99e69605482ad75e4d1be5f2c8c613f17ba9ff17195a6b48f45365f5eb35df8bf9
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Dec 7, 2019
c8becb8 depends: add ability to skip building qrencode (fanquake) Pull request description: Similar to other depends packages, add the ability to skip building `qrencode` by passing `NO_QR=1`. Same as bitcoin#16089. ACKs for top commit: promag: ACK c8becb8. hebasto: ACK c8becb8, I have reviewed the code and it looks OK, I agree it can be merged. Tree-SHA512: 86c7a87a31b1b2e65be2b79f533ce49f8b0074cf31331411cb3d32bb542d0b99e69605482ad75e4d1be5f2c8c613f17ba9ff17195a6b48f45365f5eb35df8bf9
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Apr 1, 2020
Summary: ``` Similar to other depends packages, add the ability to skip building zeromq by passing NO_ZMQ=1. ``` Backport of core [[bitcoin/bitcoin#16089 | PR16089]]. Test Plan: cd depends make build-osx NO_ZMQ=1 Check zmq is not built (under `x86_64-apple-darwin16/lib` there should be no libzmq.a). Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D5620
ftrader
pushed a commit
to bitcoin-cash-node/bitcoin-cash-node
that referenced
this pull request
Aug 17, 2020
Summary: ``` Similar to other depends packages, add the ability to skip building zeromq by passing NO_ZMQ=1. ``` Backport of core [[bitcoin/bitcoin#16089 | PR16089]]. Test Plan: cd depends make build-osx NO_ZMQ=1 Check zmq is not built (under `x86_64-apple-darwin16/lib` there should be no libzmq.a). Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D5620
sidhujag
pushed a commit
to syscoin-core/syscoin
that referenced
this pull request
Nov 10, 2020
c8becb8 depends: add ability to skip building qrencode (fanquake) Pull request description: Similar to other depends packages, add the ability to skip building `qrencode` by passing `NO_QR=1`. Same as bitcoin#16089. ACKs for top commit: promag: ACK c8becb8. hebasto: ACK c8becb8, I have reviewed the code and it looks OK, I agree it can be merged. Tree-SHA512: 86c7a87a31b1b2e65be2b79f533ce49f8b0074cf31331411cb3d32bb542d0b99e69605482ad75e4d1be5f2c8c613f17ba9ff17195a6b48f45365f5eb35df8bf9
Munkybooty
pushed a commit
to Munkybooty/dash
that referenced
this pull request
Oct 17, 2021
c995c87 depends: add ability to skip building zeromq (fanquake) Pull request description: Similar to other depends packages, add the ability to skip building `zeromq` by passing `NO_ZMQ=1`. Fixes bitcoin#15918. ACKs for commit c995c8: practicalswift: utACK c995c87 jonasschnelli: utACK c995c87 Tree-SHA512: 72269707916d5af0bc8ecdd89f61e49264dba29350f9508fe0a497e8ce8dae66f6a828cf0bf4d97b6f95356b505cb3e6c365e8476219dd56c4535c850df393c9
Munkybooty
pushed a commit
to Munkybooty/dash
that referenced
this pull request
Oct 25, 2021
c995c87 depends: add ability to skip building zeromq (fanquake) Pull request description: Similar to other depends packages, add the ability to skip building `zeromq` by passing `NO_ZMQ=1`. Fixes bitcoin#15918. ACKs for commit c995c8: practicalswift: utACK c995c87 jonasschnelli: utACK c995c87 Tree-SHA512: 72269707916d5af0bc8ecdd89f61e49264dba29350f9508fe0a497e8ce8dae66f6a828cf0bf4d97b6f95356b505cb3e6c365e8476219dd56c4535c850df393c9
Munkybooty
pushed a commit
to Munkybooty/dash
that referenced
this pull request
Oct 26, 2021
c995c87 depends: add ability to skip building zeromq (fanquake) Pull request description: Similar to other depends packages, add the ability to skip building `zeromq` by passing `NO_ZMQ=1`. Fixes bitcoin#15918. ACKs for commit c995c8: practicalswift: utACK c995c87 jonasschnelli: utACK c995c87 Tree-SHA512: 72269707916d5af0bc8ecdd89f61e49264dba29350f9508fe0a497e8ce8dae66f6a828cf0bf4d97b6f95356b505cb3e6c365e8476219dd56c4535c850df393c9
Munkybooty
pushed a commit
to Munkybooty/dash
that referenced
this pull request
Oct 26, 2021
c995c87 depends: add ability to skip building zeromq (fanquake) Pull request description: Similar to other depends packages, add the ability to skip building `zeromq` by passing `NO_ZMQ=1`. Fixes bitcoin#15918. ACKs for commit c995c8: practicalswift: utACK c995c87 jonasschnelli: utACK c995c87 Tree-SHA512: 72269707916d5af0bc8ecdd89f61e49264dba29350f9508fe0a497e8ce8dae66f6a828cf0bf4d97b6f95356b505cb3e6c365e8476219dd56c4535c850df393c9
Munkybooty
pushed a commit
to Munkybooty/dash
that referenced
this pull request
Nov 9, 2021
c995c87 depends: add ability to skip building zeromq (fanquake) Pull request description: Similar to other depends packages, add the ability to skip building `zeromq` by passing `NO_ZMQ=1`. Fixes bitcoin#15918. ACKs for commit c995c8: practicalswift: utACK c995c87 jonasschnelli: utACK c995c87 Tree-SHA512: 72269707916d5af0bc8ecdd89f61e49264dba29350f9508fe0a497e8ce8dae66f6a828cf0bf4d97b6f95356b505cb3e6c365e8476219dd56c4535c850df393c9
pravblockc
pushed a commit
to pravblockc/dash
that referenced
this pull request
Nov 18, 2021
c995c87 depends: add ability to skip building zeromq (fanquake) Pull request description: Similar to other depends packages, add the ability to skip building `zeromq` by passing `NO_ZMQ=1`. Fixes bitcoin#15918. ACKs for commit c995c8: practicalswift: utACK c995c87 jonasschnelli: utACK c995c87 Tree-SHA512: 72269707916d5af0bc8ecdd89f61e49264dba29350f9508fe0a497e8ce8dae66f6a828cf0bf4d97b6f95356b505cb3e6c365e8476219dd56c4535c850df393c9
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to other depends packages, add the ability to skip building
zeromqby passingNO_ZMQ=1.Fixes #15918.