GUI: Move QRImageWidget to its own file-pair #15928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
concept ACK, though I'd prefer naming the pair |
|
Concept ACK |
|
The end goal is something like #15428 |
|
utACK fc92984 |
laanwj
added a commit
that referenced
this pull request
May 6, 2019
fc92984 GUI: Move QRImageWidget to its own file-pair (Luke Dashjr) 77851ab GUI: Refactor actual QR code rendering into new QRImageWidget::setQR (Luke Dashjr) Pull request description: For at least QR-code based pairing of mobile wallets with nodes, it will be desirable to render QR codes even without wallet support. Therefore, this prepares by moving the QRImageWidget out of a wallet-specific file into its own `qrencoder` file-pair. ACKs for commit fc9298: laanwj: utACK fc92984 jonasschnelli: utACK fc92984 Tree-SHA512: 95529a38c0573a4b3f1253fb5f11ca07a5b3a9840ec24acc7d87270212f3c9f7c5b186d9274d297517a3b80494f38a57574fb9730b1574db01688539b987bd91
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Oct 8, 2020
Summary: Pull request description: >For at least QR-code based pairing of mobile wallets with nodes, it will be desirable to render QR codes even without wallet support. > >Therefore, this prepares by moving the QRImageWidget out of a wallet-specific file into its own qrencoder file-pair. This is part 1 of 2 of backport of Core [[bitcoin/bitcoin#15928 | PR15928]] Commit [[bitcoin/bitcoin@77851ab | 77851ab6]] Test Plan: `ninja && ninja check && sudo ninja install` Run bitcoin-qt and make sure the QR code is still generated properly. Reviewers: O1 Bitcoin ABC, #bitcoin_abc, deadalnix Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, deadalnix Subscribers: deadalnix Differential Revision: https://reviews.bitcoinabc.org/D7783
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Oct 8, 2020
Summary: Commit [[bitcoin/bitcoin@fc92984 | fc929842]] This concludes backport of Core [[bitcoin/bitcoin#15928 | PR15928]] Depends on D7783 Test Plan: `ninja && ninja check && sudo ninja install` Run bitcoin-qt and make sure the QR code is still generated properly. Reviewers: O1 Bitcoin ABC, #bitcoin_abc, Fabien Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, Fabien Subscribers: Fabien Differential Revision: https://reviews.bitcoinabc.org/D7794
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Nov 6, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Dec 5, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Dec 5, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Dec 12, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Dec 12, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Dec 12, 2021
PastaPastaPasta
added a commit
to dashpay/dash
that referenced
this pull request
Dec 12, 2021
merge bitcoin#15928...bitcoin#16984: backports
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For at least QR-code based pairing of mobile wallets with nodes, it will be desirable to render QR codes even without wallet support.
Therefore, this prepares by moving the QRImageWidget out of a wallet-specific file into its own
qrencoderfile-pair.