[WIP] GUI: Add Pairing tab with Tor onion address as copyable text and QR code #15428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7203344 to
bd4b911
Compare
bd4b911 to
9a3d852
Compare
|
I think I need to rewrite this to work sanely with no-wallet builds. :/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to be merged only once the node can reliably provide a Tor hidden service for inbound connections.
It adds a "Pairing" tab to the GUI, which displays the onion address as copyable text, and a QR code (for scanning by mobile wallets).
TODO: Probably a BIP should be written for the
bitcoin-p2p:URI scheme added here, and pairing behaviours.