[RPC] Remove lookup to UTXO set from GetTransaction #15159

amitiuttarwar · 2019-01-13T23:59:51Z

stop checking unspent UTXOs for a transaction when txindex is not enabled, as per conversation here: Getrawtransaction working partially without -txindex is confusing #3220 (comment)
code contributed by sipa

DrahtBot · 2019-01-14T02:18:09Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#14802 (rpc: faster getblockstats using BlockUndo data by FelixWeis)
#14053 (Add address-based index (attempt 4?) by marcinja)
#13903 (Significantly reduce GetTransaction cs_main locking (TheBlueMatt) by MarcoFalke)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

practicalswift · 2019-01-14T13:42:47Z

src/rpc/rawtransaction.cpp

-        g_txindex->BlockUntilSyncedToCurrentChain();
-    }
+        // Allow txindex to catch up if we need to query it and before we acquire cs_main.
+        if (!pblockindex) {


pblockindex == nullptr will always hold here, right?

test/functional/wallet_basic.py

laanwj · 2019-01-14T15:37:30Z

Concept ACK

maflcko · 2019-01-14T15:48:15Z

Slightly tend to NACK. If I am not mistaken, this will force some user to enable -txindex, which seems unintended. Otherwise they might run into a race condition where they are first notified of a tx in the mempool, then try to getrawtransaction that tx, which might sometimes fail because it was added to a block in the meantime.

jnewbery

Thanks for picking this up @amitiuttarwar! Looks good. I have a few high-level comments.

The PR description (#15159 (comment)) gets added to the commit log when the PR is merged (see 1cfbb16 for example). For that reason, I try to keep my PR descriptions as pure descriptions of the new/changed functionality, and add contextual notes (eg if this PR is the rebase of commits from another PR) to the first comment in the PR. See #13926 for example.
We try to make sure that the binary builds and all tests pass on every intermediate commit, so we can use git bisect. That means that if functionality changes and the tests need to change to still pass, then the product and test changes should be in the same commit. For this PR, I suggest you have two commits: one for 'Update getrawtransaction interface' and one for '[RPC] Simplify gettxoutproof method'. If you're worried about losing authorship information in the commit logs, you can always add an extra line to the commit message like "Additional code contributed by " (don't use @ or that user will get annoying notifications in github), although in this case I don't think that matters too much. I'm fine for you to use my code without the authorship data.
As you've already pointed out to me, the RPC help text for gettxoutproof should be updated.

src/rpc/rawtransaction.cpp

jnewbery · 2019-01-14T15:53:08Z

Otherwise they might run into a race condition where they are first notified of a tx in the mempool, then try to getrawtransaction that tx, which might sometimes fail because it was added to a block in the meantime.

Even without this change, that race condition exists (if the tx's outputs are spent in the same block).

I think the race is sufficiently rare that it's not realistically an issue, but we should definitely make sure that the error messages are clear enough in this case - ie it's explicit that the tx was not found in the mempool.

amitiuttarwar · 2019-01-18T07:39:06Z

thanks for the feedback @jnewbery. LMK if the PR looks okay now.

src/rpc/rawtransaction.cpp

jnewbery

Looking at this again, I recommend you drop the second commit entirely and save it for a follow-up PR.

Currently the first commit doesn't build on its own, since the change here: https://github.com/bitcoin/bitcoin/pull/15159/files#diff-01aa7d1d32f1b9e5a836c9c411978918R259 needs to be part of the first commit. The change to gettxoutproof should be removed from the first commit (since the gettxoutproof behaviour only changes in the second commit).

src/rpc/rawtransaction.cpp

test/functional/rpc_txoutproof.py

test/functional/feature_segwit.py

amitiuttarwar · 2019-01-21T06:00:40Z

ok updated so this PR focuses solely on changes to getrawtransaction.

laanwj · 2019-01-21T17:43:15Z

I think this needs mention in the release notes due to changed getrawtransaction semantics?

src/rpc/rawtransaction.cpp

test/functional/feature_segwit.py

amitiuttarwar · 2019-01-24T06:36:43Z

AppVeyor build is failing on a test that passes locally. I'll look into it soon, but if anyone cruises through here and has any pointers (first time using AppVeyor), feel free to share :)

jnewbery · 2019-01-24T14:53:51Z

AppVeyor has a lot of spurious failures. It can be ignored!

doc/release-notes.md

test/functional/rpc_psbt.py

src/validation.cpp

Empact · 2019-02-01T10:16:48Z

@promag if I'm not mistaken, I think #15253 will help debug that failure

fa5278a qa: Use wallet to retrieve raw transactions (MarcoFalke) fa21983 qa: Style-only fixes in touched files (MarcoFalke) Pull request description: Instead of asking the coin database and block storage about a transaction, pull it directly from the wallet in wallet related tests. This refactoring only makes sense in light of bitcoin#15159. <sub>This product may contain minor stylistic cleanups Tree-SHA512: ec34c7150d873da9f19fead3f7e3f758baba5ef10061942384c470a47a6f320690109be9c5160f0c8bc228272a729653d44c78471455337318f657d6c164ba23

…ption 4701239 [Docs] Small updates to getrawtransaction description (Amiti Uttarwar) Pull request description: As per review comments on bitcoin#15159 Tree-SHA512: 0bbbe956b47d177f7e67c5ab2048287783327d9e07a679d64d79aee3ea8633e769f75b59d3dbce517924ba5d64d6c44f26bf49e16d40612463e460ad1a238129

9999879 refactor: Use RPCHelpMan::IsValidNumArgs in getrawtransaction (MarcoFalke) fa9ff8f doc: Remove misleading hint in getrawtransaction (MarcoFalke) Pull request description: For 0.18.0 I asked this line to be added in #15159, which was wrong because getmempoolentry does not return the raw transaction hex. Tree-SHA512: 7ac85500c8192314347b7283cd369196bb959c124863642b6c1ce73d5662b1cbe4f42ded9c374dac6657458ab70b01810caf1235dd1d2b404bf376ebf09efa69

nikitasius · 2019-06-05T11:53:12Z

well thats a most shittiest update you did.

i obliged to call gettransaction to get blockhash for tx i need
after this i need to call getrawtransaction with blockhash from previous call.

Before i did all in 1 call, not here are 2. What next?

maflcko · 2019-06-09T08:48:04Z

@nikitasius What is in getrawtransaction that is not in gettransaction?

sipa · 2019-06-09T10:42:52Z

@MarcoFalke I think the only missing thing is that gettransaction only returns the hex raw tx, and has no ability to decode it directly. You can of course use decoderawtransaction on the hex output from gettransaction to accomplish the same as getrawtransaction (with txindex, and without knowing the block hash).

nikitasius · 2019-06-10T09:11:51Z

@MarcoFalke in my case: vins
here is a tx:

listunspent 3

[
  {
    "txid": "b423b2b22d6d74376de2887c07f7c84ae890a93d541fcc6dbf3686f2923b2753",
    "vout": 0,
    "address": "2N4p68W5AfTJiEX6B5DUgp2eBWP1m2d9pSY",
    "redeemScript": "0014c13a875f4565d9b39cb7898a30e011e7b03d14ad",
    "scriptPubKey": "a9147ee08cf27aed73648f2ba5df2d6c70a60dc0c74587",
    "amount": 2.99988992,
    "confirmations": 22133,
    "spendable": true,
    "solvable": true,
    "desc": "sh(wpkh([4dc444eb/0'/1'/139']028dd079912c6bd68cc9d2872f1d810aece81ac1f5404105b68cefa571e8ecd0cd))#rtxpgrnv",
    "safe": true
  }
]

gettransaction "b423b2b22d6d74376de2887c07f7c84ae890a93d541fcc6dbf3686f2923b2753"

{
  "amount": -2.00000000,
  "fee": -0.00010746,
  "confirmations": 22133,
  "blockhash": "00000000000000409e394d133807fd4f6b0fd27ade24a6e717ee257e825167e1",
  "blockindex": 4,
  "blocktime": 1559505152,
  "txid": "b423b2b22d6d74376de2887c07f7c84ae890a93d541fcc6dbf3686f2923b2753",
  "walletconflicts": [
  ],
  "time": 1559505089,
  "timereceived": 1559505089,
  "bip125-replaceable": "no",
  "details": [
    {
      "address": "2NAzsxhZUwLEg8ii2tnrUH9wxrPC3edDDaQ",
      "category": "send",
      "amount": -2.00000000,
      "label": "",
      "vout": 1,
      "fee": -0.00010746,
      "abandoned": false
    }
  ],
  "hex": "02000000000101fb78a5db1271cb652e1716a1e00dc23409dc9801deea53da5cde50e11e6877900100000017160014feaec8c89d5f76a80a3c0694ba92a82d2f1bfda8fdffffff020078e1110000000017a9147ee08cf27aed73648f2ba5df2d6c70a60dc0c7458700c2eb0b0000000017a914c2bbb902207a6ea4961ec41da629225a30f95f5a870247304402206f0666187b110c8fd689a08db838150fd919d6df516f8e74b6a7bf632e392d17022023edc46d0cc41e1d98fc5042364a065d7bfb54e2b71d2cf794cc3a17e8daee8701210330e02dbd607553975a833664b9c663a1c1ee81d9f2221b784fe9465bf32db24f7e2f1700"
}

getrawtransaction b423b2b22d6d74376de2887c07f7c84ae890a93d541fcc6dbf3686f2923b2753 1 00000000000000409e394d133807fd4f6b0fd27ade24a6e717ee257e825167e1

{
  "in_active_chain": true,
  "txid": "b423b2b22d6d74376de2887c07f7c84ae890a93d541fcc6dbf3686f2923b2753",
  "hash": "8d497a20df578b57a3190c5380816197b78ce92150c1b62a60e3d1ee4d26e7c9",
  "version": 2,
  "size": 247,
  "vsize": 166,
  "weight": 661,
  "locktime": 1519486,
  "vin": [
    {
      "txid": "9077681ee150de5cda53eade0198dc0934c20de0a116172e65cb7112dba578fb",
      "vout": 1,
      "scriptSig": {
        "asm": "0014feaec8c89d5f76a80a3c0694ba92a82d2f1bfda8",
        "hex": "160014feaec8c89d5f76a80a3c0694ba92a82d2f1bfda8"
      },
      "txinwitness": [
        "304402206f0666187b110c8fd689a08db838150fd919d6df516f8e74b6a7bf632e392d17022023edc46d0cc41e1d98fc5042364a065d7bfb54e2b71d2cf794cc3a17e8daee8701",
        "0330e02dbd607553975a833664b9c663a1c1ee81d9f2221b784fe9465bf32db24f"
      ],
      "sequence": 4294967293
    }
  ],
  "vout": [
    {
      "value": 2.99988992,
      "n": 0,
      "scriptPubKey": {
        "asm": "OP_HASH160 7ee08cf27aed73648f2ba5df2d6c70a60dc0c745 OP_EQUAL",
        "hex": "a9147ee08cf27aed73648f2ba5df2d6c70a60dc0c74587",
        "reqSigs": 1,
        "type": "scripthash",
        "addresses": [
          "2N4p68W5AfTJiEX6B5DUgp2eBWP1m2d9pSY"
        ]
      }
    },
    {
      "value": 2.00000000,
      "n": 1,
      "scriptPubKey": {
        "asm": "OP_HASH160 c2bbb902207a6ea4961ec41da629225a30f95f5a OP_EQUAL",
        "hex": "a914c2bbb902207a6ea4961ec41da629225a30f95f5a87",
        "reqSigs": 1,
        "type": "scripthash",
        "addresses": [
          "2NAzsxhZUwLEg8ii2tnrUH9wxrPC3edDDaQ"
        ]
      }
    }
  ],
  "hex": "02000000000101fb78a5db1271cb652e1716a1e00dc23409dc9801deea53da5cde50e11e6877900100000017160014feaec8c89d5f76a80a3c0694ba92a82d2f1bfda8fdffffff020078e1110000000017a9147ee08cf27aed73648f2ba5df2d6c70a60dc0c7458700c2eb0b0000000017a914c2bbb902207a6ea4961ec41da629225a30f95f5a870247304402206f0666187b110c8fd689a08db838150fd919d6df516f8e74b6a7bf632e392d17022023edc46d0cc41e1d98fc5042364a065d7bfb54e2b71d2cf794cc3a17e8daee8701210330e02dbd607553975a833664b9c663a1c1ee81d9f2221b784fe9465bf32db24f7e2f1700",
  "blockhash": "00000000000000409e394d133807fd4f6b0fd27ade24a6e717ee257e825167e1",
  "confirmations": 22137,
  "time": 1559505152,
  "blocktime": 1559505152
}

then i pick this vin array:

 "vin": [
    {
      "txid": "9077681ee150de5cda53eade0198dc0934c20de0a116172e65cb7112dba578fb",
      "vout": 1,
      "scriptSig": {
        "asm": "0014feaec8c89d5f76a80a3c0694ba92a82d2f1bfda8",
        "hex": "160014feaec8c89d5f76a80a3c0694ba92a82d2f1bfda8"
      },
      "txinwitness": [
        "304402206f0666187b110c8fd689a08db838150fd919d6df516f8e74b6a7bf632e392d17022023edc46d0cc41e1d98fc5042364a065d7bfb54e2b71d2cf794cc3a17e8daee8701",
        "0330e02dbd607553975a833664b9c663a1c1ee81d9f2221b784fe9465bf32db24f"
      ],
      "sequence": 4294967293
    }
  ]

and call getrawtransaction for 9077681ee150de5cda53eade0198dc0934c20de0a116172e65cb7112dba578fb:

{
	"result": {
		"txid": "9077681ee150de5cda53eade0198dc0934c20de0a116172e65cb7112dba578fb",
		"hash": "58d247d5d571b95271b9b01603ac6283410d8c28d48fe69082431122029a1669",
		"version": 2,
		"size": 247,
		"vsize": 166,
		"weight": 661,
		"locktime": 0,
		"vin": [{
			"txid": "ab904f2596bafe5c29110ebe053dbd3d609d238456c7ae97d8c916a1c0a27665",
			"vout": 0,
			"scriptSig": {
				"asm": "0014b56400beea1c0c592f9d89e1f182583c04360743",
				"hex": "160014b56400beea1c0c592f9d89e1f182583c04360743"
			},
			"txinwitness": ["304402201ba93887222fdaac6001a1c54cea3fd78e1fc5b7d48f22c6ed647a330605746702205c4aaba5673efc4a21235cbbf5d61fd6e9ce83aa2fa25507db84a1ff3abdbca401", "0242adf8c0e977e622db8e2776b02129844fdc5d9fddf5bd963aa85ed87a8ee7ec"],
			"sequence": 4294967295
		}],
		"vout": [{
			"value": 11.90559816,
			"n": 0,
			"scriptPubKey": {
				"asm": "OP_HASH160 cabc590e4c35a02b44f77034cea6fcd823d6d18a OP_EQUAL",
				"hex": "a914cabc590e4c35a02b44f77034cea6fcd823d6d18a87",
				"reqSigs": 1,
				"type": "scripthash",
				"addresses": ["2NBjC7g1h3FN7oiLH21DRDCoSUyXhK5heGg"]
			}
		}, {
			"value": 4.99999738,
			"n": 1,
			"scriptPubKey": {
				"asm": "OP_HASH160 ec459c516bb17526fd4fffa02448c6b3f581c065 OP_EQUAL",
				"hex": "a914ec459c516bb17526fd4fffa02448c6b3f581c06587",
				"reqSigs": 1,
				"type": "scripthash",
				"addresses": ["2NEnWrBmNCmtwNQLsifKqkuRNxRtQsvKkd8"]
			}
		}],
		"hex": "020000000001016576a2c0a116c9d897aec75684239d603dbd3d05be0e11295cfeba96254f90ab0000000017160014b56400beea1c0c592f9d89e1f182583c04360743ffffffff024880f6460000000017a914cabc590e4c35a02b44f77034cea6fcd823d6d18a87fa63cd1d0000000017a914ec459c516bb17526fd4fffa02448c6b3f581c065870247304402201ba93887222fdaac6001a1c54cea3fd78e1fc5b7d48f22c6ed647a330605746702205c4aaba5673efc4a21235cbbf5d61fd6e9ce83aa2fa25507db84a1ff3abdbca401210242adf8c0e977e622db8e2776b02129844fdc5d9fddf5bd963aa85ed87a8ee7ec00000000",
		"blockhash": "0000000000000032d4bfc14d4783bc4269a7c1ffdc5bc41b9b2b7aa92baa82a5",
		"confirmations": 23389,
		"time": 1558701822,
		"blocktime": 1558701822
	},
	"error": null,
	"id": "1"
}

then i see what vout n=1 from 2NEnWrBmNCmtwNQLsifKqkuRNxRtQsvKkd8.
so i know which address sent this tx.

jnewbery · 2019-06-10T18:22:56Z

Discussion should move to the issues linked from here rather than on this closed PR.

I would like to make one observation about the last comment (#15159 (comment)). A lot of the complexity comes from the fact that you're trying to apply a 'from address'. Such a concept doesn't exist in bitcoin. A transaction can have multiple txins, each of which refer to a txout that may have a scriptPubKey that encodes to an address.

Addresses should be seen more as single-use invoice identifiers. Trying to apply a from/to address model doesn't fit with the Bitcoin UTXO model and will only cause you headaches!

Summary: bitcoin/bitcoin@04da9f4 --- Depends on D6058 This is a backport of Core [[bitcoin/bitcoin#15159 | PR15159]] Test Plan: ninja check-all Reviewers: #bitcoin_abc, nakihito Reviewed By: nakihito Subscribers: nakihito Differential Revision: https://reviews.bitcoinabc.org/D6062

No need for extra `-txindex` in Dash-specific tests, it's `true` by default

merge bitcoin#16117, bitcoin#18358, bitcoin#17383, bitcoin#21052, bitcoin#14424, bitcoin#15159, bitcoin#14689, bitcoin#14978, partial bitcoin#16908, bitcoin#14978, bitcoin#13932: Auxillary Backports

No need for extra `-txindex` in Dash-specific tests, it's `true` by default

fa5278a qa: Use wallet to retrieve raw transactions (MarcoFalke) fa21983 qa: Style-only fixes in touched files (MarcoFalke) Pull request description: Instead of asking the coin database and block storage about a transaction, pull it directly from the wallet in wallet related tests. This refactoring only makes sense in light of bitcoin#15159. <sub>This product may contain minor stylistic cleanups Tree-SHA512: ec34c7150d873da9f19fead3f7e3f758baba5ef10061942384c470a47a6f320690109be9c5160f0c8bc228272a729653d44c78471455337318f657d6c164ba23

9999879 refactor: Use RPCHelpMan::IsValidNumArgs in getrawtransaction (MarcoFalke) fa9ff8f doc: Remove misleading hint in getrawtransaction (MarcoFalke) Pull request description: For 0.18.0 I asked this line to be added in bitcoin#15159, which was wrong because getmempoolentry does not return the raw transaction hex. Tree-SHA512: 7ac85500c8192314347b7283cd369196bb959c124863642b6c1ce73d5662b1cbe4f42ded9c374dac6657458ab70b01810caf1235dd1d2b404bf376ebf09efa69

fanquake added the RPC/REST/ZMQ label Jan 14, 2019

practicalswift reviewed Jan 14, 2019

View reviewed changes

test/functional/wallet_basic.py Outdated Show resolved Hide resolved

jnewbery reviewed Jan 14, 2019

View reviewed changes

src/rpc/rawtransaction.cpp Outdated Show resolved Hide resolved

amitiuttarwar force-pushed the 13931_rebase branch 4 times, most recently from a5514a4 to 3e6c82a Compare January 18, 2019 07:35

fanquake reviewed Jan 18, 2019

View reviewed changes

src/rpc/rawtransaction.cpp Outdated Show resolved Hide resolved

amitiuttarwar force-pushed the 13931_rebase branch from 3e6c82a to affe684 Compare January 18, 2019 15:26

jnewbery reviewed Jan 18, 2019

View reviewed changes

src/rpc/rawtransaction.cpp Show resolved Hide resolved

test/functional/rpc_txoutproof.py Outdated Show resolved Hide resolved

test/functional/feature_segwit.py Show resolved Hide resolved

amitiuttarwar force-pushed the 13931_rebase branch from affe684 to 94af589 Compare January 21, 2019 05:05

jnewbery reviewed Jan 22, 2019

View reviewed changes

src/rpc/rawtransaction.cpp Outdated Show resolved Hide resolved

test/functional/feature_segwit.py Show resolved Hide resolved

amitiuttarwar force-pushed the 13931_rebase branch from 94af589 to 91ec543 Compare January 24, 2019 05:33

jnewbery reviewed Jan 24, 2019

View reviewed changes

doc/release-notes.md Outdated Show resolved Hide resolved

doc/release-notes.md Outdated Show resolved Hide resolved

maflcko reviewed Jan 24, 2019

View reviewed changes

test/functional/rpc_psbt.py Show resolved Hide resolved

maflcko mentioned this pull request Jan 24, 2019

qa: Use wallet to retrieve raw transactions #15247

Merged

Empact reviewed Jan 25, 2019

View reviewed changes

src/validation.cpp Outdated Show resolved Hide resolved

amitiuttarwar force-pushed the 13931_rebase branch 2 times, most recently from e351a94 to 02021ec Compare January 27, 2019 00:51

[RPC] Update getrawtransaction interface

04da9f4

amitiuttarwar mentioned this pull request Feb 3, 2019

[Docs] Small updates to getrawtransaction description #15332

Merged

tynes mentioned this pull request Feb 5, 2019

getrawtransaction changes bcoin-org/bcoin#690

Open

jnewbery mentioned this pull request Feb 13, 2019

test: Remove TODO comments to remove -txindex option #15395

Closed

maflcko mentioned this pull request Feb 25, 2019

doc: Remove misleading hint in getrawtransaction #15477

Merged

achow101 mentioned this pull request Jun 5, 2019

getrawtransaction fails (0.18.0) #16142

Closed

maflcko mentioned this pull request Jun 10, 2019

wallet: decode raw transaction in gettransaction #16181

Closed

nikitasius mentioned this pull request Jun 10, 2019

[blockchain] make getrawtransaction useful again on pruned nodes #16182

Closed

kwvg added a commit to kwvg/dash that referenced this pull request Aug 5, 2021

merge bitcoin#15159: Remove lookup to UTXO set from GetTransaction

c778a05

kwvg added a commit to kwvg/dash that referenced this pull request Aug 5, 2021

merge bitcoin#15159: Remove lookup to UTXO set from GetTransaction

23c01d6

kwvg added a commit to kwvg/dash that referenced this pull request Aug 5, 2021

merge bitcoin#15159: Remove lookup to UTXO set from GetTransaction

6588912

kwvg added a commit to kwvg/dash that referenced this pull request Aug 5, 2021

merge bitcoin#15159: Remove lookup to UTXO set from GetTransaction

2659960

kwvg added a commit to kwvg/dash that referenced this pull request Aug 9, 2021

merge bitcoin#15159: Remove lookup to UTXO set from GetTransaction

e8e48b3

No need for extra `-txindex` in Dash-specific tests, it's `true` by default

5tefan pushed a commit to 5tefan/dash that referenced this pull request Aug 12, 2021

merge bitcoin#15159: Remove lookup to UTXO set from GetTransaction

56b679f

No need for extra `-txindex` in Dash-specific tests, it's `true` by default

bitcoin locked as resolved and limited conversation to collaborators Dec 16, 2021

[RPC] Remove lookup to UTXO set from GetTransaction #15159

[RPC] Remove lookup to UTXO set from GetTransaction #15159

Uh oh!

Conversation

amitiuttarwar commented Jan 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DrahtBot commented Jan 14, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Conflicts

Uh oh!

practicalswift Jan 14, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

laanwj commented Jan 14, 2019

Uh oh!

maflcko commented Jan 14, 2019

Uh oh!

jnewbery left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jnewbery commented Jan 14, 2019

Uh oh!

amitiuttarwar commented Jan 18, 2019

Uh oh!

Uh oh!

jnewbery left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

amitiuttarwar commented Jan 21, 2019

Uh oh!

laanwj commented Jan 21, 2019

Uh oh!

Uh oh!

Uh oh!

amitiuttarwar commented Jan 24, 2019

Uh oh!

jnewbery commented Jan 24, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Empact commented Feb 1, 2019

Uh oh!

nikitasius commented Jun 5, 2019

Uh oh!

maflcko commented Jun 9, 2019

Uh oh!

sipa commented Jun 9, 2019

Uh oh!

nikitasius commented Jun 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jnewbery commented Jun 10, 2019

Uh oh!

Uh oh!

amitiuttarwar commented Jan 13, 2019 •

edited

Loading

DrahtBot commented Jan 14, 2019 •

edited

Loading

nikitasius commented Jun 10, 2019 •

edited

Loading