Require a public key to be retrieved when signing a P2PKH input #14689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This deserves a regression test. Have a |
|
utACK otherwise 409564a |
If we do not have the public key for a P2PKH input, we should not continue to attempt to sign for it.
409564a to
6b8d86d
Compare
|
@instagibbs I added a test |
|
I can confirm this test fails on master. It also fixes the downstream issue I was seeing. |
|
just to note this issue happens for any native "keyhash" type including native segwit, and this fixes that |
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. Coverage
Updated at: 2018-11-08T22:33:52.852772. |
|
utACK 6b8d86d |
1 similar comment
|
utACK 6b8d86d |
|
utACK 6b8d86d |
sipa
added a commit
that referenced
this pull request
Nov 10, 2018
…KH input 6b8d86d Require a public key to be retrieved when signing a P2PKH input (Andrew Chow) Pull request description: If we do not have the public key for a P2PKH input, we should not continue to attempt to sign for it. This fixes a problem where a PSBT with a P2PKH output would include invalid BIP 32 derivation paths that are missing the public key. Tree-SHA512: 850d5e74c06833da937d5bf0348bd134180be7167b6f9b9cecbf09f75e3543fbad60d0abbc0b9afdfa51ce165aa36168849f24a7c5abf1e75f37ce8f9a13d127
laanwj
added a commit
that referenced
this pull request
Nov 13, 2018
…erialization 4e4de10 Throw error if CPubKey is invalid during PSBT keypath serialization (Gregory Sanders) Pull request description: Related to #14689 We should catch this error before attempting to deserialize it later. Tree-SHA512: d2f3ea7f363818ac70c81ee988231b2bb50d055b6919f7bff3f27120c85a7048bfa183efae33e23e6b81d684bcb8bb81e5b209abb3acbcaff1d88014f4f1aa93
|
Backport? |
|
Marked for backport. |
maflcko
reviewed
Dec 5, 2018
| # Test that psbts with p2pkh outputs are created properly | ||
| p2pkh = self.nodes[0].getnewaddress(address_type='legacy') | ||
| psbt = self.nodes[1].walletcreatefundedpsbt([], [{p2pkh : 1}], 0, {"includeWatching" : True}, True) | ||
| self.nodes[0].decodepsbt(psbt['psbt']) |
There was a problem hiding this comment.
I tried to backport, but the test passes even without the code changes.
Mind taking a look to backport this?
There was a problem hiding this comment.
@MarcoFalke I believe the issue only arose after #14424 (which is also marked for backport), does the test fail if you backport that at the same time?
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
May 11, 2020
…P2PKH input Summary: If we do not have the public key for a P2PKH input, we should not continue to attempt to sign for it. --- Depends on D6028 This is a backport of Core [[bitcoin/bitcoin#14689 | PR14689]] Test Plan: cmake .. -GNinja -DENABLE_WERROR=ON ninja check-all Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D6029
knst
pushed a commit
to knst/dash
that referenced
this pull request
Aug 10, 2021
…ypath serialization 4e4de10 Throw error if CPubKey is invalid during PSBT keypath serialization (Gregory Sanders) Pull request description: Related to bitcoin#14689 We should catch this error before attempting to deserialize it later. Tree-SHA512: d2f3ea7f363818ac70c81ee988231b2bb50d055b6919f7bff3f27120c85a7048bfa183efae33e23e6b81d684bcb8bb81e5b209abb3acbcaff1d88014f4f1aa93
knst
pushed a commit
to knst/dash
that referenced
this pull request
Aug 10, 2021
…ypath serialization 4e4de10 Throw error if CPubKey is invalid during PSBT keypath serialization (Gregory Sanders) Pull request description: Related to bitcoin#14689 We should catch this error before attempting to deserialize it later. Tree-SHA512: d2f3ea7f363818ac70c81ee988231b2bb50d055b6919f7bff3f27120c85a7048bfa183efae33e23e6b81d684bcb8bb81e5b209abb3acbcaff1d88014f4f1aa93
UdjinM6
added a commit
to dashpay/dash
that referenced
this pull request
Aug 10, 2021
merge bitcoin#16117, bitcoin#18358, bitcoin#17383, bitcoin#21052, bitcoin#14424, bitcoin#15159, bitcoin#14689, bitcoin#14978, partial bitcoin#16908, bitcoin#14978, bitcoin#13932: Auxillary Backports
5tefan
pushed a commit
to 5tefan/dash
that referenced
this pull request
Aug 12, 2021
…g a P2PKH input
knst
pushed a commit
to knst/dash
that referenced
this pull request
Aug 16, 2021
…ypath serialization 4e4de10 Throw error if CPubKey is invalid during PSBT keypath serialization (Gregory Sanders) Pull request description: Related to bitcoin#14689 We should catch this error before attempting to deserialize it later. Tree-SHA512: d2f3ea7f363818ac70c81ee988231b2bb50d055b6919f7bff3f27120c85a7048bfa183efae33e23e6b81d684bcb8bb81e5b209abb3acbcaff1d88014f4f1aa93
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Aug 23, 2021
…ypath serialization 4e4de10 Throw error if CPubKey is invalid during PSBT keypath serialization (Gregory Sanders) Pull request description: Related to bitcoin#14689 We should catch this error before attempting to deserialize it later. Tree-SHA512: d2f3ea7f363818ac70c81ee988231b2bb50d055b6919f7bff3f27120c85a7048bfa183efae33e23e6b81d684bcb8bb81e5b209abb3acbcaff1d88014f4f1aa93
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we do not have the public key for a P2PKH input, we should not continue to attempt to sign for it.
This fixes a problem where a PSBT with a P2PKH output would include invalid BIP 32 derivation paths that are missing the public key.