-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
TST: adapt a test to Python 3.14 #18337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
👋 Thank you for your draft pull request! Do you know that you can use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sure the problem is numpy, not python 3.14? I think we probably have had runs with earlier test versions of python 3.14, which would have had numpy 2.3, and numpy was the problem before, but still...
Approving since on balance this almost certainly is correct, and little harm would be done if it wasn't.
Hmm, just saw that the sample log is in fact from a run introducing python 3.14 tests. In that case, perhaps worth checking after all which one is the problem. |
Ah, that's a good point, I didn't consider this possibility. |
I guess we need to try cp313 + numpy dev + windows then. Since I cannot do that locally, I'll open an exploratory PR instead. |
Seems like you were right, numpy 2.4.0dev0 + Python 3.13 doesn't emit the warning either I can easily adapt this PR with the more correct approach then |
58b4875
to
f24454d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, approving for real now!
Sounds good, thanks. |
…337-on-v7.1.x Backport PR #18337 on branch v7.1.x (TST: adapt a test to Python 3.14)
Description
Resolves a compatibility issue discovered in #18336 (example logs)
Follow up to #16778