Skip to content

Conversation

neutrinoceros
Copy link
Contributor

Description

Resolves a compatibility issue discovered in #18336 (example logs)
Follow up to #16778

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

Copy link
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions github-actions bot added the utils label Jun 24, 2025
Copy link
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@neutrinoceros neutrinoceros marked this pull request as ready for review June 24, 2025 11:35
@neutrinoceros neutrinoceros requested a review from saimn as a code owner June 24, 2025 11:35
Copy link
Contributor

@mhvk mhvk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure the problem is numpy, not python 3.14? I think we probably have had runs with earlier test versions of python 3.14, which would have had numpy 2.3, and numpy was the problem before, but still...

Approving since on balance this almost certainly is correct, and little harm would be done if it wasn't.

@mhvk
Copy link
Contributor

mhvk commented Jun 24, 2025

Hmm, just saw that the sample log is in fact from a run introducing python 3.14 tests. In that case, perhaps worth checking after all which one is the problem.

@neutrinoceros
Copy link
Contributor Author

Ah, that's a good point, I didn't consider this possibility.
I looked for recent changes in numpy and didn't find anything relevant, so it's likely the case that the real change was in Python.

@neutrinoceros
Copy link
Contributor Author

I guess we need to try cp313 + numpy dev + windows then. Since I cannot do that locally, I'll open an exploratory PR instead.

@neutrinoceros
Copy link
Contributor Author

Seems like you were right, numpy 2.4.0dev0 + Python 3.13 doesn't emit the warning either
https://github.com/astropy/astropy/actions/runs/15851477469/job/44685826184

I can easily adapt this PR with the more correct approach then

@neutrinoceros neutrinoceros force-pushed the io.fits/tst/cp314-compat branch from 58b4875 to f24454d Compare June 24, 2025 13:27
@neutrinoceros neutrinoceros changed the title TST: adapt a test to numpy 2.4.0dev0 TST: adapt a test to Python 3.14 Jun 24, 2025
Copy link
Contributor

@mhvk mhvk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, approving for real now!

@saimn
Copy link
Contributor

saimn commented Jun 24, 2025

Sounds good, thanks.

@saimn saimn merged commit e81301d into astropy:main Jun 24, 2025
31 of 32 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Jun 24, 2025
@neutrinoceros neutrinoceros deleted the io.fits/tst/cp314-compat branch June 24, 2025 17:56
pllim added a commit that referenced this pull request Jun 25, 2025
…337-on-v7.1.x

Backport PR #18337 on branch v7.1.x (TST: adapt a test to Python 3.14)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants